virsh: undefine: Clarify things around snapshots

[libvirt] [PATCH 0/3] virsh: undefine: Clarify things around snapshots

Posted by Peter Krempa 4 years, 10 months ago

Peter Krempa (3):
  virsh: undefine: Clarify help string for --snapshots-metadata
  virsh: undefine: Rename --delete-snapshots to
    --delete-storage-volume-snapshots
  virsh: undefine: Clarify that --delete-storage-volume-snapshots causes
    failures

 tools/virsh-domain.c |  6 +++++-
 tools/virsh.pod      | 10 ++++++----
 2 files changed, 11 insertions(+), 5 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] virsh: undefine: Clarify things around snapshots

Posted by Eric Blake 4 years, 10 months ago

On 6/5/19 6:23 AM, Peter Krempa wrote:
> Peter Krempa (3):
>   virsh: undefine: Clarify help string for --snapshots-metadata
>   virsh: undefine: Rename --delete-snapshots to
>     --delete-storage-volume-snapshots
>   virsh: undefine: Clarify that --delete-storage-volume-snapshots causes
>     failures

Interesting - I think I had copied '--delete-snapshots' into
'--delete-checkpoints' in my incremental backup work because I had
fallen prey to the wrong meaning that you are trying to clean up here. I
guess that's another thing I get to revisit before posting v9.

ACK series once the grammar in 3/3 is fixed.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] virsh: undefine: Clarify things around snapshots

Posted by Fabiano Fidêncio 4 years, 10 months ago

On Wed, Jun 5, 2019 at 1:27 PM Peter Krempa <pkrempa@redhat.com> wrote:
>
> Peter Krempa (3):
>   virsh: undefine: Clarify help string for --snapshots-metadata
>   virsh: undefine: Rename --delete-snapshots to
>     --delete-storage-volume-snapshots
>   virsh: undefine: Clarify that --delete-storage-volume-snapshots causes
>     failures
>
>  tools/virsh-domain.c |  6 +++++-
>  tools/virsh.pod      | 10 ++++++----
>  2 files changed, 11 insertions(+), 5 deletions(-)

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>

Please, take this review with a grain of salt and feel free to wait
for a libvirt developer to act on this.

Best Regards,
-- 
Fabiano Fidêncio

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list