In my review of 89320788ac4 I've simplified assigning disk errors
too much as the code I've changed it to will set
VIR_DOMAIN_DISK_ERROR_NONE. This is in contradiction with our
documentation which specifies that disks with no errors are not
reported.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/test/test_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index cfa739ecca..ad89663de2 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -3067,7 +3067,7 @@ static int testDomainGetDiskErrors(virDomainPtr dom,
         for (i = 0; i < MIN(vm->def->ndisks, maxerrors); i++) {
             if (VIR_STRDUP(errors[i].disk, vm->def->disks[i]->dst) < 0)
                 goto cleanup;
-            errors[i].error = i % VIR_DOMAIN_DISK_ERROR_LAST;
+            errors[i].error = (i % (VIR_DOMAIN_DISK_ERROR_LAST - 1)) + 1;
         }
         ret = i;
     } else {
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, 2019-05-14 at 17:12 +0200, Michal Privoznik wrote:
> In my review of 89320788ac4 I've simplified assigning disk errors
> too much as the code I've changed it to will set
> VIR_DOMAIN_DISK_ERROR_NONE. This is in contradiction with our
> documentation which specifies that disks with no errors are not
> reported.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/test/test_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list