From nobody Sun Feb 8 22:10:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557846787; cv=none; d=zoho.com; s=zohoarc; b=Hc8hbRBsf+3m4QU0p/dNd6XrBCgx5HQWBJCBApQOdXAgJEwo2I7ROcZvQAAMpwJW9EH7dpHgXGD9WFDHfBn2MpVyxoUEG1UxS++C0t0lxIwBJqPZvD+qrca9y0v2w+SMc0HhRyOkR8MeWjUQvvRCl8ctsUl9AewjtYUsL9sIY14= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557846787; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=GkOuYKastlyGEX1NSRQjbnV9OvE6iJaVych/m1oE9XU=; b=QPSpuJLnMzUqfuZhLwEiBpzVz4ne9JfMsuj003ygGWjh7qA3GZEMgmSfli7+p0gIGEz3vfHy6SA4CEkgjvz0RDe9laLrHAMMl7YlY8vHlST3c7Hjo/ZkZ/G3D2i2Cw5m3BO9iJsBUSnQ//twZTGg9lmBAhkIjvIQB4kA8r/P07o= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1557846787359578.8750260123953; Tue, 14 May 2019 08:13:07 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9A054307D977; Tue, 14 May 2019 15:12:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 402B75C5FE; Tue, 14 May 2019 15:12:56 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 875C418089CB; Tue, 14 May 2019 15:12:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x4EFCltj024939 for ; Tue, 14 May 2019 11:12:47 -0400 Received: by smtp.corp.redhat.com (Postfix) id A82381975C; Tue, 14 May 2019 15:12:47 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A94B19C5A; Tue, 14 May 2019 15:12:46 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Tue, 14 May 2019 17:12:42 +0200 Message-Id: <92f340ec94fb197edfe3c4258f56bee8216d257c.1557846694.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: stamatis.iliass@gmail.com Subject: [libvirt] [PATCH 2/2] test_driver: Don't report VIR_DOMAIN_DISK_ERROR_NONE X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 14 May 2019 15:13:06 +0000 (UTC) Content-Type: text/plain; charset="utf-8" In my review of 89320788ac4 I've simplified assigning disk errors too much as the code I've changed it to will set VIR_DOMAIN_DISK_ERROR_NONE. This is in contradiction with our documentation which specifies that disks with no errors are not reported. Signed-off-by: Michal Privoznik Reviewed-by: Andrea Bolognani --- src/test/test_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index cfa739ecca..ad89663de2 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -3067,7 +3067,7 @@ static int testDomainGetDiskErrors(virDomainPtr dom, for (i =3D 0; i < MIN(vm->def->ndisks, maxerrors); i++) { if (VIR_STRDUP(errors[i].disk, vm->def->disks[i]->dst) < 0) goto cleanup; - errors[i].error =3D i % VIR_DOMAIN_DISK_ERROR_LAST; + errors[i].error =3D (i % (VIR_DOMAIN_DISK_ERROR_LAST - 1)) + 1; } ret =3D i; } else { --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list