[v2] cgroup cleanups and preparation for v2

[libvirt] [PATCH v2 2/9] vircgroup: fix bug in virCgroupEnableMissingControllers

Posted by Pavel Hrdina 7 years, 4 months ago

If we are on host with systemd we need to build cgroup hierarchy
ourselves for controllers that are not managed by systemd.

As a starting parent we need to force root group because
virCgroupMakeGroup() takes that parent in order to inherit values
for cpuset controller.

By default cpuset controller is managed by systemd so we will never
hit the issue but for v2 cgroups we need to use parent cgroup every
time.

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 src/util/vircgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index f9e387c86d..13f5e0d83a 100644
--- a/src/util/vircgroup.c
+++ b/src/util/vircgroup.c
@@ -1491,7 +1491,7 @@ virCgroupEnableMissingControllers(char *path,
     int ret = -1;
 
     if (virCgroupNew(pidleader,
-                     "",
+                     "/",
                      NULL,
                      controllers,
                      &parent) < 0)
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 2/9] vircgroup: fix bug in virCgroupEnableMissingControllers

Posted by Ján Tomko 7 years, 4 months ago

On Thu, Sep 20, 2018 at 10:54:31AM +0200, Pavel Hrdina wrote:
>If we are on host with systemd we need to build cgroup hierarchy
>ourselves for controllers that are not managed by systemd.
>
>As a starting parent we need to force root group because
>virCgroupMakeGroup() takes that parent in order to inherit values
>for cpuset controller.
>
>By default cpuset controller is managed by systemd so we will never
>hit the issue but for v2 cgroups we need to use parent cgroup every
>time.
>
>Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
>Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
>---
> src/util/vircgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list