1. Patchew
  2. Libvirt
  3. View series

[libvirt] [PATCH v2 0/9] cgroup cleanups and preparation for v2

Pavel Hrdina posted 9 patches 5 years, 7 months ago
Failed in applying to current master (apply log)
src/libvirt-lxc.c                             |   2 +-
src/libvirt_private.syms                      |   6 +-
src/lxc/lxc_controller.c                      |   4 +-
src/qemu/qemu_process.c                       |   4 +-
src/qemu/qemu_tpm.c                           |   2 +-
src/util/vircgroup.c                          | 143 +++++++-----
src/util/vircgroup.h                          |   5 +-
src/util/vircgrouppriv.h                      |   4 -
tests/vircgroupdata/all-in-one.cgroups        |   7 +
tests/vircgroupdata/all-in-one.mounts         |   2 +-
tests/vircgroupdata/all-in-one.parsed         |  12 +-
tests/vircgroupdata/all-in-one.self.cgroup    |   1 +
tests/vircgroupdata/cgroups1.cgroups          |  11 +
tests/vircgroupdata/cgroups1.self.cgroup      |  11 +
tests/vircgroupdata/cgroups2.cgroups          |  10 +
tests/vircgroupdata/cgroups2.self.cgroup      |  10 +
tests/vircgroupdata/cgroups3.cgroups          |  12 +
tests/vircgroupdata/cgroups3.self.cgroup      |  12 +
tests/vircgroupdata/fedora-18.cgroups         |  10 +
tests/vircgroupdata/fedora-18.self.cgroup     |   9 +
tests/vircgroupdata/fedora-21.cgroups         |  12 +
tests/vircgroupdata/fedora-21.self.cgroup     |  10 +
tests/vircgroupdata/kubevirt.cgroups          |  10 +
tests/vircgroupdata/kubevirt.self.cgroup      |  10 +
tests/vircgroupdata/logind.cgroups            |  10 +
tests/vircgroupdata/logind.mounts             |   2 +
tests/vircgroupdata/logind.self.cgroup        |   1 +
tests/vircgroupdata/no-cgroups.cgroups        |   8 +
tests/vircgroupdata/no-cgroups.parsed         |  10 -
tests/vircgroupdata/no-cgroups.self.cgroup    |   0
tests/vircgroupdata/ovirt-node-6.6.cgroups    |   9 +
.../vircgroupdata/ovirt-node-6.6.self.cgroup  |   8 +
tests/vircgroupdata/ovirt-node-7.1.cgroups    |  11 +
.../vircgroupdata/ovirt-node-7.1.self.cgroup  |  10 +
tests/vircgroupdata/rhel-7.1.cgroups          |  11 +
tests/vircgroupdata/rhel-7.1.self.cgroup      |  10 +
tests/vircgroupdata/systemd.cgroups           |   8 +
tests/vircgroupdata/systemd.mounts            |  11 +
tests/vircgroupdata/systemd.self.cgroup       |   6 +
tests/vircgroupmock.c                         | 206 ++----------------
tests/vircgrouptest.c                         |  48 ++--
41 files changed, 399 insertions(+), 289 deletions(-)
create mode 100644 tests/vircgroupdata/all-in-one.cgroups
create mode 100644 tests/vircgroupdata/all-in-one.self.cgroup
create mode 100644 tests/vircgroupdata/cgroups1.cgroups
create mode 100644 tests/vircgroupdata/cgroups1.self.cgroup
create mode 100644 tests/vircgroupdata/cgroups2.cgroups
create mode 100644 tests/vircgroupdata/cgroups2.self.cgroup
create mode 100644 tests/vircgroupdata/cgroups3.cgroups
create mode 100644 tests/vircgroupdata/cgroups3.self.cgroup
create mode 100644 tests/vircgroupdata/fedora-18.cgroups
create mode 100644 tests/vircgroupdata/fedora-18.self.cgroup
create mode 100644 tests/vircgroupdata/fedora-21.cgroups
create mode 100644 tests/vircgroupdata/fedora-21.self.cgroup
create mode 100644 tests/vircgroupdata/kubevirt.cgroups
create mode 100644 tests/vircgroupdata/kubevirt.self.cgroup
create mode 100644 tests/vircgroupdata/logind.cgroups
create mode 100644 tests/vircgroupdata/logind.mounts
create mode 100644 tests/vircgroupdata/logind.self.cgroup
create mode 100644 tests/vircgroupdata/no-cgroups.cgroups
delete mode 100644 tests/vircgroupdata/no-cgroups.parsed
create mode 100644 tests/vircgroupdata/no-cgroups.self.cgroup
create mode 100644 tests/vircgroupdata/ovirt-node-6.6.cgroups
create mode 100644 tests/vircgroupdata/ovirt-node-6.6.self.cgroup
create mode 100644 tests/vircgroupdata/ovirt-node-7.1.cgroups
create mode 100644 tests/vircgroupdata/ovirt-node-7.1.self.cgroup
create mode 100644 tests/vircgroupdata/rhel-7.1.cgroups
create mode 100644 tests/vircgroupdata/rhel-7.1.self.cgroup
create mode 100644 tests/vircgroupdata/systemd.cgroups
create mode 100644 tests/vircgroupdata/systemd.mounts
create mode 100644 tests/vircgroupdata/systemd.self.cgroup
[libvirt] [PATCH v2 0/9] cgroup cleanups and preparation for v2
Posted by Pavel Hrdina 5 years, 7 months ago 
Pavel Hrdina (9):
  vircgroup: cleanup controllers not managed by systemd on error
  vircgroup: fix bug in virCgroupEnableMissingControllers
  vircgroup: rename virCgroupAdd.*Task to virCgroupAdd.*Process
  vircgroup: introduce virCgroupTaskFlags
  vircgroup: introduce virCgroupAddThread
  vircgroupmock: cleanup unused cgroup files
  vircgroupmock: rewrite cgroup fopen mocking
  vircgrouptest: call virCgroupDetectMounts directly
  vircgrouptest: call virCgroupNewSelf instead virCgroupDetectMounts

 src/libvirt-lxc.c                             |   2 +-
 src/libvirt_private.syms                      |   6 +-
 src/lxc/lxc_controller.c                      |   4 +-
 src/qemu/qemu_process.c                       |   4 +-
 src/qemu/qemu_tpm.c                           |   2 +-
 src/util/vircgroup.c                          | 143 +++++++-----
 src/util/vircgroup.h                          |   5 +-
 src/util/vircgrouppriv.h                      |   4 -
 tests/vircgroupdata/all-in-one.cgroups        |   7 +
 tests/vircgroupdata/all-in-one.mounts         |   2 +-
 tests/vircgroupdata/all-in-one.parsed         |  12 +-
 tests/vircgroupdata/all-in-one.self.cgroup    |   1 +
 tests/vircgroupdata/cgroups1.cgroups          |  11 +
 tests/vircgroupdata/cgroups1.self.cgroup      |  11 +
 tests/vircgroupdata/cgroups2.cgroups          |  10 +
 tests/vircgroupdata/cgroups2.self.cgroup      |  10 +
 tests/vircgroupdata/cgroups3.cgroups          |  12 +
 tests/vircgroupdata/cgroups3.self.cgroup      |  12 +
 tests/vircgroupdata/fedora-18.cgroups         |  10 +
 tests/vircgroupdata/fedora-18.self.cgroup     |   9 +
 tests/vircgroupdata/fedora-21.cgroups         |  12 +
 tests/vircgroupdata/fedora-21.self.cgroup     |  10 +
 tests/vircgroupdata/kubevirt.cgroups          |  10 +
 tests/vircgroupdata/kubevirt.self.cgroup      |  10 +
 tests/vircgroupdata/logind.cgroups            |  10 +
 tests/vircgroupdata/logind.mounts             |   2 +
 tests/vircgroupdata/logind.self.cgroup        |   1 +
 tests/vircgroupdata/no-cgroups.cgroups        |   8 +
 tests/vircgroupdata/no-cgroups.parsed         |  10 -
 tests/vircgroupdata/no-cgroups.self.cgroup    |   0
 tests/vircgroupdata/ovirt-node-6.6.cgroups    |   9 +
 .../vircgroupdata/ovirt-node-6.6.self.cgroup  |   8 +
 tests/vircgroupdata/ovirt-node-7.1.cgroups    |  11 +
 .../vircgroupdata/ovirt-node-7.1.self.cgroup  |  10 +
 tests/vircgroupdata/rhel-7.1.cgroups          |  11 +
 tests/vircgroupdata/rhel-7.1.self.cgroup      |  10 +
 tests/vircgroupdata/systemd.cgroups           |   8 +
 tests/vircgroupdata/systemd.mounts            |  11 +
 tests/vircgroupdata/systemd.self.cgroup       |   6 +
 tests/vircgroupmock.c                         | 206 ++----------------
 tests/vircgrouptest.c                         |  48 ++--
 41 files changed, 399 insertions(+), 289 deletions(-)
 create mode 100644 tests/vircgroupdata/all-in-one.cgroups
 create mode 100644 tests/vircgroupdata/all-in-one.self.cgroup
 create mode 100644 tests/vircgroupdata/cgroups1.cgroups
 create mode 100644 tests/vircgroupdata/cgroups1.self.cgroup
 create mode 100644 tests/vircgroupdata/cgroups2.cgroups
 create mode 100644 tests/vircgroupdata/cgroups2.self.cgroup
 create mode 100644 tests/vircgroupdata/cgroups3.cgroups
 create mode 100644 tests/vircgroupdata/cgroups3.self.cgroup
 create mode 100644 tests/vircgroupdata/fedora-18.cgroups
 create mode 100644 tests/vircgroupdata/fedora-18.self.cgroup
 create mode 100644 tests/vircgroupdata/fedora-21.cgroups
 create mode 100644 tests/vircgroupdata/fedora-21.self.cgroup
 create mode 100644 tests/vircgroupdata/kubevirt.cgroups
 create mode 100644 tests/vircgroupdata/kubevirt.self.cgroup
 create mode 100644 tests/vircgroupdata/logind.cgroups
 create mode 100644 tests/vircgroupdata/logind.mounts
 create mode 100644 tests/vircgroupdata/logind.self.cgroup
 create mode 100644 tests/vircgroupdata/no-cgroups.cgroups
 delete mode 100644 tests/vircgroupdata/no-cgroups.parsed
 create mode 100644 tests/vircgroupdata/no-cgroups.self.cgroup
 create mode 100644 tests/vircgroupdata/ovirt-node-6.6.cgroups
 create mode 100644 tests/vircgroupdata/ovirt-node-6.6.self.cgroup
 create mode 100644 tests/vircgroupdata/ovirt-node-7.1.cgroups
 create mode 100644 tests/vircgroupdata/ovirt-node-7.1.self.cgroup
 create mode 100644 tests/vircgroupdata/rhel-7.1.cgroups
 create mode 100644 tests/vircgroupdata/rhel-7.1.self.cgroup
 create mode 100644 tests/vircgroupdata/systemd.cgroups
 create mode 100644 tests/vircgroupdata/systemd.mounts
 create mode 100644 tests/vircgroupdata/systemd.self.cgroup

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/9] cgroup cleanups and preparation for v2
Posted by Fabiano Fidêncio 5 years, 7 months ago 
On Thu, Sep 20, 2018 at 10:54 AM, Pavel Hrdina <phrdina@redhat.com> wrote:

> Pavel Hrdina (9):
>   vircgroup: cleanup controllers not managed by systemd on error
>   vircgroup: fix bug in virCgroupEnableMissingControllers
>   vircgroup: rename virCgroupAdd.*Task to virCgroupAdd.*Process
>   vircgroup: introduce virCgroupTaskFlags
>   vircgroup: introduce virCgroupAddThread
>   vircgroupmock: cleanup unused cgroup files
>   vircgroupmock: rewrite cgroup fopen mocking
>   vircgrouptest: call virCgroupDetectMounts directly
>   vircgrouptest: call virCgroupNewSelf instead virCgroupDetectMounts
>
>  src/libvirt-lxc.c                             |   2 +-
>  src/libvirt_private.syms                      |   6 +-
>  src/lxc/lxc_controller.c                      |   4 +-
>  src/qemu/qemu_process.c                       |   4 +-
>  src/qemu/qemu_tpm.c                           |   2 +-
>  src/util/vircgroup.c                          | 143 +++++++-----
>  src/util/vircgroup.h                          |   5 +-
>  src/util/vircgrouppriv.h                      |   4 -
>  tests/vircgroupdata/all-in-one.cgroups        |   7 +
>  tests/vircgroupdata/all-in-one.mounts         |   2 +-
>  tests/vircgroupdata/all-in-one.parsed         |  12 +-
>  tests/vircgroupdata/all-in-one.self.cgroup    |   1 +
>  tests/vircgroupdata/cgroups1.cgroups          |  11 +
>  tests/vircgroupdata/cgroups1.self.cgroup      |  11 +
>  tests/vircgroupdata/cgroups2.cgroups          |  10 +
>  tests/vircgroupdata/cgroups2.self.cgroup      |  10 +
>  tests/vircgroupdata/cgroups3.cgroups          |  12 +
>  tests/vircgroupdata/cgroups3.self.cgroup      |  12 +
>  tests/vircgroupdata/fedora-18.cgroups         |  10 +
>  tests/vircgroupdata/fedora-18.self.cgroup     |   9 +
>  tests/vircgroupdata/fedora-21.cgroups         |  12 +
>  tests/vircgroupdata/fedora-21.self.cgroup     |  10 +
>  tests/vircgroupdata/kubevirt.cgroups          |  10 +
>  tests/vircgroupdata/kubevirt.self.cgroup      |  10 +
>  tests/vircgroupdata/logind.cgroups            |  10 +
>  tests/vircgroupdata/logind.mounts             |   2 +
>  tests/vircgroupdata/logind.self.cgroup        |   1 +
>  tests/vircgroupdata/no-cgroups.cgroups        |   8 +
>  tests/vircgroupdata/no-cgroups.parsed         |  10 -
>  tests/vircgroupdata/no-cgroups.self.cgroup    |   0
>  tests/vircgroupdata/ovirt-node-6.6.cgroups    |   9 +
>  .../vircgroupdata/ovirt-node-6.6.self.cgroup  |   8 +
>  tests/vircgroupdata/ovirt-node-7.1.cgroups    |  11 +
>  .../vircgroupdata/ovirt-node-7.1.self.cgroup  |  10 +
>  tests/vircgroupdata/rhel-7.1.cgroups          |  11 +
>  tests/vircgroupdata/rhel-7.1.self.cgroup      |  10 +
>  tests/vircgroupdata/systemd.cgroups           |   8 +
>  tests/vircgroupdata/systemd.mounts            |  11 +
>  tests/vircgroupdata/systemd.self.cgroup       |   6 +
>  tests/vircgroupmock.c                         | 206 ++----------------
>  tests/vircgrouptest.c                         |  48 ++--
>  41 files changed, 399 insertions(+), 289 deletions(-)
>  create mode 100644 tests/vircgroupdata/all-in-one.cgroups
>  create mode 100644 tests/vircgroupdata/all-in-one.self.cgroup
>  create mode 100644 tests/vircgroupdata/cgroups1.cgroups
>  create mode 100644 tests/vircgroupdata/cgroups1.self.cgroup
>  create mode 100644 tests/vircgroupdata/cgroups2.cgroups
>  create mode 100644 tests/vircgroupdata/cgroups2.self.cgroup
>  create mode 100644 tests/vircgroupdata/cgroups3.cgroups
>  create mode 100644 tests/vircgroupdata/cgroups3.self.cgroup
>  create mode 100644 tests/vircgroupdata/fedora-18.cgroups
>  create mode 100644 tests/vircgroupdata/fedora-18.self.cgroup
>  create mode 100644 tests/vircgroupdata/fedora-21.cgroups
>  create mode 100644 tests/vircgroupdata/fedora-21.self.cgroup
>  create mode 100644 tests/vircgroupdata/kubevirt.cgroups
>  create mode 100644 tests/vircgroupdata/kubevirt.self.cgroup
>  create mode 100644 tests/vircgroupdata/logind.cgroups
>  create mode 100644 tests/vircgroupdata/logind.mounts
>  create mode 100644 tests/vircgroupdata/logind.self.cgroup
>  create mode 100644 tests/vircgroupdata/no-cgroups.cgroups
>  delete mode 100644 tests/vircgroupdata/no-cgroups.parsed
>  create mode 100644 tests/vircgroupdata/no-cgroups.self.cgroup
>  create mode 100644 tests/vircgroupdata/ovirt-node-6.6.cgroups
>  create mode 100644 tests/vircgroupdata/ovirt-node-6.6.self.cgroup
>  create mode 100644 tests/vircgroupdata/ovirt-node-7.1.cgroups
>  create mode 100644 tests/vircgroupdata/ovirt-node-7.1.self.cgroup
>  create mode 100644 tests/vircgroupdata/rhel-7.1.cgroups
>  create mode 100644 tests/vircgroupdata/rhel-7.1.self.cgroup
>  create mode 100644 tests/vircgroupdata/systemd.cgroups
>  create mode 100644 tests/vircgroupdata/systemd.mounts
>  create mode 100644 tests/vircgroupdata/systemd.self.cgroup
>
> --
> 2.17.1
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/9] cgroup cleanups and preparation for v2
Posted by Pavel Hrdina 5 years, 6 months ago 
On Thu, Sep 20, 2018 at 09:41:28PM +0200, Fabiano Fidêncio wrote:
> On Thu, Sep 20, 2018 at 10:54 AM, Pavel Hrdina <phrdina@redhat.com> wrote:

Thanks for the review, pushed now.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.