qemu: Properly release job in qemuDomainSaveInternal

[libvirt PATCH for 8.6.0] qemu: Properly release job in qemuDomainSaveInternal

Jiri Denemark posted 1 patch 1 year, 9 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cd8e267f213725efe76e48506359f796a0d85a20.1658929436.git.jdenemar@redhat.com

src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt PATCH for 8.6.0] qemu: Properly release job in qemuDomainSaveInternal

Posted by Jiri Denemark 1 year, 9 months ago

The function would fail to release the job in case
qemuMigrationSrcIsAllowed failed.

Fixes v8.5.0-157-g69e0e33873

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 src/qemu/qemu_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 9013e6fb8d..019ec4a035 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -2656,7 +2656,7 @@ qemuDomainSaveInternal(virQEMUDriver *driver,
         goto cleanup;
 
     if (!qemuMigrationSrcIsAllowed(driver, vm, false, VIR_ASYNC_JOB_SAVE, 0))
-        goto cleanup;
+        goto endjob;
 
     if (!virDomainObjIsActive(vm)) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-- 
2.35.1

Re: [libvirt PATCH for 8.6.0] qemu: Properly release job in qemuDomainSaveInternal

Posted by Pavel Hrdina 1 year, 9 months ago

On Wed, Jul 27, 2022 at 03:43:56PM +0200, Jiri Denemark wrote:
> The function would fail to release the job in case
> qemuMigrationSrcIsAllowed failed.
> 
> Fixes v8.5.0-157-g69e0e33873
> 
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  src/qemu/qemu_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>