From nobody Tue May 7 19:00:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1658929491; cv=none; d=zohomail.com; s=zohoarc; b=N9M7NGw75o/72AQJI3Ep/1nDsLpz+2qMtLr9FK0UDbUpuuUVvzvb4BKup2oZQdVmazgbv4FqOxjpXOD0jAt0onkI19eiBaKaKeFL+9WjwpLwlcHRKq1EM/I+6hPpAe6QloAgYcOOb85xsG55wyzbAq5E97mUOULqkGWkCBnaMSI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658929491; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=OZ1SbyAubeo6J3hLFVhGKnPheo+NqHAidMoGk1rvP2w=; b=f+QLHhpKxZyAElOWM9cxTAHeYf1nlNxOzhs6vqDwRZOXmKu636Ox6bzUgfjrFFNvCvNPx4PSrpA7fUFsz/HRWDPUg23nwJfxuLDYUgonGspsZQwfcuq4bHmcgoFQp2KANspnvoDhGHc5JB9HPTsY98b6ydA27jwZB1FllYkaY2Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1658929491743670.4391617744877; Wed, 27 Jul 2022 06:44:51 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-668-lKgCz7jLOiKT6lnaO69ncQ-1; Wed, 27 Jul 2022 09:44:47 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DF89885A586; Wed, 27 Jul 2022 13:44:44 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id E9F5AC27D95; Wed, 27 Jul 2022 13:44:42 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C5E371945DA3; Wed, 27 Jul 2022 13:44:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8A4DF1945DA2 for ; Wed, 27 Jul 2022 13:44:41 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 59F96112131E; Wed, 27 Jul 2022 13:44:41 +0000 (UTC) Received: from virval.usersys.redhat.com (unknown [10.43.2.227]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BDD31121319 for ; Wed, 27 Jul 2022 13:44:41 +0000 (UTC) Received: by virval.usersys.redhat.com (Postfix, from userid 500) id 33FC6240267; Wed, 27 Jul 2022 15:44:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658929490; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=OZ1SbyAubeo6J3hLFVhGKnPheo+NqHAidMoGk1rvP2w=; b=PyN7NBsX51oJcY13JvnnntU2MG47E+sP72p/ezz2m9kOTsChMGfQtbdQhWD6KHcqFfGSZZ jnR3lhtizhXx9V2GAFr+B7U5f7IgDIqnRFXSmAWg72/WRpOIUAK7ng5dRpg/e00kuS7ELA DRuPcb4fmnR8DBPdKXNvYMD7GhGwGvk= X-MC-Unique: lKgCz7jLOiKT6lnaO69ncQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Jiri Denemark To: libvir-list@redhat.com Subject: [libvirt PATCH for 8.6.0] qemu: Properly release job in qemuDomainSaveInternal Date: Wed, 27 Jul 2022 15:43:56 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1658929493767100001 Content-Type: text/plain; charset="utf-8" The function would fail to release the job in case qemuMigrationSrcIsAllowed failed. Fixes v8.5.0-157-g69e0e33873 Signed-off-by: Jiri Denemark Reviewed-by: Pavel Hrdina --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9013e6fb8d..019ec4a035 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2656,7 +2656,7 @@ qemuDomainSaveInternal(virQEMUDriver *driver, goto cleanup; =20 if (!qemuMigrationSrcIsAllowed(driver, vm, false, VIR_ASYNC_JOB_SAVE, = 0)) - goto cleanup; + goto endjob; =20 if (!virDomainObjIsActive(vm)) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", --=20 2.35.1