qemu_domainjob: remove dead code

[PATCH] qemu_domainjob: remove dead code

Kristina Hanicova posted 1 patch 2 years, 4 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/ac8f5d7697a4813fc834b5ded9d17f4ed7d6dcac.1638275572.git.khanicov@redhat.com

src/qemu/qemu_domainjob.c | 6 ------
src/qemu/qemu_domainjob.h | 2 --
2 files changed, 8 deletions(-)

Expand all Fold all

[PATCH] qemu_domainjob: remove dead code

Posted by Kristina Hanicova 2 years, 4 months ago

Function qemuDomainJobAllowed() is never used -> remove it.

Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
---
 src/qemu/qemu_domainjob.c | 6 ------
 src/qemu/qemu_domainjob.h | 2 --
 2 files changed, 8 deletions(-)

diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c
index cff8d7bb83..439a9d10c2 100644
--- a/src/qemu/qemu_domainjob.c
+++ b/src/qemu/qemu_domainjob.c
@@ -771,12 +771,6 @@ qemuDomainNestedJobAllowed(qemuDomainJobObj *jobs, qemuDomainJob newJob)
            (jobs->mask & JOB_MASK(newJob)) != 0;
 }
 
-bool
-qemuDomainJobAllowed(qemuDomainJobObj *jobs, qemuDomainJob newJob)
-{
-    return !jobs->active && qemuDomainNestedJobAllowed(jobs, newJob);
-}
-
 static bool
 qemuDomainObjCanSetJob(qemuDomainJobObj *job,
                        qemuDomainJob newJob,
diff --git a/src/qemu/qemu_domainjob.h b/src/qemu/qemu_domainjob.h
index 46cbb8a067..eaa5cda3eb 100644
--- a/src/qemu/qemu_domainjob.h
+++ b/src/qemu/qemu_domainjob.h
@@ -277,8 +277,6 @@ int
 qemuDomainObjInitJob(qemuDomainJobObj *job,
                      qemuDomainObjPrivateJobCallbacks *cb);
 
-bool qemuDomainJobAllowed(qemuDomainJobObj *jobs, qemuDomainJob newJob);
-
 int
 qemuDomainObjPrivateXMLFormatJob(virBuffer *buf,
                                  virDomainObj *vm);
-- 
2.31.1

Re: [PATCH] qemu_domainjob: remove dead code

Posted by Ján Tomko 2 years, 4 months ago

On a Tuesday in 2021, Kristina Hanicova wrote:
>Function qemuDomainJobAllowed() is never used -> remove it.
>

Unused as of commit 3f2fa8f3032779bf09590a4b24898636ee916876

>Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
>---
> src/qemu/qemu_domainjob.c | 6 ------
> src/qemu/qemu_domainjob.h | 2 --
> 2 files changed, 8 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano