From nobody Sat May 4 09:16:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1638275656; cv=none; d=zohomail.com; s=zohoarc; b=kOTvb6QAYj5uoft5fwHjV5yXWXsx9G6JAMpDIWGi8ZuXLWakX9mVlMhOKh1Tb1DLACs/LbHwPCVevjn8g2TabGZdXBwntdYbZ2aBasG/KZutXkRmUgZNODpwTvf7J5VO5xEdTsdCCA+GSTh8kq6i7htYXzpg5ABorWNn05/jOKU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1638275656; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=T4jn+xmSJTmO24S7pOEhdhGjS3tU4HottdCa+vcMBBU=; b=db2lSy14R6MZbT9EhOfGesNsnuIT4gX+RJTa9+29GP0hHhUHhdNg/Hpn5arMYV6sWeUyy6A1ACjYkrpZY76iQA7VJIiOx8pmf6YFoB6V96xs2p3X02xv/aBPPYVsoPKvcGMkoGmJyH3yk/uKpTKANAPJ1J0eY40720smccvnWAM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1638275656152610.659779949698; Tue, 30 Nov 2021 04:34:16 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-FP72Mvg8MQGYEsEmnumTWg-1; Tue, 30 Nov 2021 07:34:11 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1B9F6100B3B5; Tue, 30 Nov 2021 12:34:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6A13A5D6BA; Tue, 30 Nov 2021 12:34:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D4EBC1809C89; Tue, 30 Nov 2021 12:34:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AUCY0Ba011968 for ; Tue, 30 Nov 2021 07:34:00 -0500 Received: by smtp.corp.redhat.com (Postfix) id 46E1F60C4A; Tue, 30 Nov 2021 12:34:00 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.43.2.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id C3A2D60C13 for ; Tue, 30 Nov 2021 12:33:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638275655; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=T4jn+xmSJTmO24S7pOEhdhGjS3tU4HottdCa+vcMBBU=; b=L6mIymWEYplDD3s/PlsqrGoVRVlUCvoXHeeXifyHz2Cu0ZEGP7EDGkYJdSrIpcLQBC21Za ULekczLG1pYMfn0VzvGXLglAp/xc41QLTY3ekSdtaYQi7MPRtooMMGFtQFmrLK7d21wnMk McJDC81M+cv1OyYOa1AI8bhsxMQ5ICs= X-MC-Unique: FP72Mvg8MQGYEsEmnumTWg-1 From: Kristina Hanicova To: libvir-list@redhat.com Subject: [PATCH] qemu_domainjob: remove dead code Date: Tue, 30 Nov 2021 13:33:47 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1638275656947100001 Content-Type: text/plain; charset="utf-8" Function qemuDomainJobAllowed() is never used -> remove it. Signed-off-by: Kristina Hanicova Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_domainjob.c | 6 ------ src/qemu/qemu_domainjob.h | 2 -- 2 files changed, 8 deletions(-) diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c index cff8d7bb83..439a9d10c2 100644 --- a/src/qemu/qemu_domainjob.c +++ b/src/qemu/qemu_domainjob.c @@ -771,12 +771,6 @@ qemuDomainNestedJobAllowed(qemuDomainJobObj *jobs, qem= uDomainJob newJob) (jobs->mask & JOB_MASK(newJob)) !=3D 0; } =20 -bool -qemuDomainJobAllowed(qemuDomainJobObj *jobs, qemuDomainJob newJob) -{ - return !jobs->active && qemuDomainNestedJobAllowed(jobs, newJob); -} - static bool qemuDomainObjCanSetJob(qemuDomainJobObj *job, qemuDomainJob newJob, diff --git a/src/qemu/qemu_domainjob.h b/src/qemu/qemu_domainjob.h index 46cbb8a067..eaa5cda3eb 100644 --- a/src/qemu/qemu_domainjob.h +++ b/src/qemu/qemu_domainjob.h @@ -277,8 +277,6 @@ int qemuDomainObjInitJob(qemuDomainJobObj *job, qemuDomainObjPrivateJobCallbacks *cb); =20 -bool qemuDomainJobAllowed(qemuDomainJobObj *jobs, qemuDomainJob newJob); - int qemuDomainObjPrivateXMLFormatJob(virBuffer *buf, virDomainObj *vm); --=20 2.31.1