virhostdev: Don't unref @pcidevs twice

[libvirt] [PATCH] virhostdev: Don't unref @pcidevs twice

Michal Privoznik posted 1 patch 4 years, 7 months ago

Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/9b508acd2c2fd928da136f3188511980b5dd4ed7.1568039827.git.mprivozn@redhat.com

src/util/virhostdev.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] virhostdev: Don't unref @pcidevs twice

Posted by Michal Privoznik 4 years, 7 months ago

In f08e6883cb4 I've made @pcidevs in
virHostdevReAttachPCIDevices() to be automatically unrefed using
VIR_AUTOUNREF() but I forgot to remove the line that explicitly
unrefs the object at the end of the function.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

Pushed as trivial.

 src/util/virhostdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c
index d710193b94..41fcab7222 100644
--- a/src/util/virhostdev.c
+++ b/src/util/virhostdev.c
@@ -1091,7 +1091,6 @@ virHostdevReAttachPCIDevices(virHostdevManagerPtr mgr,
 
     virObjectUnlock(mgr->activePCIHostdevs);
     virObjectUnlock(mgr->inactivePCIHostdevs);
-    virObjectUnref(pcidevs);
 }
 
 int
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list