From nobody Fri Apr 26 04:12:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568039941; cv=none; d=zoho.com; s=zohoarc; b=Pk9DpLUZxktvWfjiwSfsm4X+Y52lRIJhqyuIwY7zkIb7k5NR5YbAzYzKdFyKMU/a5rngPKluE70ewi6R7J3je7zQbxC8FAnMFstCWlcrcSSPz3t3C9STy2Lswil5G9fLEiLyfYVmjS3kWECcZ4uEBAeUxokvOe3gKWj/Pn/GgZk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568039941; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=IBLHV6rP3187NmajdH9eX+X7iO4AuQI1v0jaVrAa7Bk=; b=Q489LA6k16B95So+L7HXx98tMrlky14wPfecvksPZKK8CPGxAeATat4orm7bStJT24YlB2HfJttm50L+gP38Vn9TBj7QIFsyEnKNzPasqllbvqcQamfkAQIdY6EQnZzFHwHmcx6HVIdnqQn4N4zAX2s6h6ldFjIKIL7hnOqdv+I= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1568039941508429.791872483421; Mon, 9 Sep 2019 07:39:01 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C10481DA6; Mon, 9 Sep 2019 14:38:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 730E55E1D8; Mon, 9 Sep 2019 14:38:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9F844180BA99; Mon, 9 Sep 2019 14:38:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x89EcuRZ021923 for ; Mon, 9 Sep 2019 10:38:56 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5D4E8A227; Mon, 9 Sep 2019 14:38:56 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id DB99C165D9 for ; Mon, 9 Sep 2019 14:38:46 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Mon, 9 Sep 2019 16:38:43 +0200 Message-Id: <9b508acd2c2fd928da136f3188511980b5dd4ed7.1568039827.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] virhostdev: Don't unref @pcidevs twice X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.71]); Mon, 09 Sep 2019 14:39:00 +0000 (UTC) Content-Type: text/plain; charset="utf-8" In f08e6883cb4 I've made @pcidevs in virHostdevReAttachPCIDevices() to be automatically unrefed using VIR_AUTOUNREF() but I forgot to remove the line that explicitly unrefs the object at the end of the function. Signed-off-by: Michal Privoznik --- Pushed as trivial. src/util/virhostdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index d710193b94..41fcab7222 100644 --- a/src/util/virhostdev.c +++ b/src/util/virhostdev.c @@ -1091,7 +1091,6 @@ virHostdevReAttachPCIDevices(virHostdevManagerPtr mgr, =20 virObjectUnlock(mgr->activePCIHostdevs); virObjectUnlock(mgr->inactivePCIHostdevs); - virObjectUnref(pcidevs); } =20 int --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list