m4: libxl: properly fail when libxl is required

[libvirt PATCH] m4: libxl: properly fail when libxl is required

Ján Tomko posted 1 patch 4 years, 2 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/9966a08349e45c0e8f41217be03f8b12aaca18d2.1582211109.git.jtomko@redhat.com

Test syntax-check failed

m4/virt-driver-libxl.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt PATCH] m4: libxl: properly fail when libxl is required

Posted by Ján Tomko 4 years, 2 months ago

We specify "true" as the fail-action for LIBVIRT_CHECK_PKG.

This was used when we had a fallback to non-pkg-config detection,
then removed in commit 5bdcef13d13560512c7d6d8c9e8822e456889e0c
later re-introduced in commit dc3d2c9f8c7678a950abedd227b1587ca62335c4
and then left in when removing the old detection again in
commit 18981877d2e20390a79d068861a24e716f8ee422

Remove it to properly error out when libxl was requested but not
detected.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Fixes: 18981877d2e20390a79d068861a24e716f8ee422
---
 m4/virt-driver-libxl.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/m4/virt-driver-libxl.m4 b/m4/virt-driver-libxl.m4
index 2f3565f1d5..a958cb26fa 100644
--- a/m4/virt-driver-libxl.m4
+++ b/m4/virt-driver-libxl.m4
@@ -30,7 +30,7 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_LIBXL], [
 
   dnl search for libxl, aka libxenlight
   old_with_libxl="$with_libxl"
-  LIBVIRT_CHECK_PKG([LIBXL], [xenlight], [4.6.0], [true])
+  LIBVIRT_CHECK_PKG([LIBXL], [xenlight], [4.6.0])
   if test "x$with_libxl" = "xyes" ; then
     LIBXL_FIRMWARE_DIR=$($PKG_CONFIG --variable xenfirmwaredir xenlight)
     LIBXL_EXECBIN_DIR=$($PKG_CONFIG --variable libexec_bin xenlight)
-- 
2.24.1

Re: [libvirt PATCH] m4: libxl: properly fail when libxl is required

Posted by Andrea Bolognani 4 years, 2 months ago

On Thu, 2020-02-20 at 16:05 +0100, Ján Tomko wrote:
> We specify "true" as the fail-action for LIBVIRT_CHECK_PKG.
> 
> This was used when we had a fallback to non-pkg-config detection,
> then removed in commit 5bdcef13d13560512c7d6d8c9e8822e456889e0c
> later re-introduced in commit dc3d2c9f8c7678a950abedd227b1587ca62335c4
> and then left in when removing the old detection again in
> commit 18981877d2e20390a79d068861a24e716f8ee422
> 
> Remove it to properly error out when libxl was requested but not
> detected.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> Fixes: 18981877d2e20390a79d068861a24e716f8ee422
> ---
>  m4/virt-driver-libxl.m4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization