From nobody Sat May 4 06:19:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582211139; cv=none; d=zohomail.com; s=zohoarc; b=RoFdusFPRfpUwLcOSoDFe8+Obrv4stAEgPLbtYQwCv77FDOdFurLDBha+yzECgkE7KFNp6NwoDUOEXfL+iFLc1adMUPR3wLr2fYRwQFOH7oFPUqA5gtn0E7kQd4kE55O8dyhWR6UdKZgUScpIVt3iUhCE8kirmsFw1xe+aLoRtE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582211139; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=cfRPLxR1Tup0/22Gbi1SFA6bMjI3F2qhwvgzGzefdwA=; b=FgpCTeOqEsyhxztJqUQIeCnFv8JYlPY7w77dfiYjCW0E956XeP8sHpByWwz+DfxnKq1xnX2vxPkxGYKASp2VgEOjs+mUuJ6WmweKenOhsT8qjYf0TffefYvFhwoY3H1/MxlcljhE0uZZnJ41Oemn9G/DwhhCZif8jbzwHDBx5B8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1582211139919794.1509863881921; Thu, 20 Feb 2020 07:05:39 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-iGjvIsrGP1Ofsk4fzNbpkg-1; Thu, 20 Feb 2020 10:05:32 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 78EC113E2; Thu, 20 Feb 2020 15:05:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 945A327060; Thu, 20 Feb 2020 15:05:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B00FB18089CD; Thu, 20 Feb 2020 15:05:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 01KF5Jsr025016 for ; Thu, 20 Feb 2020 10:05:19 -0500 Received: by smtp.corp.redhat.com (Postfix) id 176E5101D487; Thu, 20 Feb 2020 15:05:19 +0000 (UTC) Received: from icr.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8FCBB101D489 for ; Thu, 20 Feb 2020 15:05:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582211137; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=cfRPLxR1Tup0/22Gbi1SFA6bMjI3F2qhwvgzGzefdwA=; b=YVHAqutGo0vQ/RfbshITaDoKus5mW0Bc+23BgtCzN+MPlvY8NnSdlA6wikQrcwAdDmChat Op/46+7DjN4CDDI5HbupHjO3dVOew+k4ILd1fOzJ7y5IzhlhZw1Mvpe0CKp+3p7THTrzAc aGDgDNC+iZNQHoEOtCLl3StfJAn6kOk= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH] m4: libxl: properly fail when libxl is required Date: Thu, 20 Feb 2020 16:05:11 +0100 Message-Id: <9966a08349e45c0e8f41217be03f8b12aaca18d2.1582211109.git.jtomko@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: iGjvIsrGP1Ofsk4fzNbpkg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" We specify "true" as the fail-action for LIBVIRT_CHECK_PKG. This was used when we had a fallback to non-pkg-config detection, then removed in commit 5bdcef13d13560512c7d6d8c9e8822e456889e0c later re-introduced in commit dc3d2c9f8c7678a950abedd227b1587ca62335c4 and then left in when removing the old detection again in commit 18981877d2e20390a79d068861a24e716f8ee422 Remove it to properly error out when libxl was requested but not detected. Signed-off-by: J=C3=A1n Tomko Fixes: 18981877d2e20390a79d068861a24e716f8ee422 Reviewed-by: Andrea Bolognani --- m4/virt-driver-libxl.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-driver-libxl.m4 b/m4/virt-driver-libxl.m4 index 2f3565f1d5..a958cb26fa 100644 --- a/m4/virt-driver-libxl.m4 +++ b/m4/virt-driver-libxl.m4 @@ -30,7 +30,7 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_LIBXL], [ =20 dnl search for libxl, aka libxenlight old_with_libxl=3D"$with_libxl" - LIBVIRT_CHECK_PKG([LIBXL], [xenlight], [4.6.0], [true]) + LIBVIRT_CHECK_PKG([LIBXL], [xenlight], [4.6.0]) if test "x$with_libxl" =3D "xyes" ; then LIBXL_FIRMWARE_DIR=3D$($PKG_CONFIG --variable xenfirmwaredir xenlight) LIBXL_EXECBIN_DIR=3D$($PKG_CONFIG --variable libexec_bin xenlight) --=20 2.24.1