qemu: Get default hugepage size only if needed

[libvirt] [PATCH] qemu: Get default hugepage size only if needed

Michal Privoznik posted 1 patch 4 years, 11 months ago

Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/97aa1ae0d1273dfa5c9a8ac546e4118b21c0d0b0.1558948672.git.mprivozn@redhat.com

src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] qemu: Get default hugepage size only if needed

Posted by Michal Privoznik 4 years, 11 months ago

Fixes: 6864d8f740e2502dc7625bdf18ffde4465b14f69

Hugepages don't work in session mode but when building memory
part of command line we query for the default size anyway. This
breaks creating domains under session daemon. Query the page size
only if it's clear we need hugepages.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

As a penance, I'll backport this onto v5.3-main branch too.

 src/qemu/qemu_command.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 73f570c419..5bf6c704e0 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -3573,7 +3573,7 @@ qemuBuildMemoryBackendProps(virJSONValuePtr *backendProps,
         pagesize = 0;
         needHugepage = false;
         useHugepage = false;
-    } else if (pagesize == 0) {
+    } else if (useHugepage && pagesize == 0) {
         if (qemuBuildMemoryGetDefaultPagesize(cfg, &pagesize) < 0)
             goto cleanup;
     }
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: Get default hugepage size only if needed

Posted by Erik Skultety 4 years, 11 months ago

On Mon, May 27, 2019 at 11:18:51AM +0200, Michal Privoznik wrote:
> Fixes: 6864d8f740e2502dc7625bdf18ffde4465b14f69
>
> Hugepages don't work in session mode but when building memory
> part of command line we query for the default size anyway. This
> breaks creating domains under session daemon. Query the page size
> only if it's clear we need hugepages.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list