From nobody Sun May 19 02:26:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1558948982; cv=none; d=zoho.com; s=zohoarc; b=MBO4XU4zMXiKqeFTxzsaoXGKHjDpaI8ZCU5gsUxzES64I2XgPVH2trbeJFGMSOcfmbZtyucUbEYKqoWGiVdFdt/r8WObPRXfBeuZWlYk7nPjAlNTYF3lDBEbp7aXX6+hfhmCTzHHtOIVYuwbIx0M9tPw7p52SaEPdmTJock6yF8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558948982; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=x30mDvYY1J5Ss8M+5EDjeQqqxcyMGCQitniWHk19ccQ=; b=bq3tQ3YeWx5e8D5/s93lnpVMq2971N37If6p8v9bBKpHHnUXd4BWCKvw6hPzk51OETZDjENWXnyfsOVEHx/dkU1uPKnJz0KIyK4DOM5AgexjS1OmkxhXM2lbr/AKiCVAupVWt8ICi1+VFvvkP6/WGiOoMAZ0EV+/2kjEqa0W9QY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1558948982391997.2645715312129; Mon, 27 May 2019 02:23:02 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B619C307D855; Mon, 27 May 2019 09:22:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 39ED460606; Mon, 27 May 2019 09:22:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3AF01149E1; Mon, 27 May 2019 09:22:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x4R9ItIB030865 for ; Mon, 27 May 2019 05:18:55 -0400 Received: by smtp.corp.redhat.com (Postfix) id CFD2C60606; Mon, 27 May 2019 09:18:55 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5975D60BF3 for ; Mon, 27 May 2019 09:18:52 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Mon, 27 May 2019 11:18:51 +0200 Message-Id: <97aa1ae0d1273dfa5c9a8ac546e4118b21c0d0b0.1558948672.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] qemu: Get default hugepage size only if needed X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 27 May 2019 09:22:59 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Fixes: 6864d8f740e2502dc7625bdf18ffde4465b14f69 Hugepages don't work in session mode but when building memory part of command line we query for the default size anyway. This breaks creating domains under session daemon. Query the page size only if it's clear we need hugepages. Signed-off-by: Michal Privoznik Reviewed-by: Erik Skultety --- As a penance, I'll backport this onto v5.3-main branch too. src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 73f570c419..5bf6c704e0 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3573,7 +3573,7 @@ qemuBuildMemoryBackendProps(virJSONValuePtr *backendP= rops, pagesize =3D 0; needHugepage =3D false; useHugepage =3D false; - } else if (pagesize =3D=3D 0) { + } else if (useHugepage && pagesize =3D=3D 0) { if (qemuBuildMemoryGetDefaultPagesize(cfg, &pagesize) < 0) goto cleanup; } --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list