From: Martin Kletzander <mkletzan@redhat.com>

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
So it turned out there were more places, but some even in code that was
compiling on my machine and in the CI, but was not found.  Not sure why, but I
went through all the places again from scratch, hopefully this time that's all.

Pushed.

 src/bhyve/bhyve_domain.c | 1 +
 src/qemu/qemu_validate.c | 1 +
 src/vz/vz_sdk.c          | 2 ++
 src/vz/vz_utils.c        | 1 +
 4 files changed, 5 insertions(+)

diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhyve_domain.c
index 3e18a462e460..c9bbf27d83ca 100644
--- a/src/bhyve/bhyve_domain.c
+++ b/src/bhyve/bhyve_domain.c
@@ -143,6 +143,7 @@ bhyveDomainDiskDefAssignAddress(struct _bhyveConn *driver,
     case VIR_DOMAIN_DISK_BUS_USB:
     case VIR_DOMAIN_DISK_BUS_UML:
     case VIR_DOMAIN_DISK_BUS_SD:
+    case VIR_DOMAIN_DISK_BUS_NVME:
     case VIR_DOMAIN_DISK_BUS_LAST:
     default:
         break;
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 5eaaca87fed6..b2faf4300204 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu/qemu_validate.c
@@ -1556,6 +1556,7 @@ qemuValidateDomainDeviceDefAddressDrive(virDomainDeviceInfo *info,
     case VIR_DOMAIN_DISK_BUS_SD:
     case VIR_DOMAIN_DISK_BUS_NONE:
     case VIR_DOMAIN_DISK_BUS_UML:
+    case VIR_DOMAIN_DISK_BUS_NVME:
     case VIR_DOMAIN_DISK_BUS_LAST:
         break;
     }
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index 684b76ffa057..160778146dcd 100644
--- a/src/vz/vz_sdk.c
+++ b/src/vz/vz_sdk.c
@@ -3380,6 +3380,7 @@ static int prlsdkConfigureDisk(struct _vzDriver *driver,
     case VIR_DOMAIN_DISK_BUS_USB:
     case VIR_DOMAIN_DISK_BUS_UML:
     case VIR_DOMAIN_DISK_BUS_SD:
+    case VIR_DOMAIN_DISK_BUS_NVME:
     case VIR_DOMAIN_DISK_BUS_LAST:
     default:
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
@@ -4339,6 +4340,7 @@ prlsdkGetBlockStats(PRL_HANDLE sdkstats,
         case VIR_DOMAIN_DISK_BUS_USB:
         case VIR_DOMAIN_DISK_BUS_UML:
         case VIR_DOMAIN_DISK_BUS_SD:
+        case VIR_DOMAIN_DISK_BUS_NVME:
         case VIR_DOMAIN_DISK_BUS_LAST:
         default:
             virReportError(VIR_ERR_INTERNAL_ERROR,
diff --git a/src/vz/vz_utils.c b/src/vz/vz_utils.c
index 7c08d0f88b58..976303479bb6 100644
--- a/src/vz/vz_utils.c
+++ b/src/vz/vz_utils.c
@@ -242,6 +242,7 @@ vzCheckDiskAddressDriveUnsupportedParams(virDomainDiskDef *disk)
     case VIR_DOMAIN_DISK_BUS_USB:
     case VIR_DOMAIN_DISK_BUS_UML:
     case VIR_DOMAIN_DISK_BUS_SD:
+    case VIR_DOMAIN_DISK_BUS_NVME:
     case VIR_DOMAIN_DISK_BUS_LAST:
     default:
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-- 
2.49.0

On a Monday in 2025, Martin Kletzander via Devel wrote:
>From: Martin Kletzander <mkletzan@redhat.com>
>
>Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
>---
>So it turned out there were more places, but some even in code that was
>compiling on my machine and in the CI, but was not found.  Not sure why, but I
>went through all the places again from scratch, hopefully this time that's all.
>

The 'vz' driver requires some 'parallels-sdk' package which is not
freely available if I recall correctly, so our CI coverage is lacking.

Jano

>Pushed.
>
> src/bhyve/bhyve_domain.c | 1 +
> src/qemu/qemu_validate.c | 1 +
> src/vz/vz_sdk.c          | 2 ++
> src/vz/vz_utils.c        | 1 +
> 4 files changed, 5 insertions(+)
>