From nobody Mon Sep 8 21:35:45 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1749477735; cv=none; d=zohomail.com; s=zohoarc; b=axaubPpd4s/0iMyRqyXQQEY6pBoAvKe/P9+ZrreNgmZs0N+BFa7/G+hzQ2iE7ttvJ0qWB08K64C8P1D3H9fGvHtK8H9G3Pr4TlWNxKS3cqR5wmdidnsjU8XXRd6qNBu0NEJjapvEWhER/lMT5Ns3aNhAuG5bh/KgUHxB3zT1iBs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749477735; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=3uif7gjGY27k6hTBIkLF7RZlicla8EFJHlZg0+OtVpo=; b=dqLPYtvN8TVWfnDKXz0+hf8zj+5gnbZ0sylTShjEDO+3l0dYHrwvXRR4+X7oQ+iEemAMlnCjBkq2EJCcWU9xXtIHioZTQChTmOZO2+47EOCxPlsscKmzA4ZNPIaaI2n3FRz34RR0eRtqVak8P5BZastfu8vjbBADoJrwMYycB+E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1749477735483350.4088832364074; Mon, 9 Jun 2025 07:02:15 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 7E798E91; Mon, 9 Jun 2025 10:02:14 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 90DCFC17; Mon, 9 Jun 2025 10:01:55 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id AD973BB2; Mon, 9 Jun 2025 10:01:52 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 63177B7F for ; Mon, 9 Jun 2025 10:01:51 -0400 (EDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-mk0Vp0y6P56UDAiJZNDBcw-1; Mon, 09 Jun 2025 10:01:49 -0400 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4f65a705dso2490246f8f.2 for ; Mon, 09 Jun 2025 07:01:48 -0700 (PDT) Received: from wheatley.localdomain ([85.93.96.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53229de53sm9584365f8f.8.2025.06.09.07.01.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 07:01:46 -0700 (PDT) Received: from wheatley.brq.redhat.com (wheatley.k8r.cz [127.0.0.1]) by wheatley.localdomain (Postfix) with ESMTP id C4374B63E439 for ; Mon, 09 Jun 2025 16:01:45 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749477711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MXx4EgveS4buiQTezEogjgaU3FS3Jnb5Qhz0+I21234=; b=UjlvWSObANw9COzxWmYhmsMUpN/cJFOAjTA/tn3kZIyw5PqIAOeuvaH/nEkafJvttaTMRd CxMvFaGnpJ+6cO56HsLzxpuX8m5sh9cAXcwUqI+sit4kyH62y25xYIi5AERxVeKnN5xrIF G0to2qgAXaNTpwDpMXY7k4QNG1Y1d6Q= X-MC-Unique: mk0Vp0y6P56UDAiJZNDBcw-1 X-Mimecast-MFC-AGG-ID: mk0Vp0y6P56UDAiJZNDBcw_1749477708 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749477707; x=1750082507; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MXx4EgveS4buiQTezEogjgaU3FS3Jnb5Qhz0+I21234=; b=Gizy+JrvNl5lJIB87uTW8AmY9dFM6DcHEZ2k4EKdPcH5uvC1PECB0DTZFI/bnfKMTV i5QmfOmBUtoG03zRt7z99LEDuGBVXZJj6ZQ43ZOJicJx5rkuoUIDqQDjDrbO2MfDA8G1 JawJxC/yEWh80YzTMSojeKd60af92L7csN5xQSP4d+tFE5fAVClRyJaGZP8Ru09Dx9r7 msxadwneJoMWLHco7Y6Gx7zmOCVGeb3sX6kNa8ZSgBIzfluwfOvHGANZAA/pUi6WPACm El52oV5Txpnj4Bt43Oh7Ri06iwk3syeRKqLw6PqTwE5dRFEta+HcZOYmoITJsjTVUSjg q6Bw== X-Gm-Message-State: AOJu0YyibzlYZbgz4yIJlueF3o/EcjqQcevcF9VBJ6sgc6uXOoitC9zw Qp4pbQwZd45t2lQWvCkabdKNi8I/PckZLD/8upR26Xdp3IbsrevMR3HyphbflIAC7uzzhEsEMpw bjFL+7pSihdMrupp8nYlowmkChFUUIELiXzWF/xQsTCF0+wyjc4hrtU+5Zp2vsnwVwOIsOu+pRj eqOTiwkLYs5zQcag57fFQusL2ekCXP6y3j1Mz9gqGzBTo= X-Gm-Gg: ASbGncvwM/C0i2LwunxPCtoJ9LvjqCiaZkinWi/AH1jBFsDz+STeI9F84UeMKbPWlGw Ugqp7MkteRD+12d/aRDS6Esn38swkeeg/RLYXmZ5m9GURCihQ2IONFl2xQsVzYn2vqfwzGuDKD2 vm5F7ucv/yxY1czGxp3NxRkuMQd+BTaPz3j6Ng9hFyFLZziOXdQUThucfmw3iCKLnVrbX7oYHa/ 2+wH1y+iogAkrPt6ORRPQjEKse8am/mP3eDw83zk7t8HirVJLbDVbhHEjus/+BBXz8f+TxHnvCA 0m/1B0TTHhUScZ8oX3dW X-Received: by 2002:a05:6000:144e:b0:3a4:d79a:35a6 with SMTP id ffacd0b85a97d-3a531ab5032mr11004369f8f.14.1749477707441; Mon, 09 Jun 2025 07:01:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnKWTLVueTUFh538oa25gtk/aRe56qdZJ/WQyji4O64DCoWY+K5R7xrOk+0PGnWsS6KIS+Jg== X-Received: by 2002:a05:6000:144e:b0:3a4:d79a:35a6 with SMTP id ffacd0b85a97d-3a531ab5032mr11004284f8f.14.1749477706465; Mon, 09 Jun 2025 07:01:46 -0700 (PDT) To: devel@lists.libvirt.org Subject: [PATCH] nvme: Fix more missing enum switches for VIR_DOMAIN_DISK_BUS_NVME Date: Mon, 9 Jun 2025 16:00:09 +0200 Message-ID: <6ca627d38b47ef97283996e46b0649420d142f5c.1749477609.git.mkletzan@redhat.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8MV0KYMLnUp1x1k_b-ODJYuZh4Fqnn5kQ1_9N4dulpQ_1749477708 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FYITLAFQJBSXXDJKXE35L3VYMTLSMSR5 X-Message-ID-Hash: FYITLAFQJBSXXDJKXE35L3VYMTLSMSR5 X-MailFrom: mkletzan@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Martin Kletzander via Devel Reply-To: Martin Kletzander X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749477748858116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Martin Kletzander Signed-off-by: Martin Kletzander --- So it turned out there were more places, but some even in code that was compiling on my machine and in the CI, but was not found. Not sure why, bu= t I went through all the places again from scratch, hopefully this time that's = all. Pushed. src/bhyve/bhyve_domain.c | 1 + src/qemu/qemu_validate.c | 1 + src/vz/vz_sdk.c | 2 ++ src/vz/vz_utils.c | 1 + 4 files changed, 5 insertions(+) diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhyve_domain.c index 3e18a462e460..c9bbf27d83ca 100644 --- a/src/bhyve/bhyve_domain.c +++ b/src/bhyve/bhyve_domain.c @@ -143,6 +143,7 @@ bhyveDomainDiskDefAssignAddress(struct _bhyveConn *driv= er, case VIR_DOMAIN_DISK_BUS_USB: case VIR_DOMAIN_DISK_BUS_UML: case VIR_DOMAIN_DISK_BUS_SD: + case VIR_DOMAIN_DISK_BUS_NVME: case VIR_DOMAIN_DISK_BUS_LAST: default: break; diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 5eaaca87fed6..b2faf4300204 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -1556,6 +1556,7 @@ qemuValidateDomainDeviceDefAddressDrive(virDomainDevi= ceInfo *info, case VIR_DOMAIN_DISK_BUS_SD: case VIR_DOMAIN_DISK_BUS_NONE: case VIR_DOMAIN_DISK_BUS_UML: + case VIR_DOMAIN_DISK_BUS_NVME: case VIR_DOMAIN_DISK_BUS_LAST: break; } diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index 684b76ffa057..160778146dcd 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -3380,6 +3380,7 @@ static int prlsdkConfigureDisk(struct _vzDriver *driv= er, case VIR_DOMAIN_DISK_BUS_USB: case VIR_DOMAIN_DISK_BUS_UML: case VIR_DOMAIN_DISK_BUS_SD: + case VIR_DOMAIN_DISK_BUS_NVME: case VIR_DOMAIN_DISK_BUS_LAST: default: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", @@ -4339,6 +4340,7 @@ prlsdkGetBlockStats(PRL_HANDLE sdkstats, case VIR_DOMAIN_DISK_BUS_USB: case VIR_DOMAIN_DISK_BUS_UML: case VIR_DOMAIN_DISK_BUS_SD: + case VIR_DOMAIN_DISK_BUS_NVME: case VIR_DOMAIN_DISK_BUS_LAST: default: virReportError(VIR_ERR_INTERNAL_ERROR, diff --git a/src/vz/vz_utils.c b/src/vz/vz_utils.c index 7c08d0f88b58..976303479bb6 100644 --- a/src/vz/vz_utils.c +++ b/src/vz/vz_utils.c @@ -242,6 +242,7 @@ vzCheckDiskAddressDriveUnsupportedParams(virDomainDiskD= ef *disk) case VIR_DOMAIN_DISK_BUS_USB: case VIR_DOMAIN_DISK_BUS_UML: case VIR_DOMAIN_DISK_BUS_SD: + case VIR_DOMAIN_DISK_BUS_NVME: case VIR_DOMAIN_DISK_BUS_LAST: default: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", --=20 2.49.0