[PATCH] Enable VMware driver by default

Michal Privoznik posted 1 patch 3 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/577bf5cbbce5e2c9434773cbaec0f45c5e11b625.1609840262.git.mprivozn@redhat.com
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] Enable VMware driver by default
Posted by Michal Privoznik 3 years, 3 months ago
During rewrite to meson it was mistakenly disabled. Originally,
we had:

  LIBVIRT_ARG_WITH_FEATURE([VMWARE], [VMware], [yes])

which enabled the driver by default. But in meson we are checking
whether the 'driver_vmware' option is enabled without anything
enabling it automagically.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 3f3412975b..b5164f68ed 100644
--- a/meson.build
+++ b/meson.build
@@ -1790,7 +1790,7 @@ if not get_option('driver_vbox').disabled() and conf.has('WITH_LIBVIRTD')
   conf.set_quoted('VBOX_XPCOMC_DIR', get_option('vbox_xpcomc_dir'))
 endif
 
-if get_option('driver_vmware').enabled()
+if not get_option('driver_vmware').disabled()
   conf.set('WITH_VMWARE', 1)
   conf.set('WITH_VMX', 1)
 endif
-- 
2.26.2

Re: [PATCH] Enable VMware driver by default
Posted by Daniel P. Berrangé 3 years, 3 months ago
On Tue, Jan 05, 2021 at 10:51:02AM +0100, Michal Privoznik wrote:
> During rewrite to meson it was mistakenly disabled. Originally,
> we had:
> 
>   LIBVIRT_ARG_WITH_FEATURE([VMWARE], [VMware], [yes])
> 
> which enabled the driver by default. But in meson we are checking
> whether the 'driver_vmware' option is enabled without anything
> enabling it automagically.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|