From nobody Tue May 14 08:01:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1609840287; cv=none; d=zohomail.com; s=zohoarc; b=QRz2h9+kK5utsWzv3uHTYsDiz8WXf2OPGWIEKhxobIeZVA5SQrVUrmB9WMtIkOBZBBtx5Y3LnucartVJjUbfg9mMf20SCaQUkjXkqr4wiNEjR56hOO3tttKzdehADDlTo5/V68cYbj5wMYu0SL+i0eWzJo8Q0mq613kQahQuWDQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609840287; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=5bfwELlTEyoQp+d8hKGfzYvE1CYG3pGE7aN+ZzRzrkg=; b=fGI9TH6/GOIsAVDepmkUrYsZzzFJpKFd5JMvOC9s1OSHQbyOK3cFd9+0uC3ggiUVeGCN92ej+xGLJ1kcKTRAW/rrj1QkiOCkc9WzTtb8Nku/twjtOhNOfbU2v3KHWdjed4DniWQsD+rU2xSy4A47oKj70uiDcM/n3z1EPewVEPQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 160984028773692.1836962078421; Tue, 5 Jan 2021 01:51:27 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-525-MsNASA9HMfe0cLpkiKqopg-1; Tue, 05 Jan 2021 04:51:24 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A6EB5800050; Tue, 5 Jan 2021 09:51:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 79DE9722C1; Tue, 5 Jan 2021 09:51:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B9F0C180954D; Tue, 5 Jan 2021 09:51:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1059pHwt013741 for ; Tue, 5 Jan 2021 04:51:17 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4C7C61002382; Tue, 5 Jan 2021 09:51:17 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id C217F10021B3 for ; Tue, 5 Jan 2021 09:51:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609840286; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=5bfwELlTEyoQp+d8hKGfzYvE1CYG3pGE7aN+ZzRzrkg=; b=S7bnZMMVHZlG5qK59qYTcvJbWDBIL3L7Q+izxFDIduedXKrnVX3cTSVi3J7XiHFH6D/gBi hElN3E2HV/tKLtn3Gc6S9tRJkQ9RhYU3x1sxdFlHNc1J5y9Ad11Tw3tLhDlpBlo2rOm2PO k31+GId4D0YKkjWnFbq3Z3I+/qFzaSI= X-MC-Unique: MsNASA9HMfe0cLpkiKqopg-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] Enable VMware driver by default Date: Tue, 5 Jan 2021 10:51:02 +0100 Message-Id: <577bf5cbbce5e2c9434773cbaec0f45c5e11b625.1609840262.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" During rewrite to meson it was mistakenly disabled. Originally, we had: LIBVIRT_ARG_WITH_FEATURE([VMWARE], [VMware], [yes]) which enabled the driver by default. But in meson we are checking whether the 'driver_vmware' option is enabled without anything enabling it automagically. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 3f3412975b..b5164f68ed 100644 --- a/meson.build +++ b/meson.build @@ -1790,7 +1790,7 @@ if not get_option('driver_vbox').disabled() and conf.= has('WITH_LIBVIRTD') conf.set_quoted('VBOX_XPCOMC_DIR', get_option('vbox_xpcomc_dir')) endif =20 -if get_option('driver_vmware').enabled() +if not get_option('driver_vmware').disabled() conf.set('WITH_VMWARE', 1) conf.set('WITH_VMX', 1) endif --=20 2.26.2