qemu_process: fix crash in qemuSaveImageDecompressionStart

[libvirt PATCH] qemu_process: fix crash in qemuSaveImageDecompressionStart

Posted by Pavel Hrdina 5 months, 3 weeks ago

Commit changing the code to allow passing NULL as @data into
qemuSaveImageDecompressionStart() was not correct as it left the
original call into the function as well.

Introduced-by: 2f3e582a1ac1008eba8d43c751cdba8712dd1614
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2247754
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 src/qemu/qemu_process.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 1ef032dbd2..b9267d8699 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -8208,9 +8208,6 @@ qemuProcessStartWithMemoryState(virConnectPtr conn,
         }
     }
 
-    if (qemuSaveImageDecompressionStart(data, fd, &intermediatefd, &errbuf, &cmd) < 0)
-        return -1;
-
     /* No cookie means libvirt which saved the domain was too old to mess up
      * the CPU definitions.
      */
-- 
2.41.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

Re: [libvirt PATCH] qemu_process: fix crash in qemuSaveImageDecompressionStart

Posted by Ján Tomko 5 months, 3 weeks ago

On a Friday in 2023, Pavel Hrdina wrote:
>Commit changing the code to allow passing NULL as @data into
>qemuSaveImageDecompressionStart() was not correct as it left the
>original call into the function as well.
>
>Introduced-by: 2f3e582a1ac1008eba8d43c751cdba8712dd1614
>Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2247754
>Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
>---
> src/qemu/qemu_process.c | 3 ---
> 1 file changed, 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org