From nobody Mon May 13 17:09:26 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1699017115152551.360121101408; Fri, 3 Nov 2023 06:11:55 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id EB18A1899; Fri, 3 Nov 2023 09:11:53 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id D6AFF1868; Fri, 3 Nov 2023 09:10:48 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9E9CA1864; Fri, 3 Nov 2023 09:10:45 -0400 (EDT) Received: from mx1.osci.io (polly.osci.io [8.43.85.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 11E7C1785 for ; Fri, 3 Nov 2023 09:10:45 -0400 (EDT) Received: by mx1.osci.io (Postfix, from userid 994) id CEACF21DD2; Fri, 3 Nov 2023 09:10:44 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by mx1.osci.io (Postfix) with ESMTPS id 62CF421DCF for ; Fri, 3 Nov 2023 09:10:44 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-91-CkqJIfu9OkKFfagmVvs15Q-1; Fri, 03 Nov 2023 09:10:41 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8751F299E751 for ; Fri, 3 Nov 2023 13:10:41 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.45.224.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id 295C0492BE0 for ; Fri, 3 Nov 2023 13:10:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: CkqJIfu9OkKFfagmVvs15Q-1 From: Pavel Hrdina To: devel@lists.libvirt.org Subject: [libvirt PATCH] qemu_process: fix crash in qemuSaveImageDecompressionStart Date: Fri, 3 Nov 2023 14:10:40 +0100 Message-ID: <206221b87a0f1415265faf3b96f2d92eb0529220.1699016862.git.phrdina@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: TZN6TRBXGIVP4SA2A5EOB3F2P6RHXQH4 X-Message-ID-Hash: TZN6TRBXGIVP4SA2A5EOB3F2P6RHXQH4 X-MailFrom: SRS0=kN1b=GQ=redhat.com=phrdina@osci.io X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1699017116829100001 Commit changing the code to allow passing NULL as @data into qemuSaveImageDecompressionStart() was not correct as it left the original call into the function as well. Introduced-by: 2f3e582a1ac1008eba8d43c751cdba8712dd1614 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=3D2247754 Signed-off-by: Pavel Hrdina Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_process.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 1ef032dbd2..b9267d8699 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8208,9 +8208,6 @@ qemuProcessStartWithMemoryState(virConnectPtr conn, } } =20 - if (qemuSaveImageDecompressionStart(data, fd, &intermediatefd, &errbuf= , &cmd) < 0) - return -1; - /* No cookie means libvirt which saved the domain was too old to mess = up * the CPU definitions. */ --=20 2.41.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org