[PATCH v3 0/8] Testcase improvements and Power8E/NVL removal

Aditya Gupta posted 8 patches 2 weeks, 1 day ago
Failed in applying to current master (apply log)
There is a newer version of this series
MAINTAINERS                            |  2 +-
docs/about/deprecated.rst              |  9 ---
docs/about/removed-features.rst        |  8 +++
docs/system/ppc/powernv.rst            |  2 +-
docs/system/ppc/pseries.rst            |  2 +-
hw/ppc/pnv.c                           | 62 -----------------
hw/ppc/pnv_core.c                      |  2 -
hw/ppc/spapr_cpu_core.c                |  2 -
include/hw/ppc/pnv.h                   |  8 ---
target/ppc/cpu-models.c                |  6 --
target/ppc/cpu-models.h                |  4 --
target/ppc/cpu_init.c                  |  6 --
target/ppc/kvm.c                       |  4 +-
tests/functional/ppc64/test_fadump.py  |  2 +-
tests/functional/ppc64/test_powernv.py | 95 ++++++++++++++++++++++++++
tests/qtest/machine-none-test.c        |  2 +-
tests/qtest/pnv-host-i2c-test.c        | 10 ++-
tests/qtest/pnv-spi-seeprom-test.c     | 20 ++++--
tests/qtest/pnv-xive2-test.c           |  2 +-
tests/qtest/pnv-xscom-test.c           | 22 ++----
tests/qtest/pnv-xscom.h                | 41 +++++++----
21 files changed, 162 insertions(+), 149 deletions(-)
[PATCH v3 0/8] Testcase improvements and Power8E/NVL removal
Posted by Aditya Gupta 2 weeks, 1 day ago
Overview
========

This patch series merged two patch series sent earlier:
	"Testcase improvements for PowerNV"
	"Remove deprecated Power8E and 8NVL CPUs"
since the Power8E removal series depended on the former due to pnv-spi test

Broadly contains 3 changes:
1. Testcase improvements:
    Add a testcase to detect regression in remote interrupts when XIVE changes,
    since such regression had occurred during Power11 XIVE changes:
    https://lore.kernel.org/qemu-devel/baf6c854-832b-4a2e-922f-d34e6dadf821@redhat.com/

    Also add Power11 chip and testcase in qtests, and fadump functional test

2. Power8E/Power8NVL removal
    Power8E and Power8NVL were deprecated since QEMU 10.1, with
    commit 264a604e7163 ("target/ppc: Deprecate Power8E and Power8NVL")
    
    Hence, remove usage (chip and core types) of Power8E and 8NVL from PowerNV,
    PSeries as well as testcases.

3. Maintainer changes
    Add myself as maintainer for PowerNV machine

Testing
=======

* Git tree for testing: https://gitlab.com/adi-g15-ibm/qemu/tree/feat_maintainer-v3
* Gitlab pipeline: https://gitlab.com/adi-g15-ibm/qemu/-/pipelines/2635562383
* Successful ppc64 functional tests, qtests, boot tests, builds at all commits

Changelog
=========
v3:
+ #3: use machine_type array in pnv_xscom_addr, as suggested by shivang, harsh and balaton 

v2:
+ #1: put e1000e on socket 1, and disable it's cpu, as suggested by cedric
+ #1: pull out command fail checks into a helper, as suggested by shivang
+ #2: use g_autofree, suggested by cedric
+ #3: use g_autofree in tests updated
+ #8: remove G:, as suggested by daniel
+ rebased to upstream

from previous split series:
+ #1: added checks to see if network is up and interrupts happened, based on shivang's review
+ #3: replaced common if-else-if check for machine type with pnv_get_machine_type
+ #7: added doc in removed-features, as suggested by cedric
+ #6,7: added rb from philippe
+ #8: new patch, maintainer change

Aditya Gupta (8):
  tests/functional: Add remote interrupts test for PowerNV
  tests/qtest/pnv_spi: Test Power11 PNV_SPI
  tests/qtest: Add Power11 chip & machine to qtests
  tests/functional: Use default powernv machine instead of power10
  ppc/pnv: Replace Power8E with Power11 for 'none' machine test
  ppc/pnv: Remove Power8E and Power8NVL pnv chips
  ppc/pnv: Remove Power8E and Power8NVL CPUs
  MAINTAINERS: Add self as maintainer for PowerNV

 MAINTAINERS                            |  2 +-
 docs/about/deprecated.rst              |  9 ---
 docs/about/removed-features.rst        |  8 +++
 docs/system/ppc/powernv.rst            |  2 +-
 docs/system/ppc/pseries.rst            |  2 +-
 hw/ppc/pnv.c                           | 62 -----------------
 hw/ppc/pnv_core.c                      |  2 -
 hw/ppc/spapr_cpu_core.c                |  2 -
 include/hw/ppc/pnv.h                   |  8 ---
 target/ppc/cpu-models.c                |  6 --
 target/ppc/cpu-models.h                |  4 --
 target/ppc/cpu_init.c                  |  6 --
 target/ppc/kvm.c                       |  4 +-
 tests/functional/ppc64/test_fadump.py  |  2 +-
 tests/functional/ppc64/test_powernv.py | 95 ++++++++++++++++++++++++++
 tests/qtest/machine-none-test.c        |  2 +-
 tests/qtest/pnv-host-i2c-test.c        | 10 ++-
 tests/qtest/pnv-spi-seeprom-test.c     | 20 ++++--
 tests/qtest/pnv-xive2-test.c           |  2 +-
 tests/qtest/pnv-xscom-test.c           | 22 ++----
 tests/qtest/pnv-xscom.h                | 41 +++++++----
 21 files changed, 162 insertions(+), 149 deletions(-)


base-commit: 20553466cc47af6a8c95f665b601fce3c852e503
-- 
2.54.0
Re: [PATCH v3 0/8] Testcase improvements and Power8E/NVL removal
Posted by Misbah Anjum N 2 weeks ago
On 2026-06-29 16:34, Aditya Gupta wrote:
> Overview
> ========
> 
> This patch series merged two patch series sent earlier:
> 	"Testcase improvements for PowerNV"
> 	"Remove deprecated Power8E and 8NVL CPUs"
> since the Power8E removal series depended on the former due to pnv-spi 
> test
> 
> Broadly contains 3 changes:
> 1. Testcase improvements:
>     Add a testcase to detect regression in remote interrupts when XIVE 
> changes,
>     since such regression had occurred during Power11 XIVE changes:
> 
> https://lore.kernel.org/qemu-devel/baf6c854-832b-4a2e-922f-d34e6dadf821@redhat.com/
> 
>     Also add Power11 chip and testcase in qtests, and fadump functional 
> test
> 
> 2. Power8E/Power8NVL removal
>     Power8E and Power8NVL were deprecated since QEMU 10.1, with
>     commit 264a604e7163 ("target/ppc: Deprecate Power8E and Power8NVL")
> 
>     Hence, remove usage (chip and core types) of Power8E and 8NVL from 
> PowerNV,
>     PSeries as well as testcases.
> 
> 3. Maintainer changes
>     Add myself as maintainer for PowerNV machine
> 
> Testing
> =======
> 
> * Git tree for testing:
> https://gitlab.com/adi-g15-ibm/qemu/tree/feat_maintainer-v3
> * Gitlab pipeline: 
> https://gitlab.com/adi-g15-ibm/qemu/-/pipelines/2635562383
> * Successful ppc64 functional tests, qtests, boot tests, builds at all 
> commits
> 
> Changelog
> =========
> v3:
> + #3: use machine_type array in pnv_xscom_addr, as suggested by
> shivang, harsh and balaton
> 
> v2:
> + #1: put e1000e on socket 1, and disable it's cpu, as suggested by 
> cedric
> + #1: pull out command fail checks into a helper, as suggested by 
> shivang
> + #2: use g_autofree, suggested by cedric
> + #3: use g_autofree in tests updated
> + #8: remove G:, as suggested by daniel
> + rebased to upstream
> 
> from previous split series:
> + #1: added checks to see if network is up and interrupts happened,
> based on shivang's review
> + #3: replaced common if-else-if check for machine type with
> pnv_get_machine_type
> + #7: added doc in removed-features, as suggested by cedric
> + #6,7: added rb from philippe
> + #8: new patch, maintainer change
> 
> Aditya Gupta (8):
>   tests/functional: Add remote interrupts test for PowerNV
>   tests/qtest/pnv_spi: Test Power11 PNV_SPI
>   tests/qtest: Add Power11 chip & machine to qtests
>   tests/functional: Use default powernv machine instead of power10
>   ppc/pnv: Replace Power8E with Power11 for 'none' machine test
>   ppc/pnv: Remove Power8E and Power8NVL pnv chips
>   ppc/pnv: Remove Power8E and Power8NVL CPUs
>   MAINTAINERS: Add self as maintainer for PowerNV
> 
>  MAINTAINERS                            |  2 +-
>  docs/about/deprecated.rst              |  9 ---
>  docs/about/removed-features.rst        |  8 +++
>  docs/system/ppc/powernv.rst            |  2 +-
>  docs/system/ppc/pseries.rst            |  2 +-
>  hw/ppc/pnv.c                           | 62 -----------------
>  hw/ppc/pnv_core.c                      |  2 -
>  hw/ppc/spapr_cpu_core.c                |  2 -
>  include/hw/ppc/pnv.h                   |  8 ---
>  target/ppc/cpu-models.c                |  6 --
>  target/ppc/cpu-models.h                |  4 --
>  target/ppc/cpu_init.c                  |  6 --
>  target/ppc/kvm.c                       |  4 +-
>  tests/functional/ppc64/test_fadump.py  |  2 +-
>  tests/functional/ppc64/test_powernv.py | 95 ++++++++++++++++++++++++++
>  tests/qtest/machine-none-test.c        |  2 +-
>  tests/qtest/pnv-host-i2c-test.c        | 10 ++-
>  tests/qtest/pnv-spi-seeprom-test.c     | 20 ++++--
>  tests/qtest/pnv-xive2-test.c           |  2 +-
>  tests/qtest/pnv-xscom-test.c           | 22 ++----
>  tests/qtest/pnv-xscom.h                | 41 +++++++----
>  21 files changed, 162 insertions(+), 149 deletions(-)
> 
> 
> base-commit: 20553466cc47af6a8c95f665b601fce3c852e503

Hi Aditya,

I've tested the v3 patch series on PowerNV and pSeries guests including 
the new remote interrupts functional test and Power8E/NVL removal.

Testing Environment:
- Host: Fedora 42 ppc64le
- Arch: ppc64le
- QEMU: emulator version 11.0.50 (v11.0.0-2400-g20553466cc-dirty)

PowerNV Guest Bringup
Status: Success
qemu-system-ppc64 -name test-vm -machine powernv -m 4096 -smp 4 
-nographic -kernel 
~/.cache/qemu/download/6fd29aff9ad4362511ea5d0acbb510667c7031928e97d64ec15bbc5daf4b8151 
-drive 
file=~/.cache/qemu/download/aee2192b692077c4bde31cb56ce474424b358f17cec323d5c94af3970c9aada2,format=raw,if=none,id=drive0,readonly=on 
-device nvme,drive=drive0,bus=pcie.2,addr=0x0,serial=1234 -append 
"root=/dev/nvme0n1 console=tty0 console=hvc0"

PSeries Guest Bringup
Status: Success
qemu-system-ppc64 -name test-vm -machine pseries,accel=kvm -m 4096 smp 
8,sockets=1,cores=8,threads=1 -nographic -serial mon:stdio -drive 
file=/home/kvmci/tests/data/avocado-vt/images/rhel8.0devel-ppc64le.qcow2,if=virtio,format=qcow2 
-netdev bridge,id=net0,br=virbr0 -device virtio-net-pci,netdev=net0

Power8E/NVL Removal Verification
Status: Success (both correctly rejected after removal)
   qemu-system-ppc64: unable to find CPU model 'power8e_v2.1'
   qemu-system-ppc64: unable to find CPU model 'power8nvl_v1.0'

QEMU Functional Test Results (make check-functional-ppc64)
Status: Success
Ok:                 12
Fail:               0
Skipped:            4

QEMU Unit Test Results (make check-qtest-ppc64)
Status: Success
Ok:                 33
Fail:               0
Skipped:            0

Result: All tests passed successfully.

Tested-by: Misbah Anjum N <misanjum@linux.ibm.com>

Thanks,
Misbah Anjum N
Re: [PATCH v3 0/8] Testcase improvements and Power8E/NVL removal
Posted by Aditya Gupta 2 weeks ago
On 30/06/26 09:49, Misbah Anjum N wrote:
> On 2026-06-29 16:34, Aditya Gupta wrote:
>> <...snip...>
>>
>> base-commit: 20553466cc47af6a8c95f665b601fce3c852e503
>
> Hi Aditya,
>
> I've tested the v3 patch series on PowerNV and pSeries guests 
> including the new remote interrupts functional test and Power8E/NVL 
> removal.
>
> Testing Environment:
> - Host: Fedora 42 ppc64le
> - Arch: ppc64le
> - QEMU: emulator version 11.0.50 (v11.0.0-2400-g20553466cc-dirty)
>
> PowerNV Guest Bringup
> Status: Success
> qemu-system-ppc64 -name test-vm -machine powernv -m 4096 -smp 4 
> -nographic -kernel 
> ~/.cache/qemu/download/6fd29aff9ad4362511ea5d0acbb510667c7031928e97d64ec15bbc5daf4b8151 
> -drive 
> file=~/.cache/qemu/download/aee2192b692077c4bde31cb56ce474424b358f17cec323d5c94af3970c9aada2,format=raw,if=none,id=drive0,readonly=on 
> -device nvme,drive=drive0,bus=pcie.2,addr=0x0,serial=1234 -append 
> "root=/dev/nvme0n1 console=tty0 console=hvc0"
>
> PSeries Guest Bringup
> Status: Success
> qemu-system-ppc64 -name test-vm -machine pseries,accel=kvm -m 4096 smp 
> 8,sockets=1,cores=8,threads=1 -nographic -serial mon:stdio -drive 
> file=/home/kvmci/tests/data/avocado-vt/images/rhel8.0devel-ppc64le.qcow2,if=virtio,format=qcow2 
> -netdev bridge,id=net0,br=virbr0 -device virtio-net-pci,netdev=net0
>
> Power8E/NVL Removal Verification
> Status: Success (both correctly rejected after removal)
>   qemu-system-ppc64: unable to find CPU model 'power8e_v2.1'
>   qemu-system-ppc64: unable to find CPU model 'power8nvl_v1.0'
>
> QEMU Functional Test Results (make check-functional-ppc64)
> Status: Success
> Ok:                 12
> Fail:               0
> Skipped:            4
>
> QEMU Unit Test Results (make check-qtest-ppc64)
> Status: Success
> Ok:                 33
> Fail:               0
> Skipped:            0
>
> Result: All tests passed successfully.
>
> Tested-by: Misbah Anjum N <misanjum@linux.ibm.com>

Thank you for thoroughly testing this misbah !

- Aditya G

>
> Thanks,
> Misbah Anjum N