ci: Fix --engine flag positioning in helper script

[PATCH 0/1] ci: Fix --engine flag positioning in helper script

Radoslaw Smigielski via Devel posted 1 patch 1 week ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20260522165748.977942-1-rsmigiel@redhat.com

ci/helper | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH 0/1] ci: Fix --engine flag positioning in helper script

Posted by Radoslaw Smigielski via Devel 1 week ago

The --engine flag was passed before the "run" subcommand, causing
lcitool to fail with "invalid choice: 'podman'". Move it to opts so
the command is built correctly.

  lcitool container --engine podman run ...  (wrong)

This caused "invalid choice: 'podman'" errors because lcitool expected
a COMMAND argument at that position.

Fix by moving the --engine flag to opts array, which is added after
the "run" subcommand, resulting in the correct command structure:

  lcitool container run --engine podman ...  (correct)

Error example:

  $ ./ci/helper run fedora-44 --job codestyle --engine podman
  usage: lcitool container [-h] COMMAND ...
  lcitool container: error: argument COMMAND: invalid choice: 'podman' (choose from engines, build, run, shell)

The same error happens if "--engine" option is set to different
than "auto" value.

Radoslaw Smigielski (1):
  ci: Fix --engine flag positioning in helper script

 ci/helper | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

-- 
2.54.0