From nobody Sat May 30 15:30:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1779469197; cv=none; d=zohomail.com; s=zohoarc; b=EItM3pcUK1Z2HfIHOGek1mnuOd7Xu4pcMqXZzub5BDgWnJFDCJl1w1TkXhdDEp9OTuVDY3AWYfLy98IcUYQnBst0Weh795jQ2xZtKLCuZLU5PEgUbAy+K+5YjDACLzb47r+KK53fQ2q6g88/ghJM2VbO3Pg7W8hFBGRot+U7Fa8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779469197; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=+MXMjSK+wvBZSvP0+EGPI65LlxRBSvvDuEWb0pDIe2Y=; b=Jd52gyFEwU6x17JcTiLyvQoYOLqx0xK2xe2ozOFDWA2XGeFapFQfx2PBgVBbOMgRW27km6hkysmngG8xQH9LkAmituET/CKvkrzdSSiwUMHAKLP7Pdgu8mQDtCDFXAEcOsImAFs2wwogAxVdiZQ0bvGfjGwph4MkC4TYW/03aO4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1779469197392994.8184181748904; Fri, 22 May 2026 09:59:57 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id F2E0941AD0; Fri, 22 May 2026 12:59:55 -0400 (EDT) Received: from [172.19.199.4] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 109D941C2A; Fri, 22 May 2026 12:58:09 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DA17D41855; Fri, 22 May 2026 12:57:57 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3B1FA41AAD for ; Fri, 22 May 2026 12:57:57 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-sHYJRxDtMAGGYEze8Y5XDw-1; Fri, 22 May 2026 12:57:54 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 23D2D19560B2 for ; Fri, 22 May 2026 16:57:54 +0000 (UTC) Received: from rsmigiel-thinkpadx1carbongen11-remote-csb.redhat.com (unknown [10.44.48.48]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1F066300019F; Fri, 22 May 2026 16:57:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779469076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+MXMjSK+wvBZSvP0+EGPI65LlxRBSvvDuEWb0pDIe2Y=; b=KK4CF/dbPdkwrOukiPuJYKADkJr94u0OufBbiPktWWabF8uHtLvQPH5pIY6uKq4uRB8ho9 MPH7bK4OsZBy9iM/P7uWMh6IQgYpb2IQ4V3cpWCuEmnlASnzTXzk64LQT/3bIBfKVvXqKf YhvsYDdfTjuD2UC9RsfIeytZNr7ijDY= X-MC-Unique: sHYJRxDtMAGGYEze8Y5XDw-1 X-Mimecast-MFC-AGG-ID: sHYJRxDtMAGGYEze8Y5XDw_1779469074 To: devel@lists.libvirt.org Subject: [PATCH 1/1] ci: Fix --engine flag positioning in helper script Date: Fri, 22 May 2026 18:57:48 +0200 Message-ID: <20260522165748.977942-2-rsmigiel@redhat.com> In-Reply-To: <20260522165748.977942-1-rsmigiel@redhat.com> References: <20260522165748.977942-1-rsmigiel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: i_UTJg-qHG7r_U9zWZz7DAKSEmWYq8uv1HJDitRe6Bs_1779469074 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BRWC5VMTL7SFIPRZL6TGZSXLFMOQO7XY X-Message-ID-Hash: BRWC5VMTL7SFIPRZL6TGZSXLFMOQO7XY X-MailFrom: rsmigiel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Radoslaw Smigielski X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Radoslaw Smigielski via Devel Reply-To: Radoslaw Smigielski X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1779469205267154100 Content-Type: text/plain; charset="utf-8"; x-default="true" The --engine flag was being added to positional_args before the "run" subcommand, which resulted in incorrect lcitool invocations: lcitool container --engine podman run ... (wrong) This caused "invalid choice: 'podman'" errors because lcitool expected a COMMAND argument at that position. Fix by moving the --engine flag to opts array, which is added after the "run" subcommand, resulting in the correct command structure: lcitool container run --engine podman ... (correct) Example: $ ./ci/helper run fedora-44 --job codestyle --engine podman usage: lcitool container [-h] COMMAND ... lcitool container: error: argument COMMAND: invalid choice: 'podman' (choo= se from engines, build, run, shell) The same error happens if "--engine" option is set to different than "auto" value. Signed-off-by: Radoslaw Smigielski Reviewed-by: Peter Krempa --- ci/helper | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ci/helper b/ci/helper index 93508515cac8..c13ecd8c8404 100755 --- a/ci/helper +++ b/ci/helper @@ -173,9 +173,6 @@ class Application: "website": "run_website_build", } =20 - if self._args.engine !=3D "auto": - positional_args.extend(["--engine", self._args.engine]) - with open(Path(tmpdir.name, "script"), "w") as f: script_path =3D f.name contents =3D textwrap.dedent(f"""\ @@ -190,6 +187,8 @@ class Application: f.write(contents) =20 positional_args.append("run") + if self._args.engine !=3D "auto": + opts.extend(["--engine", self._args.engine]) opts.extend(["--script", script_path]) =20 opts.append(f"{self._args.image_prefix}{self._args.target}:{self._= args.image_tag}") --=20 2.54.0