bhyve: implement domain{Block,Interface,Memory}Stats

[PATCH v2 0/4] bhyve: implement domain{Block,Interface,Memory}Stats

Posted by Roman Bogorodskiy 3 months, 1 week ago

Changes since v1:

 - Added "bhyve: implement domainInterfaceStats" patch

PS It was temping to factor out obtaining struct kinfo_proc using
sysctlnametomib() + sysctl(), but I have to make it visible to use
outside of virprocess, e.g. in bhyve_driver.c, so it doesn't look like
it's worth the effort for now. Probably it'll make sense to implement a
FreeBSD version of virProcessGetStat() once there are more users of this
code.

Roman Bogorodskiy (4):
  bhyve: implement domainInterfaceStats
  virprocess: implement virProcessGetStatInfo() for FreeBSD
  bhyve: implement domainMemoryStats
  bhyve: implement domainBlockStats

 src/bhyve/bhyve_driver.c | 140 +++++++++++++++++++++++++++++++++++++++
 src/util/virprocess.c    | 104 +++++++++++++++++++++--------
 2 files changed, 218 insertions(+), 26 deletions(-)

-- 
2.49.0

Re: [PATCH v2 0/4] bhyve: implement domain{Block,Interface,Memory}Stats

Posted by Michal Prívozník via Devel 3 weeks ago

On 6/1/25 07:40, Roman Bogorodskiy wrote:
> Changes since v1:
> 
>  - Added "bhyve: implement domainInterfaceStats" patch
> 
> PS It was temping to factor out obtaining struct kinfo_proc using
> sysctlnametomib() + sysctl(), but I have to make it visible to use
> outside of virprocess, e.g. in bhyve_driver.c, so it doesn't look like
> it's worth the effort for now. Probably it'll make sense to implement a
> FreeBSD version of virProcessGetStat() once there are more users of this
> code.
> 
> Roman Bogorodskiy (4):
>   bhyve: implement domainInterfaceStats
>   virprocess: implement virProcessGetStatInfo() for FreeBSD
>   bhyve: implement domainMemoryStats
>   bhyve: implement domainBlockStats
> 
>  src/bhyve/bhyve_driver.c | 140 +++++++++++++++++++++++++++++++++++++++
>  src/util/virprocess.c    | 104 +++++++++++++++++++++--------
>  2 files changed, 218 insertions(+), 26 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and sorry for letting this slip review this long.

Michal

Re: [PATCH v2 0/4] bhyve: implement domain{Block,Interface,Memory}Stats

Posted by Roman Bogorodskiy 3 weeks, 6 days ago

  Roman Bogorodskiy wrote:

> Changes since v1:
> 
>  - Added "bhyve: implement domainInterfaceStats" patch
> 
> PS It was temping to factor out obtaining struct kinfo_proc using
> sysctlnametomib() + sysctl(), but I have to make it visible to use
> outside of virprocess, e.g. in bhyve_driver.c, so it doesn't look like
> it's worth the effort for now. Probably it'll make sense to implement a
> FreeBSD version of virProcessGetStat() once there are more users of this
> code.
> 
> Roman Bogorodskiy (4):
>   bhyve: implement domainInterfaceStats
>   virprocess: implement virProcessGetStatInfo() for FreeBSD
>   bhyve: implement domainMemoryStats
>   bhyve: implement domainBlockStats
> 
>  src/bhyve/bhyve_driver.c | 140 +++++++++++++++++++++++++++++++++++++++
>  src/util/virprocess.c    | 104 +++++++++++++++++++++--------
>  2 files changed, 218 insertions(+), 26 deletions(-)

ping