From nobody Tue Sep 9 19:05:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748756551314778.3697136342688; Sat, 31 May 2025 22:42:31 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 54F9112D0; Sun, 1 Jun 2025 01:42:30 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 07B6B13ED; Sun, 1 Jun 2025 01:41:49 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 74BF11298; Sun, 1 Jun 2025 01:41:45 -0400 (EDT) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B9CEA128E for ; Sun, 1 Jun 2025 01:41:44 -0400 (EDT) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-adb2bb25105so505682166b.0 for ; Sat, 31 May 2025 22:41:44 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-adb35af4456sm399732266b.182.2025.05.31.22.41.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 May 2025 22:41:42 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748756503; x=1749361303; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tmeN9qZM+TR8Cj3yHEUiUu8g9XGu6BiYFUYYXw100Xs=; b=XJKx5zZTb1kNLJwbv5TQP+mMjaQ1hb5gCamz8sv7+2HYvAgCgNjDJjngQEeHAr1/2m 6tiR6qEtS/IrfCrH6vMy0SRRLjJK/riXs5LNB+QO1AlP4brkJq3Stq2/DEVIVPY8VK2g jP4F/AvzjAD/Rgq/3SPSi1eY1Io7IAUPYGtU8TbQY0XGQIfzTVRNi1aEwxZNAFhhzWMK QkuYFWIMBNAGW6noO3KIrryVJuXlVaTxZ7s0o0CL/vTtP3QIDdPlLxJATIbogK++XomV vL5qN8vKxPuSUpAtOEvk7PmXco5H2qu2t5lDEUKlNc4AaSyEsYkxwYCqZ3hOie6KE3h3 ycRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748756503; x=1749361303; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tmeN9qZM+TR8Cj3yHEUiUu8g9XGu6BiYFUYYXw100Xs=; b=BI1WDA6lj/9Ln3ccEK7R1EPdxA8zJqjxcOt2w0A3I56o5wzqUVkB/LAbDO4NuDU1nM 9TPirJIbyq1s4fWWTFpThfQs7IJiORILkR0MMtvtyU1X8PhODW52YGQTX10hEwfhvcSs pGNk3LK2qCu2Bx2Iq/UWrhS+ynB8Wjs+bzHwYWwnaNacEECb/1gHThDRuoqvd1ZOOMvQ HqBQhhmCIbtaEQsHk584bH/r+Hu8fJg6uPVKbPH3IHgntQM5DBa8bBEFYrDNVAjMzSu5 sJRhmHnqzPyB3n1+YUGsoy95cGDZ8GOn1flee3bXTBcWq+26q5J37XPOJW6WOHZ7fT8E UVKw== X-Gm-Message-State: AOJu0Yw2QrhtrooWRvwKNEFIzt3fVIK9Ts8uy++9ubVLYzWyD4UFuwgj XB9yCemmW0aVoyXIPilyJm2DSuBC2MhdC9bjIMQKUpXDGrIKW40ZOUKtj2lBwMiV5Ko= X-Gm-Gg: ASbGncvn1/0P7n3gnl6QcAkdvimygjMppyWb8orANFwT7HhE4T+GomtsUliFW4zU4kP VRxK1PzEo4DsX/Qk+91P3K3LHUKwY/V75aSo9DmX1Ps8YhOhSnGcNKnEa9sViUnxaQWInd8cii6 sn2kFTFtXfAMwv6iVEvx+JLg1YPyJeBUv+GDG5gc9RqkFM6VwkNo8evhuiarHIvkuxB6ElVcDiZ xow0UT90YBpP3yLJS0721+JzFZqdaAjYDaDOijOOz4n/FJ6lna5OOQl8gacIZVaFbP3/+fFNmI5 zFB+bO6G0p0K3H6vVWetmeUvv4l4MFYSD4F9Be614+xguG+xT0q/7SNB9nc+9kBgrY5NBZZJObx 6kDxmbbVFnMxUl927XufWn7/I X-Google-Smtp-Source: AGHT+IHh50Ug2e2BSLsjWX5rd2k1KDDNFarzq7YvmRFs0FcHp5hFo6/pmDUIA0UHuJsy9nLqhw1JMQ== X-Received: by 2002:a17:906:6a1d:b0:ad9:adc3:20d4 with SMTP id a640c23a62f3a-adb36b230b5mr818789466b.4.1748756503155; Sat, 31 May 2025 22:41:43 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH v2 1/4] bhyve: implement domainInterfaceStats Date: Sun, 1 Jun 2025 07:40:23 +0200 Message-ID: <20250601054026.59551-2-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250601054026.59551-1-bogorodskiy@gmail.com> References: <20250601054026.59551-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: R42SLOOAHA5LKSVYM4U3OZ45YHSVBREW X-Message-ID-Hash: R42SLOOAHA5LKSVYM4U3OZ45YHSVBREW X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748756553310116600 Content-Type: text/plain; charset="utf-8" The virNetDevTapInterfaceStats() function already works on FreeBSD, so it's just a matter of wrapping that for domainInterfaceStats. Signed-off-by: Roman Bogorodskiy Reviewed-by: Michal Privoznik --- src/bhyve/bhyve_driver.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index db7d440a97..e4698b71bf 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -55,6 +55,7 @@ #include "conf/domain_capabilities.h" #include "virutil.h" #include "domain_driver.h" +#include "virnetdevtap.h" =20 #include "bhyve_conf.h" #include "bhyve_device.h" @@ -1625,6 +1626,38 @@ bhyveConnectGetDomainCapabilities(virConnectPtr conn, return ret; } =20 +static int +bhyveDomainInterfaceStats(virDomainPtr domain, + const char *device, + virDomainInterfaceStatsPtr stats) +{ + virDomainObj *vm; + int ret =3D -1; + virDomainNetDef *net =3D NULL; + + if (!(vm =3D bhyveDomObjFromDomain(domain))) + goto cleanup; + + if (virDomainInterfaceStatsEnsureACL(domain->conn, vm->def) < 0) + goto cleanup; + + if (virDomainObjCheckActive(vm) < 0) + goto cleanup; + + if (!(net =3D virDomainNetFind(vm->def, device))) + goto cleanup; + + if (virNetDevTapInterfaceStats(net->ifname, stats, + !virDomainNetTypeSharesHostView(net)) <= 0) + goto cleanup; + + ret =3D 0; + + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} + static virHypervisorDriver bhyveHypervisorDriver =3D { .name =3D "bhyve", .connectURIProbe =3D bhyveConnectURIProbe, @@ -1685,6 +1718,7 @@ static virHypervisorDriver bhyveHypervisorDriver =3D { .connectIsEncrypted =3D bhyveConnectIsEncrypted, /* 1.3.5 */ .connectDomainXMLFromNative =3D bhyveConnectDomainXMLFromNative, /* 2.= 1.0 */ .connectGetDomainCapabilities =3D bhyveConnectGetDomainCapabilities, /= * 2.1.0 */ + .domainInterfaceStats =3D bhyveDomainInterfaceStats, /* 11.5.0 */ }; =20 =20 --=20 2.49.0 From nobody Tue Sep 9 19:05:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748756577621720.9079218875157; Sat, 31 May 2025 22:42:57 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 90A3712B1; Sun, 1 Jun 2025 01:42:56 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 1C5791357; Sun, 1 Jun 2025 01:41:52 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id BFEAF1298; Sun, 1 Jun 2025 01:41:46 -0400 (EDT) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 09DC01182 for ; Sun, 1 Jun 2025 01:41:46 -0400 (EDT) Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-6046ecc3e43so5515915a12.3 for ; Sat, 31 May 2025 22:41:45 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-adb35af4456sm399732266b.182.2025.05.31.22.41.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 May 2025 22:41:43 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748756504; x=1749361304; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nBxpdXkDxPeM5AeA/n7ILT9lQg+ISgquul0qtl1WpYw=; b=S1AxlLs/dnyNjb6LIaEd3IyMObK1XjOWzlk7V18wl/ojq61UvuCCVX9N/hfb4IKyee KJmnYBtzVfRs88tnwHyNtbGfb1eZmR2OxqPWvslT9zjhwvXd3js2aPcT5jrQGYGv4vcs L4gyNUPHTJ11UHsc57p1CDVGVBKxKSpiifjhhunRZCk/2PrpuARCMpHDwAxJtWIRc0sT GWVQ46IZ7douJxHy2TN68VpgCP2L8X9gY7jItrSCxDxQouJAsjW4n3djWWKXn30eZi1O mIYyOz4varVUQDjvcsbJsE0j0gCSzuUPeZ3ALmdFFw2O0h0Jf9hMas+LW06kz1WG1JL9 y3Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748756504; x=1749361304; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nBxpdXkDxPeM5AeA/n7ILT9lQg+ISgquul0qtl1WpYw=; b=i6KfRg8YQU/n3fxi2re9SLppvbo0Pt5wSYbmMcujM9m21L8okNpWR03RUAni/jodtc HHM53Y5A6tPFXXdCrYdr02Qg30Bh3MIQ9QknqAUyE01wWn3P28vx3rceVvhl/Yl0ZeFe cnaf8dz0Y32G6ujGyQO/QC3w1oBfr0MeUP5/rjATIGDI8BuptoMrhE1bvJSg+bVrSDmY rQOL1/JFSLWkZ2CjiWRNkETUNnmi7zpeK8Y9ELw9RyG++TnuHIcT9yU5rJtGZyNnTljq UwYHYxrf8aC4HNtdAzovTNYOeyfqhrBrQWWXagyea/xRsFhUM0sOTGUDWCj3bbqO4XDU HsWg== X-Gm-Message-State: AOJu0YyFU37yXWPABdJaVQvPIMLUS1CfZAHc4berUAYNr8vjd8C7OMIM 7JzJC7U1YTCXEZjceumvFeh/ZZCg5m7+PfbuORqOW/4G0exCb4TvII/hbLkg43R0JJo= X-Gm-Gg: ASbGncuYbcg1t7+LSlXjOZpNM7crzf2ZC2XO8wHbcHONHBy9K+ffoPOUcoAYFxhVlAM S1jAKqA4is7D9TpzdFIhVGOMCa0lXenYlqNGEMJNWhIFnihmvYKhOVIARDGpLWNbi5jnmSTzCN/ 35n1XgrmxDtzLZ1rhFluK+AWD0pZpp11+WtOaF/vv9xt34ZWE1H1512xD5zhpAkoqRl2DhqySDk W7RuKCljKr0TGPa4JwfeO+iHG3sC9ZHgglGNos9Cm0eZ81NFYmbV6W65Vyr4gA5erZdvrSre8Tv cCc2KJHssTweHsFLiif6E6eFuHRog9p9iAbFQtcLirajFEdm4USSjypzYAgkcoUoZWGY02iO7X4 36v20q8vGbSTaer5j2R823ar1 X-Google-Smtp-Source: AGHT+IGqdFHwugNTzuqDnChRtgcK8NHGZBSiO34HzfK5zZ3DuArHGYCilJGEcaKOgxEuCJC83tEwkA== X-Received: by 2002:a17:907:2cc2:b0:ad5:3156:2c0c with SMTP id a640c23a62f3a-adb322afceamr819995666b.26.1748756504220; Sat, 31 May 2025 22:41:44 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH v2 2/4] virprocess: implement virProcessGetStatInfo() for FreeBSD Date: Sun, 1 Jun 2025 07:40:24 +0200 Message-ID: <20250601054026.59551-3-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250601054026.59551-1-bogorodskiy@gmail.com> References: <20250601054026.59551-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: UDGYXXVXD5S5PK65W2WKHJHLX7FAHZGR X-Message-ID-Hash: UDGYXXVXD5S5PK65W2WKHJHLX7FAHZGR X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748756579799116600 Content-Type: text/plain; charset="utf-8" Use the "kern.proc.pid" sysctl and retrieve information from the kinfo_proc struct. Signed-off-by: Roman Bogorodskiy Reviewed-by: Michal Privoznik --- src/util/virprocess.c | 104 +++++++++++++++++++++++++++++++----------- 1 file changed, 78 insertions(+), 26 deletions(-) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index 05db76d834..3889ba90f9 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -1812,7 +1812,85 @@ virProcessGetStatInfo(unsigned long long *cpuTime, =20 return 0; } +#elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) +int +virProcessGetStatInfo(unsigned long long *cpuTime, + unsigned long long *userTime, + unsigned long long *sysTime, + int *lastCpu, + unsigned long long *vm_rss, + pid_t pid, + pid_t tid) +{ + struct kinfo_proc p; + int mib[4]; + size_t len =3D 4; + unsigned long long utime =3D 0; + unsigned long long stime =3D 0; + unsigned long long rss =3D 0; + int cpu =3D 0; + const long pagesize =3D virGetSystemPageSizeKB(); + + sysctlnametomib("kern.proc.pid", mib, &len); + + len =3D sizeof(struct kinfo_proc); + mib[3] =3D pid; + + if (sysctl(mib, 4, &p, &len, NULL, 0) < 0) { + virReportSystemError(errno, "%s", + _("Unable to query process stats")); + return -1; + } + + utime =3D p.ki_rusage.ru_utime.tv_sec; + stime =3D p.ki_rusage.ru_stime.tv_sec; + rss =3D p.ki_rssize * pagesize; + cpu =3D p.ki_lastcpu_old; + + if (cpuTime) + *cpuTime =3D utime + stime; + if (userTime) + *userTime =3D utime; + if (sysTime) + *sysTime =3D stime; + if (lastCpu) + *lastCpu =3D cpu; + if (vm_rss) + *vm_rss =3D rss; + + VIR_DEBUG("Got status for %d/%d user=3D%llu sys=3D%llu cpu=3D%d rss=3D= %lld", + (int) pid, tid, utime, stime, cpu, rss); + + return 0; +} +#else +int +virProcessGetStatInfo(unsigned long long *cpuTime, + unsigned long long *userTime, + unsigned long long *sysTime, + int *lastCpu, + unsigned long long *vm_rss, + pid_t pid G_GNUC_UNUSED, + pid_t tid G_GNUC_UNUSED) +{ + /* We don't have a way to collect this information on non-Linux + * platforms, so just report neutral values */ + if (cpuTime) + *cpuTime =3D 0; + if (userTime) + *userTime =3D 0; + if (sysTime) + *sysTime =3D 0; + if (lastCpu) + *lastCpu =3D 0; + if (vm_rss) + *vm_rss =3D 0; + + return 0; +} +#endif =20 +#ifdef __linux__ int virProcessGetSchedInfo(unsigned long long *cpuWait, pid_t pid, @@ -1879,33 +1957,7 @@ virProcessGetSchedInfo(unsigned long long *cpuWait, =20 return 0; } - #else -int -virProcessGetStatInfo(unsigned long long *cpuTime, - unsigned long long *userTime, - unsigned long long *sysTime, - int *lastCpu, - unsigned long long *vm_rss, - pid_t pid G_GNUC_UNUSED, - pid_t tid G_GNUC_UNUSED) -{ - /* We don't have a way to collect this information on non-Linux - * platforms, so just report neutral values */ - if (cpuTime) - *cpuTime =3D 0; - if (userTime) - *userTime =3D 0; - if (sysTime) - *sysTime =3D 0; - if (lastCpu) - *lastCpu =3D 0; - if (vm_rss) - *vm_rss =3D 0; - - return 0; -} - int virProcessGetSchedInfo(unsigned long long *cpuWait, pid_t pid G_GNUC_UNUSED, --=20 2.49.0 From nobody Tue Sep 9 19:05:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 174875659853362.74028553239168; Sat, 31 May 2025 22:43:18 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 984101449; Sun, 1 Jun 2025 01:43:17 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 3F821143F; Sun, 1 Jun 2025 01:41:59 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 88FAB1387; Sun, 1 Jun 2025 01:41:53 -0400 (EDT) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 5F6941298 for ; Sun, 1 Jun 2025 01:41:47 -0400 (EDT) Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-acacb8743a7so611974266b.1 for ; Sat, 31 May 2025 22:41:47 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-adb35af4456sm399732266b.182.2025.05.31.22.41.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 May 2025 22:41:44 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748756506; x=1749361306; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3vVY/QB/s0640hlqw1zv0mNOWTuqvncI+zb5zV2OdIw=; b=nQLoruUvfqSuIDfq/ihituUvORXhxIS+Mi2ya8GVsoxDROSznPmref+thYpW5ssYyk YSRmNWfCLc0VQRpwveFocsB5uDo8ayAZksSF0Cr/IW2yGX7fcIrc+Xfk4BRf4XDK5FHY UBv6jkihYxl4rfTwZ0GGd5wz5t5R8Kjd/BymQy6jKpODp1R66a2ZIVmgscSfvTpr+/BN i5FoevmCC75QDXbSP9bE8lLtCoZzMHI4HRs74lJG7zUTCIGhiUopRKv9nIo1/P57Cyy/ zYe3tbiEIUo07z9g87oqoRE5vptORZNj0RArZKd4KUgCeO+jBHfAfi9gXS3dpzN1gcvH R+CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748756506; x=1749361306; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3vVY/QB/s0640hlqw1zv0mNOWTuqvncI+zb5zV2OdIw=; b=TyjIHV40QqxwptYD3mcMTfkXamQwVgj3LonMtqUUaoiU4A0RKKsdC/INn0lKB8t3bC 4AqsABxzT8mTFk8oeNuKEsACpcsg18ZSi1N3A0O+/O0Ob9rVGmxNbMIyU1Zh2wyTqiO4 lA7COO98c494PPD5D7oISkV+SF3uMGeptuz3KFnyEbRs9ehWQmp9kmVDTIhtJXJs6XlV jvyhrSuCt8dLeMi/czuJVAtbBG4zTbt5/ZlusMR0Due2KLi9HJz4YmfMc6iXmARSvFjT uNtiEUYQfFkMDoZhfP67nFyEww6mIxKX/bLV8MUc8YBc4tPss8K1w+hypzRHmqxdDW6Y s0Eg== X-Gm-Message-State: AOJu0YyP0bPnWeJRzDJvEsReP3NBSTKqAHrbGbczUDTH1KL1w0VSUqSw lcTH1Tiy3iC99aLhnQJ6ueUo1vx88FFFllT3Otue8OmdaSOJYKRtzNtzAX8VxSo6Kxk= X-Gm-Gg: ASbGncuRrdWIDjl38aEJ0jfNyjL22yfrsSqVzzBWhHA5pQVqUsfi1updJOOEJUpDd8S b1iJUczGe8V9whkTuZnpGT1kuyhkFJhIBoHgS1VbjrkMT4b5yWQ0AX50pbnTHsA45oidaVGaGUp twXbYGUaF4wuvvM64rdfy2ibWa6fbl/8O7LT2MRlzMcu0tlsXx6/XqtP9OpZsnxsH1yt/DGrpFE RewZSSgKe+v6464iJzapAZeaFJx1ki7pQNe8VHvogMcMUDhxyVQfX2zvzeTdzxTG2Yr8OkIpVTC 9PYkMkd7qnv4Jz1tDqvLRD6ALD6jYVJysLZS96Dm35fQLQdtJiV3XTMjjn0Kon10XVEe2BjTCZA 7dBtQtiV6np/MuvBUdgumGrNdPz5jLxhm3gs= X-Google-Smtp-Source: AGHT+IGuvC+Me7YJTlYlkG+BmOaMn6wbxWkZMEknimxMxQu1Dws/EKxwRxfxKR+q7phnxRtxDZiRtg== X-Received: by 2002:a17:907:608d:b0:ad8:5595:ce07 with SMTP id a640c23a62f3a-adb32ca4d5emr776241066b.19.1748756505584; Sat, 31 May 2025 22:41:45 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH v2 3/4] bhyve: implement domainMemoryStats Date: Sun, 1 Jun 2025 07:40:25 +0200 Message-ID: <20250601054026.59551-4-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250601054026.59551-1-bogorodskiy@gmail.com> References: <20250601054026.59551-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ZVJYGPXXL35K6KCCHPJPL5BOQIHFKABZ X-Message-ID-Hash: ZVJYGPXXL35K6KCCHPJPL5BOQIHFKABZ X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748756600091116600 Content-Type: text/plain; charset="utf-8" Currently, bhyve does not support neither memory ballooning nor reporting guest memory usage. So the following information can be obtained: - RSS of the running process - Memory available to the guest (that is, guest total memory) Signed-off-by: Roman Bogorodskiy Reviewed-by: Michal Privoznik --- src/bhyve/bhyve_driver.c | 50 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index e4698b71bf..70e28c7e0b 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -3,6 +3,7 @@ * * Copyright (C) 2014 Roman Bogorodskiy * Copyright (C) 2014-2015 Red Hat, Inc. + * Copyright (C) 2025 The FreeBSD Foundation * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -1658,6 +1659,54 @@ bhyveDomainInterfaceStats(virDomainPtr domain, return ret; } =20 +#define BHYVE_SET_MEMSTAT(TAG, VAL) \ + if (i < nr_stats) { \ + stats[i].tag =3D TAG; \ + stats[i].val =3D VAL; \ + i++; \ + } + +static int +bhyveDomainMemoryStats(virDomainPtr domain, + virDomainMemoryStatPtr stats, + unsigned int nr_stats, + unsigned int flags) +{ + virDomainObj *vm; + unsigned maxmem; + unsigned long long rss; + size_t i =3D 0; + int ret =3D -1; + + virCheckFlags(0, -1); + + if (!(vm =3D bhyveDomObjFromDomain(domain))) + goto cleanup; + + if (virDomainObjCheckActive(vm) < 0) + goto cleanup; + + if (virDomainMemoryStatsEnsureACL(domain->conn, vm->def) < 0) + goto cleanup; + + if (virProcessGetStatInfo(NULL, NULL, NULL, NULL, &rss, vm->pid, 0) < = 0) + virReportError(VIR_ERR_OPERATION_FAILED, "%s", + _("cannot get RSS for domain")); + else + BHYVE_SET_MEMSTAT(VIR_DOMAIN_MEMORY_STAT_RSS, rss); + + maxmem =3D virDomainDefGetMemoryTotal(vm->def); + BHYVE_SET_MEMSTAT(VIR_DOMAIN_MEMORY_STAT_AVAILABLE, maxmem); + + ret =3D i; + + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} + +#undef BHYVE_SET_MEMSTAT + static virHypervisorDriver bhyveHypervisorDriver =3D { .name =3D "bhyve", .connectURIProbe =3D bhyveConnectURIProbe, @@ -1719,6 +1768,7 @@ static virHypervisorDriver bhyveHypervisorDriver =3D { .connectDomainXMLFromNative =3D bhyveConnectDomainXMLFromNative, /* 2.= 1.0 */ .connectGetDomainCapabilities =3D bhyveConnectGetDomainCapabilities, /= * 2.1.0 */ .domainInterfaceStats =3D bhyveDomainInterfaceStats, /* 11.5.0 */ + .domainMemoryStats =3D bhyveDomainMemoryStats, /* 11.5.0 */ }; =20 =20 --=20 2.49.0 From nobody Tue Sep 9 19:05:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748756619980956.1386708800218; Sat, 31 May 2025 22:43:39 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 049881395; Sun, 1 Jun 2025 01:43:38 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 2D12E138C; Sun, 1 Jun 2025 01:42:03 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 681371492; Sun, 1 Jun 2025 01:41:57 -0400 (EDT) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C2BDB13DF for ; Sun, 1 Jun 2025 01:41:48 -0400 (EDT) Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-ad69e4f2100so496498766b.2 for ; Sat, 31 May 2025 22:41:48 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-adb35af4456sm399732266b.182.2025.05.31.22.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 May 2025 22:41:45 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748756507; x=1749361307; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zKEmnObCvXKV05vB+/kKLXcReihnIAS6JkEvROMtZ+Q=; b=nBPtoA1XBzj1uPishsPPKtSxZTWYM5OVWHVM3juAVctQfmH2PHN4F2V7qCyHWbCnzK iP8CJb36StsyENSQTgZ7ESj0NwBIlNuo4yfaEFWYSIizpauxpxAuyqLC8rKqqXCz1u5d /3EU6FS1xCp2DmyGjJ5zFpW8AG4coNs6OS4lQZlOwlM7QKZvGWm7ipU7nVE+lhNdB7J1 Tq1Qb1lfid1ugKGffKZUPtkv5iVWLzlGlrwP491ZEox13TG5f6GiLOngd9Q4IV4k9eTm IZoJvZu2URwOvcdGOU8eqccggN69sQsR3q/CV7pu2QcQxV1xQebLB5CWLnrwE0FPDlxb 9r0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748756507; x=1749361307; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zKEmnObCvXKV05vB+/kKLXcReihnIAS6JkEvROMtZ+Q=; b=NF9gv8F64RrDRy3+KcSy9xg9aUvY6ODR7yxfiakDlS2427kzqNY6O4QNCWvqN4KzIJ eWKE/OyT6qmUF1Xn+X2r/6YohccC1TQDI1FWynE0atGXRpyZEhepnVAZOaUwPEC2uTms TR92/E2+TN/W35NtxbIJc+CbrVd1DrZ6YbOB29ye/yAH5RfMdV/wsWt+6X4rjkeUrzov R89BnO2C4AGipIUJmyLBkpaVSG886NTlDA5PwagIKTi9jq6AafL4YSSlujCoBk/JP7qi 4n93iWJhPNk/1Mmv9OR70JTMOhJq20tPfVZRFiDJ+OJxKZu0IOhkg0TqKcxi2G5sMkpc j+YA== X-Gm-Message-State: AOJu0Yy4faJYSgIK8+OmLvAeF3B1u0LMQaTBRpANd0P+DjhVw7U6GBra NdxN9QcX6b1W0ojkBbEOs7oNVfPtcUkoH6nWxSKAB0OS0K+6C44dURzbSq/3JOFI6q4= X-Gm-Gg: ASbGncs/061aEWTcFSSwrlIVyJPH03WPK7/cE5/F87jh58CNux60ws4Lyr8iFSujGi9 y9ALkwui76yg6PCmceQ6HHSn+1M4Txm+T9o6/g9OShOZP4h2rBhd7TxHSPB/Ue+hiCO1lVGDm4Z 7tgoPeLl7EgLvJYAUG6srvMfnbJV14AC/Wma//ctPbqcLpsJcvXZ+ULETMfZF1wR9bVUSNjneu4 yNWNde71+6BGSYR4+mS/aHJtJ+5NGNhsBBa2U52inkUIGvzxj7rGEGb+JDo4yt2FAJwhangPvRD eAkEYiplRlJR67Kw5tk0O/kXIy9FZ3C6P0goml+PJ0QDX3WX+lLCtZTHeY6rKAKZ4rtmVWSDRQl FjOj8FWFIHoSq+1kaOQg7OPDL X-Google-Smtp-Source: AGHT+IH/4HY5JX7GX8XpszDDcVavdgQJEYLxL33u/mahx9loUJcawRROCDE1K0+pKGfAlIPw9OoWRw== X-Received: by 2002:a17:907:3e08:b0:ad8:8c52:d61f with SMTP id a640c23a62f3a-adb36bf1976mr674604366b.35.1748756506906; Sat, 31 May 2025 22:41:46 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH v2 4/4] bhyve: implement domainBlockStats Date: Sun, 1 Jun 2025 07:40:26 +0200 Message-ID: <20250601054026.59551-5-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250601054026.59551-1-bogorodskiy@gmail.com> References: <20250601054026.59551-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: HXMEXOXCHBM5NAHJAND45OXBWJPGXYGO X-Message-ID-Hash: HXMEXOXCHBM5NAHJAND45OXBWJPGXYGO X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748756622195116600 Content-Type: text/plain; charset="utf-8" Implement domainBlockStats for the bhyve driver. Only the read/write operations counts are reported as FreeBSD apparently doesn't support accumulative bytes read or written, though real-time data is available via rctl(8). There's also no information about the errors. Signed-off-by: Roman Bogorodskiy Reviewed-by: Michal Privoznik --- src/bhyve/bhyve_driver.c | 56 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 70e28c7e0b..acec98d100 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -24,6 +24,9 @@ =20 #include #include +#include +#include +#include =20 #include "virerror.h" #include "datatypes.h" @@ -1707,6 +1710,58 @@ bhyveDomainMemoryStats(virDomainPtr domain, =20 #undef BHYVE_SET_MEMSTAT =20 +static struct kinfo_proc *bhyveDomainProcGetInfo(pid_t pid) +{ + int mib[4]; + size_t len =3D 4; + struct kinfo_proc *p =3D g_malloc0(sizeof(struct kinfo_proc)); + + sysctlnametomib("kern.proc.pid", mib, &len); + len =3D sizeof(struct kinfo_proc); + mib[3] =3D pid; + + if (sysctl(mib, 4, p, &len, NULL, 0) < 0) { + virReportSystemError(errno, "%s", + _("Unable to query process stats")); + return NULL; + } + + return p; +} + +static int +bhyveDomainBlockStats(virDomainPtr domain, + const char *path G_GNUC_UNUSED, + virDomainBlockStatsPtr stats) +{ + virDomainObj *vm; + int ret =3D -1; + g_autofree struct kinfo_proc *p =3D NULL; + + if (!(vm =3D bhyveDomObjFromDomain(domain))) + goto cleanup; + + if (virDomainObjCheckActive(vm) < 0) + goto cleanup; + + if (virDomainBlockStatsEnsureACL(domain->conn, vm->def) < 0) + goto cleanup; + + if ((p =3D bhyveDomainProcGetInfo(vm->pid)) =3D=3D NULL) + goto cleanup; + + stats->rd_req =3D p->ki_rusage.ru_inblock; + stats->wr_req =3D p->ki_rusage.ru_oublock; + stats->rd_bytes =3D -1; + stats->wr_bytes =3D -1; + stats->errs =3D -1; + + ret =3D 0; + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} + static virHypervisorDriver bhyveHypervisorDriver =3D { .name =3D "bhyve", .connectURIProbe =3D bhyveConnectURIProbe, @@ -1769,6 +1824,7 @@ static virHypervisorDriver bhyveHypervisorDriver =3D { .connectGetDomainCapabilities =3D bhyveConnectGetDomainCapabilities, /= * 2.1.0 */ .domainInterfaceStats =3D bhyveDomainInterfaceStats, /* 11.5.0 */ .domainMemoryStats =3D bhyveDomainMemoryStats, /* 11.5.0 */ + .domainBlockStats =3D bhyveDomainBlockStats, /* 11.5.0 */ }; =20 =20 --=20 2.49.0