interface: fix udev reference leak with invalid flags

[PATCH] interface: fix udev reference leak with invalid flags

Daniel P. Berrangé posted 1 patch 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20240605110336.335880-1-berrange@redhat.com

src/interface/interface_backend_udev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] interface: fix udev reference leak with invalid flags

Posted by Daniel P. Berrangé 3 months ago

The udevInterfaceGetXMLDesc method takes a reference on the udev
driver as its first action. If the virCheckFlags() condition
fails, however, this reference is never released.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/interface/interface_backend_udev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c
index fdf11a8318..e1a50389c9 100644
--- a/src/interface/interface_backend_udev.c
+++ b/src/interface/interface_backend_udev.c
@@ -1027,12 +1027,14 @@ static char *
 udevInterfaceGetXMLDesc(virInterfacePtr ifinfo,
                         unsigned int flags)
 {
-    struct udev *udev = udev_ref(driver->udev);
+    struct udev *udev = NULL;
     g_autoptr(virInterfaceDef) ifacedef = NULL;
     char *xmlstr = NULL;
 
     virCheckFlags(VIR_INTERFACE_XML_INACTIVE, NULL);
 
+    udev = udev_ref(driver->udev);
+
     /* Recursively build up the interface XML based on the requested
      * interface name
      */
-- 
2.45.1

Re: [PATCH] interface: fix udev reference leak with invalid flags

Posted by Peter Krempa 3 months ago

On Wed, Jun 05, 2024 at 12:03:36 +0100, Daniel P. Berrangé wrote:
> The udevInterfaceGetXMLDesc method takes a reference on the udev
> driver as its first action. If the virCheckFlags() condition
> fails, however, this reference is never released.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/interface/interface_backend_udev.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>