From nobody Mon Sep 16 19:12:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1717585463688671.8329194899848; Wed, 5 Jun 2024 04:04:23 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 654531E38; Wed, 5 Jun 2024 07:04:22 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 471AA1E50; Wed, 5 Jun 2024 07:03:45 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 2D5D51E34; Wed, 5 Jun 2024 07:03:41 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B08231E2F for ; Wed, 5 Jun 2024 07:03:40 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-182-_l9NCjStMaOZ1CQvQ7OdSg-1; Wed, 05 Jun 2024 07:03:39 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C20DE101A520 for ; Wed, 5 Jun 2024 11:03:38 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.39.193.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1CA15FF02; Wed, 5 Jun 2024 11:03:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717585420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vCaBywiiBCaPlmjKdb8lxvNUNxLtavYEDo9OJ6KIYWM=; b=Vf2SE0VNsBjCa8J6+CwLasGIFF3ifIFgJ2awoXTrQRD7eGdFzvXLNUcP2SQ5ogbx4mnh2H PVcFwvYMF0BDWrlS4J8siC100ibVp7ppVPYppTxGf1EU93A7danDYqmyD1N4P8JwiMLFa3 TaBF+7IRwKFMqPBnveAUv+KDJeyJuFM= X-MC-Unique: _l9NCjStMaOZ1CQvQ7OdSg-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH] interface: fix udev reference leak with invalid flags Date: Wed, 5 Jun 2024 12:03:36 +0100 Message-ID: <20240605110336.335880-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: RC5XGBNRJ6Y6AKOJ2DQPP26CLSEJDV3G X-Message-ID-Hash: RC5XGBNRJ6Y6AKOJ2DQPP26CLSEJDV3G X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1717585464029100001 Content-Type: text/plain; charset="utf-8" The udevInterfaceGetXMLDesc method takes a reference on the udev driver as its first action. If the virCheckFlags() condition fails, however, this reference is never released. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- src/interface/interface_backend_udev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/interface/interface_backend_udev.c b/src/interface/interfa= ce_backend_udev.c index fdf11a8318..e1a50389c9 100644 --- a/src/interface/interface_backend_udev.c +++ b/src/interface/interface_backend_udev.c @@ -1027,12 +1027,14 @@ static char * udevInterfaceGetXMLDesc(virInterfacePtr ifinfo, unsigned int flags) { - struct udev *udev =3D udev_ref(driver->udev); + struct udev *udev =3D NULL; g_autoptr(virInterfaceDef) ifacedef =3D NULL; char *xmlstr =3D NULL; =20 virCheckFlags(VIR_INTERFACE_XML_INACTIVE, NULL); =20 + udev =3D udev_ref(driver->udev); + /* Recursively build up the interface XML based on the requested * interface name */ --=20 2.45.1