[v1] qemu: Introduce shared_filesystems configuration option

[PATCH 02/10] security: Fix name for _virSecurityDACChardevCallbackData

Posted by Andrea Bolognani 1 year, 10 months ago

It was clearly copied over from the SELinux driver without
updating its name in the process.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/security/security_dac.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index 4b8130630f..7421496fc9 100644
--- a/src/security/security_dac.c
+++ b/src/security/security_dac.c
@@ -1671,7 +1671,7 @@ virSecurityDACRestoreChardevLabel(virSecurityManager *mgr,
 }
 
 
-struct _virSecuritySELinuxChardevCallbackData {
+struct _virSecurityDACChardevCallbackData {
     virSecurityManager *mgr;
     bool chardevStdioLogd;
 };
@@ -1682,7 +1682,7 @@ virSecurityDACRestoreChardevCallback(virDomainDef *def,
                                      virDomainChrDef *dev G_GNUC_UNUSED,
                                      void *opaque)
 {
-    struct _virSecuritySELinuxChardevCallbackData *data = opaque;
+    struct _virSecurityDACChardevCallbackData *data = opaque;
 
     return virSecurityDACRestoreChardevLabel(data->mgr, def, dev->source,
                                              data->chardevStdioLogd);
@@ -1916,7 +1916,7 @@ virSecurityDACRestoreAllLabel(virSecurityManager *mgr,
     size_t i;
     int rc = 0;
 
-    struct _virSecuritySELinuxChardevCallbackData chardevData = {
+    struct _virSecurityDACChardevCallbackData chardevData = {
         .mgr = mgr,
         .chardevStdioLogd = chardevStdioLogd,
     };
@@ -2018,7 +2018,7 @@ virSecurityDACSetChardevCallback(virDomainDef *def,
                                  virDomainChrDef *dev G_GNUC_UNUSED,
                                  void *opaque)
 {
-    struct _virSecuritySELinuxChardevCallbackData *data = opaque;
+    struct _virSecurityDACChardevCallbackData *data = opaque;
 
     return virSecurityDACSetChardevLabel(data->mgr, def, dev->source,
                                          data->chardevStdioLogd);
@@ -2141,7 +2141,7 @@ virSecurityDACSetAllLabel(virSecurityManager *mgr,
     uid_t user;
     gid_t group;
 
-    struct _virSecuritySELinuxChardevCallbackData chardevData = {
+    struct _virSecurityDACChardevCallbackData chardevData = {
         .mgr = mgr,
         .chardevStdioLogd = chardevStdioLogd,
     };
-- 
2.44.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

Re: [PATCH 02/10] security: Fix name for _virSecurityDACChardevCallbackData

Posted by Stefan Berger 1 year, 10 months ago


On 3/20/24 05:19, Andrea Bolognani wrote:
> It was clearly copied over from the SELinux driver without
> updating its name in the process.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

Re: [PATCH 02/10] security: Fix name for _virSecurityDACChardevCallbackData

Posted by Peter Krempa 1 year, 10 months ago

On Wed, Mar 20, 2024 at 10:19:07 +0100, Andrea Bolognani wrote:
> It was clearly copied over from the SELinux driver without
> updating its name in the process.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  src/security/security_dac.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org