From nobody Tue Feb 10 08:01:22 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1710926473457261.28917764703283; Wed, 20 Mar 2024 02:21:13 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 5012D1EFA; Wed, 20 Mar 2024 05:21:12 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 2F54C1C80; Wed, 20 Mar 2024 05:19:37 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id CA6CB1B62; Wed, 20 Mar 2024 05:19:29 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 7FE7B1B7E for ; Wed, 20 Mar 2024 05:19:27 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-XFeMWliCNRau5p2TUSFaaQ-1; Wed, 20 Mar 2024 05:19:23 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 83CB1800265; Wed, 20 Mar 2024 09:19:23 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.225.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E6431C1576F; Wed, 20 Mar 2024 09:19:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: XFeMWliCNRau5p2TUSFaaQ-1 From: Andrea Bolognani To: devel@lists.libvirt.org Subject: [PATCH 02/10] security: Fix name for _virSecurityDACChardevCallbackData Date: Wed, 20 Mar 2024 10:19:07 +0100 Message-ID: <20240320091915.369391-3-abologna@redhat.com> In-Reply-To: <20240320091915.369391-1-abologna@redhat.com> References: <20240320091915.369391-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: T33CVW3I7VWANMCDTCNCWFWFE53FBAZI X-Message-ID-Hash: T33CVW3I7VWANMCDTCNCWFWFE53FBAZI X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Stefan Berger X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1710926474215100001 It was clearly copied over from the SELinux driver without updating its name in the process. Signed-off-by: Andrea Bolognani Reviewed-by: Peter Krempa Reviewed-by: Stefan Berger --- src/security/security_dac.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index 4b8130630f..7421496fc9 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -1671,7 +1671,7 @@ virSecurityDACRestoreChardevLabel(virSecurityManager = *mgr, } =20 =20 -struct _virSecuritySELinuxChardevCallbackData { +struct _virSecurityDACChardevCallbackData { virSecurityManager *mgr; bool chardevStdioLogd; }; @@ -1682,7 +1682,7 @@ virSecurityDACRestoreChardevCallback(virDomainDef *de= f, virDomainChrDef *dev G_GNUC_UNUSED, void *opaque) { - struct _virSecuritySELinuxChardevCallbackData *data =3D opaque; + struct _virSecurityDACChardevCallbackData *data =3D opaque; =20 return virSecurityDACRestoreChardevLabel(data->mgr, def, dev->source, data->chardevStdioLogd); @@ -1916,7 +1916,7 @@ virSecurityDACRestoreAllLabel(virSecurityManager *mgr, size_t i; int rc =3D 0; =20 - struct _virSecuritySELinuxChardevCallbackData chardevData =3D { + struct _virSecurityDACChardevCallbackData chardevData =3D { .mgr =3D mgr, .chardevStdioLogd =3D chardevStdioLogd, }; @@ -2018,7 +2018,7 @@ virSecurityDACSetChardevCallback(virDomainDef *def, virDomainChrDef *dev G_GNUC_UNUSED, void *opaque) { - struct _virSecuritySELinuxChardevCallbackData *data =3D opaque; + struct _virSecurityDACChardevCallbackData *data =3D opaque; =20 return virSecurityDACSetChardevLabel(data->mgr, def, dev->source, data->chardevStdioLogd); @@ -2141,7 +2141,7 @@ virSecurityDACSetAllLabel(virSecurityManager *mgr, uid_t user; gid_t group; =20 - struct _virSecuritySELinuxChardevCallbackData chardevData =3D { + struct _virSecurityDACChardevCallbackData chardevData =3D { .mgr =3D mgr, .chardevStdioLogd =3D chardevStdioLogd, }; --=20 2.44.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org