On 19/07/23 14:48, Michal Prívozník wrote:
> On 7/11/23 08:47, K Shiva Kiran wrote:
>> This commit introduces <title> and <description> fields to the
>> XML schema of the Network object.
>> It also adds public Get/Set APIs for modifying all metadata fields
>> of the same, along with a test program.
>>
>> K Shiva Kiran (4):
>> Add <title> and <description> for Network Objects
>> Adding Public Get and Set APIs for Network Metadata
>> Add virNetworkObj Get and Set Methods for Metadata
>> Add Test driver and testcase for Network Metadata change APIs
>>
>> docs/formatnetwork.rst | 11 +
>> include/libvirt/libvirt-network.h | 29 +++
>> include/libvirt/virterror.h | 1 +
>> src/conf/network_conf.c | 21 ++
>> src/conf/network_conf.h | 2 +
>> src/conf/schemas/basictypes.rng | 15 ++
>> src/conf/schemas/domaincommon.rng | 15 --
>> src/conf/schemas/network.rng | 10 +
>> src/conf/virnetworkobj.c | 325 ++++++++++++++++++++++++++++++
>> src/conf/virnetworkobj.h | 17 ++
>> src/driver-network.h | 16 ++
>> src/libvirt-network.c | 167 +++++++++++++++
>> src/libvirt_public.syms | 6 +
>> src/remote/remote_driver.c | 2 +
>> src/remote/remote_protocol.x | 36 +++-
>> src/remote_protocol-structs | 19 ++
>> src/test/test_driver.c | 67 ++++++
>> src/util/virerror.c | 3 +
>> tests/meson.build | 1 +
>> tests/networkmetadatatest.c | 297 +++++++++++++++++++++++++++
>> 20 files changed, 1044 insertions(+), 16 deletions(-)
>> create mode 100644 tests/networkmetadatatest.c
>>
> No virsh exposure of these new APIs? :-(
>
> Michal
>
I had planned to introduce virsh as well as metadata change callbacks
soon after these patches got pushed, is that ok?
Shiva