On 8/16/23 20:47, K Shiva Kiran wrote:
> This commit adds the following:
> - Introduction of <title> and <description> fields to the Network Object.
> - Introduction of Get and Set Public APIs for the aforementioned fields.
> - virsh exposure of the aforementioned Public APIs.
> - Adds implementation in test driver along with a testcase.
> - Implementation in bridge driver.
>
> This is a v2 of:
> https://listman.redhat.com/archives/libvir-list/2023-July/240828.html
> Diff to v1:
> - Corrected placement of structs in remote_protocol-structs.
> - Removed redundant call to virNetworkObjSetDefTransient() in
> virNetworkConfigChangeSetup().
> - Removed redundant logic in networkUpdate(), substituted by call to
> newly introduced virNetworkObjUpdateModificationImpact().
> - Added virsh exposure of the APIs.
> - Added bridge driver implementation.
>
> Signed-off-by: K Shiva Kiran <shiva_kr@riseup.net>
>
> K Shiva Kiran (7):
> Add <title> and <description> for Network Objects
> Adding Public Get and Set APIs for Network Metadata
> Implementing Remote Protocol for Network Metadata
> virsh exposure of Network Metadata APIs
> Add virNetworkObj Get and Set Methods for Metadata
> Add Test driver and testcase for Network Metadata change APIs
> Added bridge driver implementation
>
> docs/formatnetwork.rst | 11 +
> docs/manpages/virsh.rst | 77 ++++++
> include/libvirt/libvirt-network.h | 29 +++
> include/libvirt/virterror.h | 1 +
> src/conf/network_conf.c | 21 ++
> src/conf/network_conf.h | 2 +
> src/conf/schemas/basictypes.rng | 15 ++
> src/conf/schemas/domaincommon.rng | 15 --
> src/conf/schemas/network.rng | 10 +
> src/conf/virnetworkobj.c | 329 +++++++++++++++++++++++-
> src/conf/virnetworkobj.h | 21 ++
> src/driver-network.h | 16 ++
> src/libvirt-network.c | 167 ++++++++++++
> src/libvirt_private.syms | 3 +
> src/libvirt_public.syms | 6 +
> src/network/bridge_driver.c | 78 +++++-
> src/remote/remote_driver.c | 2 +
> src/remote/remote_protocol.x | 36 ++-
> src/remote_protocol-structs | 19 ++
> src/test/test_driver.c | 83 +++++-
> src/util/virerror.c | 3 +
> tests/meson.build | 1 +
> tests/networkmetadatatest.c | 297 +++++++++++++++++++++
> tools/virsh-network.c | 411 +++++++++++++++++++++++++++++-
> tools/virsh-util.c | 25 ++
> tools/virsh-util.h | 9 +
> 26 files changed, 1624 insertions(+), 63 deletions(-)
> create mode 100644 tests/networkmetadatatest.c
>
Alright. Let me merge these. Vven though they should have been
structured differently, the code looks factually okay.
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
As we are getting close to the release, please do write a NEWS entry as
this is something that users might find valuable.
Michal