util: Improve comment for workaround

[libvirt PATCH] util: Improve comment for workaround

Andrea Bolognani posted 1 patch 11 months, 4 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20230504160835.182030-1-abologna@redhat.com

src/util/virfile.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[libvirt PATCH] util: Improve comment for workaround

Posted by Andrea Bolognani 11 months, 4 weeks ago

Now that a version of GLib that contains the fix has been
released, it's more useful to record that information. Adding
a TODO annotation makes the whole thing easily greppable.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/util/virfile.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/util/virfile.c b/src/util/virfile.c
index 657e74e026..228482e8f8 100644
--- a/src/util/virfile.c
+++ b/src/util/virfile.c
@@ -1747,8 +1747,7 @@ virFindFileInPath(const char *file)
         return NULL;
 
     /* Workaround for a bug in g_find_program_in_path() not returning absolute
-     * path as documented.  This has been fixed in
-     * https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2127
+     * path as documented. TODO drop it once we require GLib >= 2.69.0
      */
     return g_canonicalize_filename(path, NULL);
 }
-- 
2.40.1

Re: [libvirt PATCH] util: Improve comment for workaround

Posted by Ján Tomko 11 months, 4 weeks ago

On a Thursday in 2023, Andrea Bolognani wrote:
>Now that a version of GLib that contains the fix has been
>released, it's more useful to record that information. Adding
>a TODO annotation makes the whole thing easily greppable.
>
>Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>---
> src/util/virfile.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano