From nobody Fri Mar 29 05:04:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1683216534; cv=none; d=zohomail.com; s=zohoarc; b=n2sp8exXbeVRj0O1BJUrA67372Txcui20kGmwGrL3Wy3UtlsUKYJHuK6cuRj1wEFZItdQY/CrFZ+bDzvTOfVWJ3zntJSWTz2RvCuAgRGyr/OdsBs6x1PCqTjgS0BGL0mfgFprI+/IKjAbsEX7+bigZ+ZxqckZw2F3UypesEUtzo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683216534; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=pctSKcJxAo8AgJtI3DrqWwstEzM+rnyf9dhre+pHR7g=; b=POvyFLObJFxs0OANn3aRGb0XjRTJ+8zRD9x1lb77gpeTDffC3oox49ZMATvEu0FEKGO3vS63GBUgdASxoBcalS5g3Al1gnKdrzTV1D5+tpTzot6a72EYmq+PVf+8VYM/TXWcU3v37Vvy1ezJgw56Jc2IOgXc541niKa6cw6Rj5U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 168321653484993.21925467252208; Thu, 4 May 2023 09:08:54 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-22-B52jrMhnO9GFxnTwaeardQ-1; Thu, 04 May 2023 12:08:52 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 258D6811E7E; Thu, 4 May 2023 16:08:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0921E2026D25; Thu, 4 May 2023 16:08:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BA30F1946A42; Thu, 4 May 2023 16:08:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6EFBA19465BB for ; Thu, 4 May 2023 16:08:42 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 419ECC15BAE; Thu, 4 May 2023 16:08:37 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.225.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C900AC15BAD for ; Thu, 4 May 2023 16:08:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683216533; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=pctSKcJxAo8AgJtI3DrqWwstEzM+rnyf9dhre+pHR7g=; b=ArqFZyenU5mNcwLhntyiK1lZqRRvQZiHvsTM3IvCpFWFhax+vbZjjBBJz09tqz3JDkxyBe PGr4GF5yA3cZaPoz37pOwNRODxCbqXhA9zAClZScvAgEu3fXKFUhRNc3It2Dng8qlk+3A6 O344hysFNXBfuoOQ7nTFago2zZTlDBQ= X-MC-Unique: B52jrMhnO9GFxnTwaeardQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH] util: Improve comment for workaround Date: Thu, 4 May 2023 18:08:35 +0200 Message-Id: <20230504160835.182030-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1683216535645100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Now that a version of GLib that contains the fix has been released, it's more useful to record that information. Adding a TODO annotation makes the whole thing easily greppable. Signed-off-by: Andrea Bolognani Reviewed-by: J=C3=A1n Tomko --- src/util/virfile.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 657e74e026..228482e8f8 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -1747,8 +1747,7 @@ virFindFileInPath(const char *file) return NULL; =20 /* Workaround for a bug in g_find_program_in_path() not returning abso= lute - * path as documented. This has been fixed in - * https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2127 + * path as documented. TODO drop it once we require GLib >=3D 2.69.0 */ return g_canonicalize_filename(path, NULL); } --=20 2.40.1