[libvirt PATCH 2/2] qemu: remove extraneous error log when qemuPasstStart() fails during hotplug

Laine Stump posted 2 patches 2 years, 11 months ago
[libvirt PATCH 2/2] qemu: remove extraneous error log when qemuPasstStart() fails during hotplug
Posted by Laine Stump 2 years, 11 months ago
qemuPasstStart() already logs any error that occurs, so having the
caller log a generic error message only serves to obscure the actual
problem.

Fixes: a56f0168d576fa01cec204dc3c67d4d63ab8487f
Signed-off-by: Laine Stump <laine@redhat.com>
---
 src/qemu/qemu_hotplug.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index b4cddef9f5..da17525824 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -1205,11 +1205,8 @@ qemuDomainAttachNetDevice(virQEMUDriver *driver,
     case VIR_DOMAIN_NET_TYPE_USER:
         if (net->backend.type == VIR_DOMAIN_NET_BACKEND_PASST) {
 
-            if (qemuPasstStart(vm, net) < 0) {
-                virReportError(VIR_ERR_INTERNAL_ERROR,
-                               "%s", _("Failed to start passt"));
+            if (qemuPasstStart(vm, net) < 0)
                 goto cleanup;
-            }
 
         } else if (!priv->disableSlirp &&
                    virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DBUS_VMSTATE)) {
-- 
2.39.2