From nobody Tue Feb 10 23:53:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1677025810; cv=none; d=zohomail.com; s=zohoarc; b=ZqjPMzeYBKhx7JzIGJWao+hodXVD3Ziuwqly+sHKYVxWURl8+i5w0xZdx8dmkhQCeCh8jtnKDflJWWVryYO5USBuD/QlZkBx2vtjsuqh5bO4vysrYeYHMS47Vdr5f1rQszPGib2bGdhriNrlKUOjQQT8/85oxwO2lenTGof0CZY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677025810; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QOYJFv6Bf1CcoBg45tZCU/KiWPTLN3/qdQBo9TGsbxo=; b=FTH5LZRfAppYieAhU93RN35NH9Dj5U1vH3VkxlZf3CjtHV0ybElQOPNmtv89dTQiC2dbIwtC3ex8ghu4FqgNOuQLb7WYevxVDTZAlI3ZdPb+AY431V+thAOk0hZtAH/zrVlM5WexQPHGlUIF/1UEuq5iqMwc+jZ9HxrBhebIQk8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1677025810188207.26844216792767; Tue, 21 Feb 2023 16:30:10 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-659-q5PpBlJVP46ut2VKuqSmOA-1; Tue, 21 Feb 2023 19:30:04 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2D853802D2E; Wed, 22 Feb 2023 00:30:01 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63811404BEC0; Wed, 22 Feb 2023 00:30:00 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3F8D31946588; Wed, 22 Feb 2023 00:30:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8D380194658C for ; Wed, 22 Feb 2023 00:29:50 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 3A58E492B07; Wed, 22 Feb 2023 00:29:50 +0000 (UTC) Received: from vhost3.router.laine.org (unknown [10.2.16.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 22955492B04 for ; Wed, 22 Feb 2023 00:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677025809; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=QOYJFv6Bf1CcoBg45tZCU/KiWPTLN3/qdQBo9TGsbxo=; b=Es8KWSTfkAxdixzistrlNePsgNSMwKcZ4f6fxXTgZZjUVADuddW9frtTXShqO2yx6lLCbh wfxROQvX/c45f8Ikl8H+k4QJZyYJ3QD7o+DePCJoVXhMmDwXUkY5Yp9cCdSS6uYZy03XBT SfljmlnlUuMvWyLQqSgu/fQkNJaMel0= X-MC-Unique: q5PpBlJVP46ut2VKuqSmOA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Laine Stump To: libvir-list@redhat.com Subject: [libvirt PATCH 2/2] qemu: remove extraneous error log when qemuPasstStart() fails during hotplug Date: Tue, 21 Feb 2023 19:29:49 -0500 Message-Id: <20230222002949.56722-3-laine@redhat.com> In-Reply-To: <20230222002949.56722-1-laine@redhat.com> References: <20230222002949.56722-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1677025811940100003 Content-Type: text/plain; charset="utf-8"; x-default="true" qemuPasstStart() already logs any error that occurs, so having the caller log a generic error message only serves to obscure the actual problem. Fixes: a56f0168d576fa01cec204dc3c67d4d63ab8487f Signed-off-by: Laine Stump --- src/qemu/qemu_hotplug.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index b4cddef9f5..da17525824 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1205,11 +1205,8 @@ qemuDomainAttachNetDevice(virQEMUDriver *driver, case VIR_DOMAIN_NET_TYPE_USER: if (net->backend.type =3D=3D VIR_DOMAIN_NET_BACKEND_PASST) { =20 - if (qemuPasstStart(vm, net) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - "%s", _("Failed to start passt")); + if (qemuPasstStart(vm, net) < 0) goto cleanup; - } =20 } else if (!priv->disableSlirp && virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DBUS_VMSTATE))= { --=20 2.39.2