[PATCH v6 1/4] rpm: fix %preun of virtnetworkd

Olaf Hering posted 4 patches 4 years, 1 month ago
There is a newer version of this series
[PATCH v6 1/4] rpm: fix %preun of virtnetworkd
Posted by Olaf Hering 4 years, 1 month ago
Fixes: 50eae3f8859c746aa474401b38902fa500f23fad ("rpm: handle enabling/disabling modular daemons post/postun-install")

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 libvirt.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index f6c705564a..16be1e173e 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1388,7 +1388,7 @@ fi
 %endif
 %libvirt_daemon_schedule_restart virtnetworkd
 
-%preun
+%preun daemon-driver-network
 %libvirt_daemon_systemd_preun virtnetworkd
 
 %postun daemon-driver-network

Re: [PATCH v6 1/4] rpm: fix %preun of virtnetworkd
Posted by Ani Sinha 4 years, 1 month ago

On Tue, 21 Dec 2021, Olaf Hering wrote:

> Fixes: 50eae3f8859c746aa474401b38902fa500f23fad ("rpm: handle enabling/disabling modular daemons post/postun-install")
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Reviewed-by: Ani Sinha <ani@anisinha.ca>

> ---
>  libvirt.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index f6c705564a..16be1e173e 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -1388,7 +1388,7 @@ fi
>  %endif
>  %libvirt_daemon_schedule_restart virtnetworkd
>
> -%preun
> +%preun daemon-driver-network
>  %libvirt_daemon_systemd_preun virtnetworkd
>
>  %postun daemon-driver-network
>
>

Re: [PATCH v6 1/4] rpm: fix %preun of virtnetworkd
Posted by Andrea Bolognani 4 years, 1 month ago
On Tue, Dec 21, 2021 at 12:22:42PM +0100, Olaf Hering wrote:
> -%preun
> +%preun daemon-driver-network
>  %libvirt_daemon_systemd_preun virtnetworkd

Good catch. I've tweaked the commit message slightly and pushed this
as well as the second patch.

While doing so, I unfortunately failed to pick up Ani Sinha's R-b.
Apologies for that!

I'll need to spend a bit more time on the next patch.

-- 
Andrea Bolognani / Red Hat / Virtualization