[PATCH v6 0/4] remove sysconfig files

Olaf Hering posted 4 patches 2 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20211221112245.27209-1-olaf@aepfle.de
There is a newer version of this series
NEWS.rst                                |  10 +++
docs/daemons.rst                        |  20 +++++
docs/remote.html.in                     |   6 +-
libvirt.spec.in                         | 103 ++++++++++++++++--------
src/ch/meson.build                      |   5 --
src/ch/virtchd.service.in               |   1 +
src/ch/virtchd.sysconf                  |   3 -
src/interface/meson.build               |   5 --
src/interface/virtinterfaced.service.in |   1 +
src/interface/virtinterfaced.sysconf    |   3 -
src/libxl/meson.build                   |   5 --
src/libxl/virtxend.service.in           |   1 +
src/libxl/virtxend.sysconf              |   3 -
src/locking/meson.build                 |   5 --
src/locking/virtlockd.service.in        |   1 +
src/locking/virtlockd.sysconf           |   3 -
src/logging/meson.build                 |   5 --
src/logging/virtlogd.sysconf            |   3 -
src/lxc/meson.build                     |   5 --
src/lxc/virtlxcd.service.in             |   1 +
src/lxc/virtlxcd.sysconf                |   3 -
src/meson.build                         |  16 ----
src/network/meson.build                 |   5 --
src/network/virtnetworkd.service.in     |   1 +
src/network/virtnetworkd.sysconf        |   3 -
src/node_device/meson.build             |   5 --
src/node_device/virtnodedevd.service.in |   1 +
src/node_device/virtnodedevd.sysconf    |   3 -
src/nwfilter/meson.build                |   5 --
src/nwfilter/virtnwfilterd.service.in   |   1 +
src/nwfilter/virtnwfilterd.sysconf      |   3 -
src/qemu/meson.build                    |   5 --
src/qemu/virtqemud.service.in           |   7 ++
src/qemu/virtqemud.sysconf              |  12 ---
src/remote/libvirtd.service.in          |   7 ++
src/remote/libvirtd.sysconf             |  21 -----
src/remote/meson.build                  |  10 ---
src/remote/virtproxyd.service.in        |   1 +
src/remote/virtproxyd.sysconf           |   3 -
src/secret/meson.build                  |   5 --
src/secret/virtsecretd.service.in       |   1 +
src/secret/virtsecretd.sysconf          |   3 -
src/storage/meson.build                 |   5 --
src/storage/virtstoraged.service.in     |   1 +
src/storage/virtstoraged.sysconf        |   3 -
src/vbox/meson.build                    |   5 --
src/vbox/virtvboxd.service.in           |   1 +
src/vbox/virtvboxd.sysconf              |   3 -
src/vz/meson.build                      |   5 --
src/vz/virtvzd.service.in               |   1 +
src/vz/virtvzd.sysconf                  |   3 -
tools/libvirt-guests.sh.in              |  40 +++++++++
tools/libvirt-guests.sysconf            |  50 ------------
tools/meson.build                       |   6 --
54 files changed, 170 insertions(+), 263 deletions(-)
delete mode 100644 src/ch/virtchd.sysconf
delete mode 100644 src/interface/virtinterfaced.sysconf
delete mode 100644 src/libxl/virtxend.sysconf
delete mode 100644 src/locking/virtlockd.sysconf
delete mode 100644 src/logging/virtlogd.sysconf
delete mode 100644 src/lxc/virtlxcd.sysconf
delete mode 100644 src/network/virtnetworkd.sysconf
delete mode 100644 src/node_device/virtnodedevd.sysconf
delete mode 100644 src/nwfilter/virtnwfilterd.sysconf
delete mode 100644 src/qemu/virtqemud.sysconf
delete mode 100644 src/remote/libvirtd.sysconf
delete mode 100644 src/remote/virtproxyd.sysconf
delete mode 100644 src/secret/virtsecretd.sysconf
delete mode 100644 src/storage/virtstoraged.sysconf
delete mode 100644 src/vbox/virtvboxd.sysconf
delete mode 100644 src/vz/virtvzd.sysconf
delete mode 100644 tools/libvirt-guests.sysconf
[PATCH v6 0/4] remove sysconfig files
Posted by Olaf Hering 2 years, 3 months ago
fix virtnetworkd
avoid duplicate %posttrans sections (berrange)
add comment to %libvirt_sc_pre (berrange)
rebased to adc0eaead0ebe11f38798e431d2748bfe9b54a30

Olaf Hering (4):
  rpm: fix %preun of virtnetworkd
  libvirt.spec: relocate pre script of daemon-driver-qemu
  remove sysconfig files
  NEWS: mention removal of sysconfig

 NEWS.rst                                |  10 +++
 docs/daemons.rst                        |  20 +++++
 docs/remote.html.in                     |   6 +-
 libvirt.spec.in                         | 103 ++++++++++++++++--------
 src/ch/meson.build                      |   5 --
 src/ch/virtchd.service.in               |   1 +
 src/ch/virtchd.sysconf                  |   3 -
 src/interface/meson.build               |   5 --
 src/interface/virtinterfaced.service.in |   1 +
 src/interface/virtinterfaced.sysconf    |   3 -
 src/libxl/meson.build                   |   5 --
 src/libxl/virtxend.service.in           |   1 +
 src/libxl/virtxend.sysconf              |   3 -
 src/locking/meson.build                 |   5 --
 src/locking/virtlockd.service.in        |   1 +
 src/locking/virtlockd.sysconf           |   3 -
 src/logging/meson.build                 |   5 --
 src/logging/virtlogd.sysconf            |   3 -
 src/lxc/meson.build                     |   5 --
 src/lxc/virtlxcd.service.in             |   1 +
 src/lxc/virtlxcd.sysconf                |   3 -
 src/meson.build                         |  16 ----
 src/network/meson.build                 |   5 --
 src/network/virtnetworkd.service.in     |   1 +
 src/network/virtnetworkd.sysconf        |   3 -
 src/node_device/meson.build             |   5 --
 src/node_device/virtnodedevd.service.in |   1 +
 src/node_device/virtnodedevd.sysconf    |   3 -
 src/nwfilter/meson.build                |   5 --
 src/nwfilter/virtnwfilterd.service.in   |   1 +
 src/nwfilter/virtnwfilterd.sysconf      |   3 -
 src/qemu/meson.build                    |   5 --
 src/qemu/virtqemud.service.in           |   7 ++
 src/qemu/virtqemud.sysconf              |  12 ---
 src/remote/libvirtd.service.in          |   7 ++
 src/remote/libvirtd.sysconf             |  21 -----
 src/remote/meson.build                  |  10 ---
 src/remote/virtproxyd.service.in        |   1 +
 src/remote/virtproxyd.sysconf           |   3 -
 src/secret/meson.build                  |   5 --
 src/secret/virtsecretd.service.in       |   1 +
 src/secret/virtsecretd.sysconf          |   3 -
 src/storage/meson.build                 |   5 --
 src/storage/virtstoraged.service.in     |   1 +
 src/storage/virtstoraged.sysconf        |   3 -
 src/vbox/meson.build                    |   5 --
 src/vbox/virtvboxd.service.in           |   1 +
 src/vbox/virtvboxd.sysconf              |   3 -
 src/vz/meson.build                      |   5 --
 src/vz/virtvzd.service.in               |   1 +
 src/vz/virtvzd.sysconf                  |   3 -
 tools/libvirt-guests.sh.in              |  40 +++++++++
 tools/libvirt-guests.sysconf            |  50 ------------
 tools/meson.build                       |   6 --
 54 files changed, 170 insertions(+), 263 deletions(-)
 delete mode 100644 src/ch/virtchd.sysconf
 delete mode 100644 src/interface/virtinterfaced.sysconf
 delete mode 100644 src/libxl/virtxend.sysconf
 delete mode 100644 src/locking/virtlockd.sysconf
 delete mode 100644 src/logging/virtlogd.sysconf
 delete mode 100644 src/lxc/virtlxcd.sysconf
 delete mode 100644 src/network/virtnetworkd.sysconf
 delete mode 100644 src/node_device/virtnodedevd.sysconf
 delete mode 100644 src/nwfilter/virtnwfilterd.sysconf
 delete mode 100644 src/qemu/virtqemud.sysconf
 delete mode 100644 src/remote/libvirtd.sysconf
 delete mode 100644 src/remote/virtproxyd.sysconf
 delete mode 100644 src/secret/virtsecretd.sysconf
 delete mode 100644 src/storage/virtstoraged.sysconf
 delete mode 100644 src/vbox/virtvboxd.sysconf
 delete mode 100644 src/vz/virtvzd.sysconf
 delete mode 100644 tools/libvirt-guests.sysconf

Re: [PATCH v6 0/4] remove sysconfig files
Posted by Jim Fehlig 2 years, 3 months ago
On 12/21/21 04:22, Olaf Hering wrote:
> fix virtnetworkd
> avoid duplicate %posttrans sections (berrange)
> add comment to %libvirt_sc_pre (berrange)
> rebased to adc0eaead0ebe11f38798e431d2748bfe9b54a30
> 
> Olaf Hering (4):
>    rpm: fix %preun of virtnetworkd
>    libvirt.spec: relocate pre script of daemon-driver-qemu
>    remove sysconfig files
>    NEWS: mention removal of sysconfig
> 
>   NEWS.rst                                |  10 +++
>   docs/daemons.rst                        |  20 +++++
>   docs/remote.html.in                     |   6 +-
>   libvirt.spec.in                         | 103 ++++++++++++++++--------
>   src/ch/meson.build                      |   5 --
>   src/ch/virtchd.service.in               |   1 +
>   src/ch/virtchd.sysconf                  |   3 -
>   src/interface/meson.build               |   5 --
>   src/interface/virtinterfaced.service.in |   1 +
>   src/interface/virtinterfaced.sysconf    |   3 -
>   src/libxl/meson.build                   |   5 --
>   src/libxl/virtxend.service.in           |   1 +
>   src/libxl/virtxend.sysconf              |   3 -
>   src/locking/meson.build                 |   5 --
>   src/locking/virtlockd.service.in        |   1 +
>   src/locking/virtlockd.sysconf           |   3 -
>   src/logging/meson.build                 |   5 --
>   src/logging/virtlogd.sysconf            |   3 -
>   src/lxc/meson.build                     |   5 --
>   src/lxc/virtlxcd.service.in             |   1 +
>   src/lxc/virtlxcd.sysconf                |   3 -
>   src/meson.build                         |  16 ----
>   src/network/meson.build                 |   5 --
>   src/network/virtnetworkd.service.in     |   1 +
>   src/network/virtnetworkd.sysconf        |   3 -
>   src/node_device/meson.build             |   5 --
>   src/node_device/virtnodedevd.service.in |   1 +
>   src/node_device/virtnodedevd.sysconf    |   3 -
>   src/nwfilter/meson.build                |   5 --
>   src/nwfilter/virtnwfilterd.service.in   |   1 +
>   src/nwfilter/virtnwfilterd.sysconf      |   3 -
>   src/qemu/meson.build                    |   5 --
>   src/qemu/virtqemud.service.in           |   7 ++
>   src/qemu/virtqemud.sysconf              |  12 ---
>   src/remote/libvirtd.service.in          |   7 ++
>   src/remote/libvirtd.sysconf             |  21 -----
>   src/remote/meson.build                  |  10 ---
>   src/remote/virtproxyd.service.in        |   1 +
>   src/remote/virtproxyd.sysconf           |   3 -
>   src/secret/meson.build                  |   5 --
>   src/secret/virtsecretd.service.in       |   1 +
>   src/secret/virtsecretd.sysconf          |   3 -
>   src/storage/meson.build                 |   5 --
>   src/storage/virtstoraged.service.in     |   1 +
>   src/storage/virtstoraged.sysconf        |   3 -
>   src/vbox/meson.build                    |   5 --
>   src/vbox/virtvboxd.service.in           |   1 +
>   src/vbox/virtvboxd.sysconf              |   3 -
>   src/vz/meson.build                      |   5 --
>   src/vz/virtvzd.service.in               |   1 +
>   src/vz/virtvzd.sysconf                  |   3 -
>   tools/libvirt-guests.sh.in              |  40 +++++++++
>   tools/libvirt-guests.sysconf            |  50 ------------
>   tools/meson.build                       |   6 --
>   54 files changed, 170 insertions(+), 263 deletions(-)
>   delete mode 100644 src/ch/virtchd.sysconf
>   delete mode 100644 src/interface/virtinterfaced.sysconf
>   delete mode 100644 src/libxl/virtxend.sysconf
>   delete mode 100644 src/locking/virtlockd.sysconf
>   delete mode 100644 src/logging/virtlogd.sysconf
>   delete mode 100644 src/lxc/virtlxcd.sysconf
>   delete mode 100644 src/network/virtnetworkd.sysconf
>   delete mode 100644 src/node_device/virtnodedevd.sysconf
>   delete mode 100644 src/nwfilter/virtnwfilterd.sysconf
>   delete mode 100644 src/qemu/virtqemud.sysconf
>   delete mode 100644 src/remote/libvirtd.sysconf
>   delete mode 100644 src/remote/virtproxyd.sysconf
>   delete mode 100644 src/secret/virtsecretd.sysconf
>   delete mode 100644 src/storage/virtstoraged.sysconf
>   delete mode 100644 src/vbox/virtvboxd.sysconf
>   delete mode 100644 src/vz/virtvzd.sysconf
>   delete mode 100644 tools/libvirt-guests.sysconf

This version fixes the lint error noted by Daniel and all CI tests now pass

https://gitlab.com/jfehlig/libvirt/-/pipelines/434480400

With that

Reviewed-by: Jim Fehlig <jfehlig@suse.com>

but I'll still wait for a nod of approval from a representative of at least one 
other distro before pushing :-).

Also, no need for V7 only to fix my NEWS nits in 4/4. If in agreement, I can 
make the change before pushing.

Jim