[PATCH 0/2] libxl: Remove dead code

Jim Fehlig posted 2 patches 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20211123234330.5138-1-jfehlig@suse.com
src/libxl/libxl_domain.c | 38 ++++++--------------------------------
src/libxl/libxl_domain.h |  7 -------
2 files changed, 6 insertions(+), 39 deletions(-)

[PATCH 0/2] libxl: Remove dead code

Posted by Jim Fehlig 2 weeks ago
I was too lazy to dig through history, but I think 1/2 was the result
of too much copy and paste when originally implementing jobs in the
libxl driver. For 2/2, I think there was some ill-conceived locking of
the libxlDomainObjPrivate in the past. Its use was killed but the
object remained virObjectLockable.

Jim Fehlig (2):
  libxl: Remove unused macros
  libxl: Don't derive libxlDomainObjPrivate from virObjectLockable

 src/libxl/libxl_domain.c | 38 ++++++--------------------------------
 src/libxl/libxl_domain.h |  7 -------
 2 files changed, 6 insertions(+), 39 deletions(-)

-- 
2.33.0


Re: [PATCH 0/2] libxl: Remove dead code

Posted by Michal Prívozník 2 weeks ago
On 11/24/21 00:43, Jim Fehlig wrote:
> I was too lazy to dig through history, but I think 1/2 was the result
> of too much copy and paste when originally implementing jobs in the
> libxl driver. For 2/2, I think there was some ill-conceived locking of
> the libxlDomainObjPrivate in the past. Its use was killed but the
> object remained virObjectLockable.
> 
> Jim Fehlig (2):
>   libxl: Remove unused macros
>   libxl: Don't derive libxlDomainObjPrivate from virObjectLockable
> 
>  src/libxl/libxl_domain.c | 38 ++++++--------------------------------
>  src/libxl/libxl_domain.h |  7 -------
>  2 files changed, 6 insertions(+), 39 deletions(-)
> 

Funny thing is that LIBXL_JOB_ABORT which is removed in 1/2 was never
defined :-)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal