From nobody Wed Apr 24 16:16:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1637711056988955.4148228345699; Tue, 23 Nov 2021 15:44:16 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-118-RiK4KxVkNEOvKXO5gn2MpA-1; Tue, 23 Nov 2021 18:44:14 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 83AE21808339; Tue, 23 Nov 2021 23:44:09 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F35160862; Tue, 23 Nov 2021 23:44:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0CC804EA39; Tue, 23 Nov 2021 23:44:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1ANNhkjL030058 for ; Tue, 23 Nov 2021 18:43:47 -0500 Received: by smtp.corp.redhat.com (Postfix) id BFA642024CAE; Tue, 23 Nov 2021 23:43:46 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B8F102026D69 for ; Tue, 23 Nov 2021 23:43:42 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AB9891066680 for ; Tue, 23 Nov 2021 23:43:42 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-205-0xOPtcLJPxyP5v3aC9Jh-A-1; Tue, 23 Nov 2021 18:43:40 -0500 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-22-phWc0DFHOo-O-7rKYeICOA-1; Wed, 24 Nov 2021 00:43:37 +0100 Received: from AM0PR04MB4899.eurprd04.prod.outlook.com (2603:10a6:208:c5::16) by AM0PR04MB5508.eurprd04.prod.outlook.com (2603:10a6:208:112::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Tue, 23 Nov 2021 23:43:37 +0000 Received: from AM0PR04MB4899.eurprd04.prod.outlook.com ([fe80::c58b:de4e:3ba7:9ef6]) by AM0PR04MB4899.eurprd04.prod.outlook.com ([fe80::c58b:de4e:3ba7:9ef6%4]) with mapi id 15.20.4713.026; Tue, 23 Nov 2021 23:43:37 +0000 Received: from localhost (75.169.35.15) by AS9PR06CA0235.eurprd06.prod.outlook.com (2603:10a6:20b:45e::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.20 via Frontend Transport; Tue, 23 Nov 2021 23:43:36 +0000 X-MC-Unique: RiK4KxVkNEOvKXO5gn2MpA-1 X-MC-Unique: 0xOPtcLJPxyP5v3aC9Jh-A-1 X-MC-Unique: phWc0DFHOo-O-7rKYeICOA-1 From: Jim Fehlig To: libvir-list@redhat.com Subject: [PATCH 1/2] libxl: Remove unused macros Date: Tue, 23 Nov 2021 16:43:29 -0700 Message-ID: <20211123234330.5138-2-jfehlig@suse.com> In-Reply-To: <20211123234330.5138-1-jfehlig@suse.com> References: <20211123234330.5138-1-jfehlig@suse.com> X-ClientProxiedBy: AS9PR06CA0235.eurprd06.prod.outlook.com (2603:10a6:20b:45e::34) To AM0PR04MB4899.eurprd04.prod.outlook.com (2603:10a6:208:c5::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3f92c7fb-d1a9-4009-67c3-08d9aedb11d4 X-MS-TrafficTypeDiagnostic: AM0PR04MB5508: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:556 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: WpsCKfOi1j46p7LdehoZxSlgM1HJ5bldfQwSH5o8pgZ9H6T9wy5oDjONvjKrbkw34UbDw08Qz9MmUJp6vCAwAcddLSgE33WsA/olWP6uYEDCbLMU3ZGeG+nV15WxJEVWDwwpjcYUtA3IqE0sjwLqt/w9cT8q57OR7uWc3a//lT0eyjBvRH5aDcRmU8i76u0QoEJOD2Q82XjuUjVVnM8cHDWYZqkLayw8lqfGCad/kMovSMBIPyHckT6yqISPJexwNbSZCtLGKg1oIFYWl14MFKJlYwVV6qVNWt8Go+sT3d4J+XfT6m0rWvqBzLwHI8WdTLbtSx98GfuvmhK+jURDNFOIwpIk7BJ9yvvQzssrtawIijNgN7Q4RNZmXTaNM0UwPfmp7Yzvh5QLYCqGcI2LQtBgo7PerpdoZE+MKrajM9nWc5FukOmupSz+5FZ5g7IT/Xd+23I0gvMtwPCsFd7AmEJTpOTh/c7aQBAHL/dSTzKfyX2GlPGNYM3lvFJ/YzeBmL9wn/3ZDjQDMnukUzhHNnT2saneIejUTwr3udZY/ccVsaLEVHLRriAUuA+jtilw5J/6pXebgUii3SK6aFs6jVTUwjPKSqft3cIX3vIUTM1yc9UiRLo/diXKbdqjwoHKpI/SSMOHF60QY/2zRfzHRw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR04MB4899.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(26005)(2906002)(36756003)(8936002)(1076003)(6486002)(2616005)(956004)(186003)(86362001)(6916009)(66556008)(4744005)(6496006)(6666004)(5660300002)(38100700002)(66476007)(83380400001)(66946007)(508600001)(316002)(8676002); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MWWQ3F1cMORT5KvM3238exIB5nq5jci/tUR4+rwT82/OPEh7/AY3aR6uZIGz?= =?us-ascii?Q?/tFqUuuIsKqU58caeVFIzTAcBVCbhRLliF2JOD2G34xORrUkp6+y3bV8MW4Y?= =?us-ascii?Q?/P7/CGkQ2gdEK4rL5MCg02aFe5QRCvJFgxoTk1zUwclupRoSOAigVB4SXDOK?= =?us-ascii?Q?+STbKuU9JJEllS29fwdxl5jEW/lNbM/T7h4zXLuBeBKaXP6zd0gdHbUzuUrm?= =?us-ascii?Q?2vUN6EYtYzP25jhLfz1F+jgtf33+n6RwzjN+DzrfV01LJdx3xdKSElyLDg8l?= =?us-ascii?Q?FZ2OgSg5hgZsQVK1q1sRM09IQsOYJ3YkIEDHVdHBRjecX6jZsj7qHj/K14fw?= =?us-ascii?Q?Ec1alSPgEcKRoyxJ7HzaXCBjEiCJlSKyZQx1RJUZMqT1ZWqG/1aw3eGnQns1?= =?us-ascii?Q?+jGM8oOQEH87qLhcsD4bRqrDCXh7Vrofpoj7oP2qWze4toUX+cRwqfAGoQ9b?= =?us-ascii?Q?0Gvvh4wQRWmgZccuW4y++RQk6AmUJpdGYshvqLU3nENprT3OjZ+O8oOeEKdI?= =?us-ascii?Q?ad4bXzXs9ppzPjHyG76NZsUHmZH+YdCNkpCSSGQsZEIBZd86d6nIBTZhbbAc?= =?us-ascii?Q?aoQtGJrVa603hYXvcASwwV0k5Dsdeq3CsmOplgAGCLH2aVSrlgi10vb1170v?= =?us-ascii?Q?HCtK/76iIOrsoAE031tMUd1UEtxyLKCsdTeLgtxA69PO1kHcoAQPrWjnMoRh?= =?us-ascii?Q?RtGbQxhi6Dzo21+Jf5T67AwMU+jcqaM1oXrGWeIrqWmn3K35o/gxQLPvZD5C?= =?us-ascii?Q?T1dhsWYz5ecv7fFyhRkQbPFtnCcIee61CiabpuznQaKVvCYEzbg5MDyAC1yf?= =?us-ascii?Q?A4EnQk3uGZeFL62z2/Qj+83VzS7gml0Gi1IWWK3OULCUk9/xMZLFaLnVSwkg?= =?us-ascii?Q?4FRWXhbzUgEQRxXsMpXAL4O87eDp+0qu2ersfl2Nh33QspKlbX+vrUkHt+pO?= =?us-ascii?Q?fVg1muIgmZcYUUvEMcNxhXMbjSXrHilGBEriCDy8GYETuXcRtrNRJROjuTJC?= =?us-ascii?Q?rbKvg3X4WCIZbbYnxRzbgsM4a4fvsyfyC+7CMiEhQnhtwyDAEFVxaZcuqiHp?= =?us-ascii?Q?hYsy+2ksNjRb+G9GDg4cAeQVUxGSxED6LrMdB2MSVAMNpkyXc+vZSjzpTfe3?= =?us-ascii?Q?oVWAkUNcveoYB3HShu5QK/YKRlJ2+kaJ7AgYcCOj+nT2PX6rpXo+nKh4fOOm?= =?us-ascii?Q?rzJ6OLRQvp55yZ54ozu/TvI11xToO1QyaM/XpWiPPeNx6St8wi1T+Yomp184?= =?us-ascii?Q?NsMnMndXwYJtqMDEdGQYyBBU+t1IUu7oBa85ipedPQwaZD/HiY7WsXMSu6G7?= =?us-ascii?Q?9xrkRRfdVQ1dDEM7zyyeq0vYt+w+fbGb8oYNRJ+78aOufgD0QMtEGi+LuJiS?= =?us-ascii?Q?R0KzeowvIiD22e5JAA9lGDG2XHB6WpUxI/bgm6BIqM0M1rHlkgCCM7GC/lKX?= =?us-ascii?Q?oDxYh4v0WMGj1T6pPC8A24vFRqdHeh5yknj+4fWIO55s5cA9+iZ5gzspaaW6?= =?us-ascii?Q?8Qdrn/aPHthmQDW/lHtrfF69AxwDRy2unvA7QfG9hlEWYc37Bi0TmEjhh0K9?= =?us-ascii?Q?/JNgyidnIXJmYEUWNZucvVKLi52xivlQPW1nLqJ5FxdyffLVdBbpGFSp4dhC?= =?us-ascii?Q?949klOcgl6akXEF/Zh/6o0U=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f92c7fb-d1a9-4009-67c3-08d9aedb11d4 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB4899.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 23:43:37.0928 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fa3YgnP1ILlW2bbjFvo6s4D6ADoUmHwSNMIgz43C5Je/+2IhYrdMt55Lx3Bjt8V965IRWcN/V03PJEmnKaroxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5508 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1ANNhkjL030058 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1637711058863100001 Content-Type: text/plain; charset="utf-8" Remove unused JOB_MASK and DEFAULT_JOB_MASK macros. Signed-off-by: Jim Fehlig Reviewed-by: Michal Privoznik --- src/libxl/libxl_domain.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/libxl/libxl_domain.h b/src/libxl/libxl_domain.h index 1618c47ed5..8d36197faf 100644 --- a/src/libxl/libxl_domain.h +++ b/src/libxl/libxl_domain.h @@ -27,11 +27,6 @@ #include "virchrdev.h" #include "virenum.h" =20 -#define JOB_MASK(job) (job =3D=3D 0 ? 0 : 1 << (job - 1)) -#define DEFAULT_JOB_MASK \ - (JOB_MASK(LIBXL_JOB_DESTROY) | \ - JOB_MASK(LIBXL_JOB_ABORT)) - /* Only 1 job is allowed at any time * A job includes *all* libxl.so api, even those just querying * information, not merely actions */ --=20 2.33.0 From nobody Wed Apr 24 16:16:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 16377110425898.434768369639755; Tue, 23 Nov 2021 15:44:02 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-168-mboTufyDMwm19O_6VSi6gg-1; Tue, 23 Nov 2021 18:43:57 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 88C27806689; Tue, 23 Nov 2021 23:43:52 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 37C39179B3; Tue, 23 Nov 2021 23:43:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 20F094EA37; Tue, 23 Nov 2021 23:43:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1ANNhkX6030057 for ; Tue, 23 Nov 2021 18:43:46 -0500 Received: by smtp.corp.redhat.com (Postfix) id A14FB40CFD0D; Tue, 23 Nov 2021 23:43:46 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 99E0440CFD04 for ; Tue, 23 Nov 2021 23:43:46 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7B1231066681 for ; Tue, 23 Nov 2021 23:43:46 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-502-emWVRqQ-May7ttfxuJOkYw-1; Tue, 23 Nov 2021 18:43:44 -0500 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-20-W5GsZDGJNNCJXzfDOAPLSA-1; Wed, 24 Nov 2021 00:43:42 +0100 Received: from AM0PR04MB4899.eurprd04.prod.outlook.com (2603:10a6:208:c5::16) by AM0PR04MB5508.eurprd04.prod.outlook.com (2603:10a6:208:112::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Tue, 23 Nov 2021 23:43:41 +0000 Received: from AM0PR04MB4899.eurprd04.prod.outlook.com ([fe80::c58b:de4e:3ba7:9ef6]) by AM0PR04MB4899.eurprd04.prod.outlook.com ([fe80::c58b:de4e:3ba7:9ef6%4]) with mapi id 15.20.4713.026; Tue, 23 Nov 2021 23:43:41 +0000 Received: from localhost (75.169.35.15) by AS9PR06CA0228.eurprd06.prod.outlook.com (2603:10a6:20b:45e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22 via Frontend Transport; Tue, 23 Nov 2021 23:43:40 +0000 X-MC-Unique: mboTufyDMwm19O_6VSi6gg-1 X-MC-Unique: emWVRqQ-May7ttfxuJOkYw-1 X-MC-Unique: W5GsZDGJNNCJXzfDOAPLSA-1 From: Jim Fehlig To: libvir-list@redhat.com Subject: [PATCH 2/2] libxl: Don't derive libxlDomainObjPrivate from virObjectLockable Date: Tue, 23 Nov 2021 16:43:30 -0700 Message-ID: <20211123234330.5138-3-jfehlig@suse.com> In-Reply-To: <20211123234330.5138-1-jfehlig@suse.com> References: <20211123234330.5138-1-jfehlig@suse.com> X-ClientProxiedBy: AS9PR06CA0228.eurprd06.prod.outlook.com (2603:10a6:20b:45e::20) To AM0PR04MB4899.eurprd04.prod.outlook.com (2603:10a6:208:c5::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e94b6971-b0be-425b-f705-08d9aedb1470 X-MS-TrafficTypeDiagnostic: AM0PR04MB5508: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1388 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: 1AOUqZA9TZdO/67FZWRi3eZSSWnxvjNTUdnZ+p1dfcwPE5Xurifu1hMfozefZQUEjVUSy4YjrwGoMSQPAfZv6Jr5SIC1DY68Zh4PsuLt49NSJbbzJBqtXulZIQCsX+VkUJfAqGayrwPq4AsQWC7STfEmqs49oqxx22onnv/xRo+Ae/0r+Y0w6Tk+lPGh9p5QnmCVkcfUok3x3yA9gAXohrgCUFkzGXOBoGj61+lxB88PWsJD1VLsGvI7jnpTMrtX7UV6PXhVjOc5EOW4HTocx8YBR/1lU6aD//TPJALrlk3NJtmflTFp42KKSV4R6NUZNo8wQCGNbkLaHvovzBRRjRvZUQ5XMejYLxgpFRH+IWcgda1V78hM3IICy2mbeMZa6/7rBm/D+e6rvVzgo+kuFL7QG3c0Nk+In3AKsgnM9B+XW8S1te882xihkbJ1gDIyvFmRVPiLOf7IDzy/dZeG9MWVteYNhCc+v5cvMUVYUkGWJMjD5gtTz2U/DbHY2n3ud2TtbY37pmx7OZ+w/v08VKrhddK4soVDjZlu1oH0Oy1R/RluM19GBprmnsu8upUeUb2CqIlVlE/EDIzyX8MrATm2rik2LIc8ldBcm5Is7hhlJ+JXMOiB3gonDkMka0uIuPlrt9vgYEOvd+US0TD4B40a04o/fZ8MgyGVYtIAyYgOFCp4bNYraGicVZFBOZ6LKJ2ICazBPtl8O115k5cJng== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR04MB4899.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(26005)(2906002)(36756003)(8936002)(1076003)(6486002)(2616005)(956004)(186003)(86362001)(6916009)(66556008)(6496006)(6666004)(5660300002)(38100700002)(66476007)(83380400001)(66946007)(508600001)(316002)(8676002)(145543001); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XDzLeMdVGdgxA7eubbrrLEMvlKg0bmVX4YKYZxc0RKEImakqHrUSPNQ5zpXA?= =?us-ascii?Q?6PLknDgr8/K7XnlTrF8i1UNFQnlcf9vBs7c5h3M35EGhvypAOa9vK4tc5WQ2?= =?us-ascii?Q?yomr+vGjIMo60D/dMf6NF3mvP2fqiAV97Wz1mF66dbDM1Kr8syQSl9vk8uII?= =?us-ascii?Q?cIcmZWERIxa9QDbSDoZlS7oOMJZWeebQFkbY7eR92YSN/sjo9NymIxQltH/y?= =?us-ascii?Q?61uA8LG7/LCejtX7IybmS0K7RSK19bxGeZgmU2o45zr9x7RDFNiTe+Zsdctf?= =?us-ascii?Q?J5tAYzxf0YeG0UFyr++PuxWTPnlhHCkC/hzUtQWL611QdYbUXtv7OKHQBGSE?= =?us-ascii?Q?GKJCnR6XfDBeF5G3seuoqD7VJIS+H+3V2O/7s6lmSnbKKlOujwchw4l9TawH?= =?us-ascii?Q?fDGtAsT1HKKljg0urLZgFFf9yeu4fhsWsLXhr9ME54mBIBAFUcTcLadSA3mu?= =?us-ascii?Q?foZtZoAjd7udfE+ZS2rme0xgZW7HOyqjTLItebX38yRTSaYTghjW/LxS/AsE?= =?us-ascii?Q?nkPgH92a358/9Ndih2TS4sMq5QrxONacghMOR221kjNWSBNqHMYLzHvEHg9L?= =?us-ascii?Q?i+DUMBxZY2F2NpZwSXWuzLhEv3oddyCNHKgxgmjUYjLhn8n7dLL1fUO9YS1v?= =?us-ascii?Q?kx9IZnyRP0uKmsiuluHP+IsSVj7JGKCJM2d0+Kuf5zRm4w2FA0B+tu+ZX9iE?= =?us-ascii?Q?jb9GcH8TfFFJ8tcVz0PrJq1gdgA8tb4NPrI2Appl6B8Fpu+1i38WRUgWmwek?= =?us-ascii?Q?4iXagS0E1DqmJYP68V2OeQNgS2UHzTxUZZWCqJ0nxjOlF6CcBJBs906h3lA7?= =?us-ascii?Q?rWOwVszBBqDrqjT68SMywJrS5V3xqzTvY3hdgq0nPhQ611Qh1F0vG7ZHoV+H?= =?us-ascii?Q?FnBN1Ru4tRmzZLp4Yl2NqdQ56YSA3FC5my+YKNLXyaPCJamXnkcLfUpo/bXn?= =?us-ascii?Q?jTcexHRn7JhBz11pQr+pw3rvKui3DQZWi4MbrYG7gg+SHdlEV/gb3/gBd4Il?= =?us-ascii?Q?NOpnUr5MyedPb88RkkFmFsW5vixWoqHw8dYOc2d+3JEW964qunoH/Dly2y/Z?= =?us-ascii?Q?+qVkoplzC4cEDuyKsjD8ytguOhPSnvV7TKNaVJyKwSej3dB5kVoksHAKyvyq?= =?us-ascii?Q?0WkAoEMd6Gj3YJtOLNc6dgahN+6Z8KgJepAANpi8esV6BX2M1XTJ+gRVyOYW?= =?us-ascii?Q?1At/oKqjzveMFywHA+dz8NgmwZH9K/Bdx92Awqg1MHIbQ4mrCXKRekr8C577?= =?us-ascii?Q?x7sh7gHrC8/SSLmDG0oGO+qfFLpcyAp/k/UnBpU2hrWKzlLdUf22X1pkkzqh?= =?us-ascii?Q?AH4oMImvEQuzLBhpDYjOBrFPthlIT2ErklBoOorDWBvw1oWz0mHArHdZsrPu?= =?us-ascii?Q?aRXA+VjaVEarModlBpRRG3ttKNK624euVM1vRIRCcYgvkv0aU6UleWu9z6OW?= =?us-ascii?Q?xqfQuyi7+uA4jSOLVKDpTlA3A1UBi0u/9W2k4zPwEkzQIEBlEdD3VFgmt1xY?= =?us-ascii?Q?3HJQk+s6k0n9JVuCHJvWHoO0M8dBjLwIzXhmXRNpqm1//7koXB36aPU6CpfS?= =?us-ascii?Q?TcwdpcRR65dNiib7yuW8KNTQKmzCiFwdwIlWy5vm5opBgmyHMe3Vl7SPFgik?= =?us-ascii?Q?lVwqngNpZ/RQp/Vd9udy4J0=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e94b6971-b0be-425b-f705-08d9aedb1470 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB4899.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 23:43:41.6602 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zpluqQM+wyWQHG6IoR0kjZNE/G6f9hnawA0ati0DFea4/FziZVGZx0if/h/a6fRXgxjjbUu2Te52bxo59XFijQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5508 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1ANNhkX6030057 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1637711045043100002 Content-Type: text/plain; charset="utf-8" The libxlDomainObjPrivate object is never locked and hence does not need to be a virObjectLockable object. Signed-off-by: Jim Fehlig Reviewed-by: Michal Privoznik --- src/libxl/libxl_domain.c | 38 ++++++-------------------------------- src/libxl/libxl_domain.h | 2 -- 2 files changed, 6 insertions(+), 34 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 4f61584ceb..0d94b85a0d 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -51,21 +51,6 @@ VIR_ENUM_IMPL(libxlDomainJob, "modify", ); =20 -static virClass *libxlDomainObjPrivateClass; - -static void -libxlDomainObjPrivateDispose(void *obj); - -static int -libxlDomainObjPrivateOnceInit(void) -{ - if (!VIR_CLASS_NEW(libxlDomainObjPrivate, virClassForObjectLockable())) - return -1; - - return 0; -} - -VIR_ONCE_GLOBAL_INIT(libxlDomainObjPrivate); =20 static int libxlDomainObjInitJob(libxlDomainObjPrivate *priv) @@ -206,42 +191,31 @@ libxlDomainObjPrivateAlloc(void *opaque G_GNUC_UNUSED) { libxlDomainObjPrivate *priv; =20 - if (libxlDomainObjPrivateInitialize() < 0) - return NULL; - - if (!(priv =3D virObjectLockableNew(libxlDomainObjPrivateClass))) - return NULL; + priv =3D g_new0(libxlDomainObjPrivate, 1); =20 if (!(priv->devs =3D virChrdevAlloc())) { - virObjectUnref(priv); + g_free(priv); return NULL; } =20 if (libxlDomainObjInitJob(priv) < 0) { virChrdevFree(priv->devs); - virObjectUnref(priv); + g_free(priv); return NULL; } =20 return priv; } =20 -static void -libxlDomainObjPrivateDispose(void *obj) -{ - libxlDomainObjPrivate *priv =3D obj; - - libxlDomainObjFreeJob(priv); - virChrdevFree(priv->devs); -} - static void libxlDomainObjPrivateFree(void *data) { libxlDomainObjPrivate *priv =3D data; =20 g_free(priv->lockState); - virObjectUnref(priv); + libxlDomainObjFreeJob(priv); + virChrdevFree(priv->devs); + g_free(priv); } =20 static int diff --git a/src/libxl/libxl_domain.h b/src/libxl/libxl_domain.h index 8d36197faf..661610bd3f 100644 --- a/src/libxl/libxl_domain.h +++ b/src/libxl/libxl_domain.h @@ -51,8 +51,6 @@ struct libxlDomainJobObj { =20 typedef struct _libxlDomainObjPrivate libxlDomainObjPrivate; struct _libxlDomainObjPrivate { - virObjectLockable parent; - /* console */ virChrdevs *devs; libxl_evgen_domain_death *deathW; --=20 2.33.0