libxl: Don't autostart domains on driver reload

[PATCH] libxl: Don't autostart domains on driver reload

Jim Fehlig posted 1 patch 2 years, 7 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210914171827.25501-1-jfehlig@suse.com

src/libxl/libxl_driver.c | 4 ----
1 file changed, 4 deletions(-)

Expand all Fold all

[PATCH] libxl: Don't autostart domains on driver reload

Posted by Jim Fehlig 2 years, 7 months ago

When libxlAutostartDomain was introduced with commit fb92307f0d, one hunk
mistakenly added a call site in libxlStateReload. Domains should not be
autostarted when reloading the driver, so remove the offending hunk.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---
 src/libxl/libxl_driver.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index c5dbcaafa5..7ea157f9c4 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
@@ -825,10 +825,6 @@ libxlStateReload(void)
                                    libxl_driver->xmlopt,
                                    NULL, libxl_driver);
 
-    virDomainObjListForEach(libxl_driver->domains, false,
-                            libxlAutostartDomain,
-                            libxl_driver);
-
     virObjectUnref(cfg);
     return 0;
 }
-- 
2.33.0

Re: [PATCH] libxl: Don't autostart domains on driver reload

Posted by Ján Tomko 2 years, 7 months ago

On a Tuesday in 2021, Jim Fehlig wrote:
>When libxlAutostartDomain was introduced with commit fb92307f0d, one hunk
>mistakenly added a call site in libxlStateReload. Domains should not be
>autostarted when reloading the driver, so remove the offending hunk.
>
>Signed-off-by: Jim Fehlig <jfehlig@suse.com>
>---
> src/libxl/libxl_driver.c | 4 ----
> 1 file changed, 4 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano