From nobody Fri Apr 26 04:36:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1631639930758546.8498133730822; Tue, 14 Sep 2021 10:18:50 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-270-XLumsm8bPwmxhDPZ1fxefQ-1; Tue, 14 Sep 2021 13:18:47 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 77E0C108468C; Tue, 14 Sep 2021 17:18:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D16686D981; Tue, 14 Sep 2021 17:18:41 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 78E7C4E58F; Tue, 14 Sep 2021 17:18:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 18EHIceV005090 for ; Tue, 14 Sep 2021 13:18:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7B481207A804; Tue, 14 Sep 2021 17:18:38 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7537E207A77D for ; Tue, 14 Sep 2021 17:18:35 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A0A848934E4 for ; Tue, 14 Sep 2021 17:18:35 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-475-53uyQ8_eOTmI9BrhNbakNg-1; Tue, 14 Sep 2021 13:18:33 -0400 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2055.outbound.protection.outlook.com [104.47.6.55]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-30-J5wUYgFlNN25TuoiYpTfoQ-1; Tue, 14 Sep 2021 19:18:31 +0200 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) by AM0PR0402MB3443.eurprd04.prod.outlook.com (2603:10a6:208:1b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.18; Tue, 14 Sep 2021 17:18:30 +0000 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::283c:d53f:95d5:9377]) by AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::283c:d53f:95d5:9377%8]) with mapi id 15.20.4523.014; Tue, 14 Sep 2021 17:18:30 +0000 Received: from localhost (192.225.185.198) by FR2P281CA0035.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.8 via Frontend Transport; Tue, 14 Sep 2021 17:18:29 +0000 X-MC-Unique: XLumsm8bPwmxhDPZ1fxefQ-1 X-MC-Unique: 53uyQ8_eOTmI9BrhNbakNg-1 X-MC-Unique: J5wUYgFlNN25TuoiYpTfoQ-1 From: Jim Fehlig To: libvir-list@redhat.com Subject: [PATCH] libxl: Don't autostart domains on driver reload Date: Tue, 14 Sep 2021 11:18:27 -0600 Message-ID: <20210914171827.25501-1-jfehlig@suse.com> X-ClientProxiedBy: FR2P281CA0035.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::22) To AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5e105442-e825-477f-b78b-08d977a3ac3d X-MS-TrafficTypeDiagnostic: AM0PR0402MB3443: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:283 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: lNu3/rcEXpxCRlfALbtJHDR9p4kNXk00Z/zoCgR7QYxm14cQsay0mHNeyWgruLxE8IIf10pRiY8YoUQtdoddU47vUlqxNNXPUXiWZNTWSiBjsG1uRbrVXNgLlecIzbKBWNsSTHbtVdGSo0T6cAUOY3prZ5moDJ8KGllRN7gsMwhX2ZASAtPaOvEWeFp0ftNLdDagmzqV+gnAExBsSgSLX7G66RafX6us4JrZjJrZao66wcIYeimrGoinBLNoL9KcYV4SErXzRnfY40cZxv7uKuOUx9hDfV3+MNKi1ONHqIr1RZ/azJTxAJBnw6K0RIYjik+wcS8MOSyHEFU7MuVqdmdmXd1HXwCgKL+FAiPTU143ZN7Q7lcua1osGCponeruyQjxl289EPhBfCZxHhSHxz1uuRhraHFR+GGmXazsVJC+rrwjqSy0q1F+x0jTRx89nx/bjc2lDy2VyG6iM+qmKmh6SUXqefnGTID7qMjmE3W7OGtQepnswzLASmlsBXjPHFeEmDWE9hrDTbPXaFylIXFlxg8k3sZ50N2q8EA4lTFDY8U6Ad0t4pXvyE+jDgtwkhIfUEj1JJbC7A+k5Y0MKsF/IymCvlqlKWAvHW0x/H8rCBgIIIuOJkdtDb7sxfYBn9YyNa9PB8U1e5i9qWVwDg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR04MB7970.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(366004)(346002)(396003)(39860400002)(136003)(66946007)(8936002)(66476007)(2906002)(186003)(26005)(38100700002)(6486002)(36756003)(66556008)(478600001)(2616005)(6916009)(316002)(86362001)(8676002)(6496006)(5660300002)(1076003)(83380400001)(956004)(4744005); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xXqI5pc8V6UEkR0pKYwTc6+X37lWq4iDvl73rU83Vm3DVXqBz+eh+lT+6gq0?= =?us-ascii?Q?GHIX4B7V7aGI9CN1h/Lt4u4mbTfWYQIH7p2wrDeT6DCTT0ersqBdYRKmOHrz?= =?us-ascii?Q?oUd0rsBsMfNTAdPicdx3wlFBe38PACezs/pQq/azfsnDfra4ikhnRjA7p4jh?= =?us-ascii?Q?d2dFxS6iF6jYuKH4D5/LFtzZvAcsmHtgLGhBXqSvMeOcoDEjkLKGjLUXdhHH?= =?us-ascii?Q?LAWC3/wwiPs0KrrLC+i5ZYHaFI+5EinAiyUZ0zrCRkuHnZglokgKuKXU6W+Y?= =?us-ascii?Q?/MxuTCtDah/sXag6yH4il87r9nhqK3BeQQ9qAgE8XA92FhArfv0VwZxy5dff?= =?us-ascii?Q?rmmxirMCGRjd70hdLpyyH+mI/dPAMyv4i5z6IRLgzlnILrVHaFVVFg19aCaB?= =?us-ascii?Q?xGIXBEDzbdRdII0Aa1Ityq/Z7vleL8on20APsvd6g+TyFN72i+URPTNKPqd/?= =?us-ascii?Q?LUq5g1rhz3TefuMHnaZSvvnfntrPSkWWS4xYkAtgn0PlMPnkE8YdafWq1dgB?= =?us-ascii?Q?+ho8Z4PWt/jyJUMhT5mS50IECUwBmR2Ma3980rS3eNXz+cdCFeRdXReCoGmc?= =?us-ascii?Q?/+fSlqy9vk1W8kxLTwEJEAoL2+WjGYUA5/d2cdNJN1lt1UO0V5nUsrY0jgdY?= =?us-ascii?Q?86O1R/TMM8Icu4SmQbjjQCMh2MiMjYj4qpPkzDlWLC9mVXk1oZCLgQc0H0OB?= =?us-ascii?Q?QbF8O3NJUfG0/Cj3i6vNkKWHBrzXmpBPQFgGaoWaNeIgOnA0RnRoeZo6DGPB?= =?us-ascii?Q?U31Y12Nd1OpqMCPHV/43E7blcI2sR5tgFFW7YZRlfZ7lpk5CSR1iwphTEzcB?= =?us-ascii?Q?8zTtW9aD8IlDNpJXEJisp7ztKOEJ1nFbPzvb9bYCl3jicxo5TpqjmG51Qk/0?= =?us-ascii?Q?cLUSLLale6GlYA9kgRwYM3vu2E/lYBphYEUEljTwVT+gEqCRnhb1HoWuaBrK?= =?us-ascii?Q?56igJb/x2ZDXsCfDEOfS3Y4iJs0tIW2WRP/xMgSrdd2xDk4dUx8ZrxELEM3P?= =?us-ascii?Q?FJict32ZZjHME9G9diRJA9IK7ubMIDF1F+WdRegVBszHTzgEx1FELhYmM/o6?= =?us-ascii?Q?t1fBkJiP5trF7Iqk3fVlh/XYw/JAZLH1ZYTaFbNDAt9XQNYiSAsBcLXaCYMj?= =?us-ascii?Q?7iAe2Oi6NJ6zWlhVbmgE/QaQuTsb8hlLdojN5+xdoAAv3nmYZxR1ePJEP2ux?= =?us-ascii?Q?Zx26Z8ie1qQLs2/Yvd3tRWIFRhamL5ngJTS8H9h2n0sPLjdfKQ2f8/zdArmE?= =?us-ascii?Q?M9GbvES2kDsQ2AgfificFIHbuY5fL2AA68vw27hx7hhHVBKlJSNbYorkTVRO?= =?us-ascii?Q?s8FBiyndkephXrvZPclty7ki?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e105442-e825-477f-b78b-08d977a3ac3d X-MS-Exchange-CrossTenant-AuthSource: AM8PR04MB7970.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2021 17:18:30.3473 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YjpBK/h/kxRaa2WFENg5wSyxZXvDO5XpEMiiBU4GhlhmyqR7LTx2LWsPI48YTgxq9kdHRV8fkNDUdP0D6s3EGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3443 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 18EHIceV005090 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1631639931926100001 Content-Type: text/plain; charset="utf-8" When libxlAutostartDomain was introduced with commit fb92307f0d, one hunk mistakenly added a call site in libxlStateReload. Domains should not be autostarted when reloading the driver, so remove the offending hunk. Signed-off-by: Jim Fehlig Reviewed-by: J=C3=A1n Tomko --- src/libxl/libxl_driver.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index c5dbcaafa5..7ea157f9c4 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -825,10 +825,6 @@ libxlStateReload(void) libxl_driver->xmlopt, NULL, libxl_driver); =20 - virDomainObjListForEach(libxl_driver->domains, false, - libxlAutostartDomain, - libxl_driver); - virObjectUnref(cfg); return 0; } --=20 2.33.0