virHashNew refactorings - part VIII

[libvirt PATCH 0/3] virHashNew refactorings - part VIII

Tim Wiederhake posted 3 patches 2 years, 9 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210723095648.80113-1-twiederh@redhat.com

src/conf/nwfilter_params.c | 7 ++-----
src/conf/virstorageobj.c   | 7 ++-----
src/util/virlockspace.c    | 3 +--
3 files changed, 5 insertions(+), 12 deletions(-)

Expand all Fold all

[libvirt PATCH 0/3] virHashNew refactorings - part VIII

Posted by Tim Wiederhake 2 years, 9 months ago

"virHashNew" cannot return NULL, yet we check for NULL in various places.

See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html.

* Patch #1 is a fixed version of
https://listman.redhat.com/archives/libvir-list/2021-July/msg00720.html.

* Patch #2 is a fixed version of
https://listman.redhat.com/archives/libvir-list/2021-July/msg00721.html.

* For patch #3, see
https://listman.redhat.com/archives/libvir-list/2021-July/msg00691.html.
I mixed something up and was under the impression that the libvirt code style
forbade `for` loops with anything else than `size_t` typed variables.

Tim Wiederhake (3):
  virLockSpaceNewPostExecRestart: `virHashNew` cannot return NULL
  WIP virStoragePoolObjListNew: `virHashNew` cannot return NULL
  virNWFilterParseParamAttributes: Simplify loop

 src/conf/nwfilter_params.c | 7 ++-----
 src/conf/virstorageobj.c   | 7 ++-----
 src/util/virlockspace.c    | 3 +--
 3 files changed, 5 insertions(+), 12 deletions(-)

-- 
2.31.1

Re: [libvirt PATCH 0/3] virHashNew refactorings - part VIII

Posted by Peter Krempa 2 years, 9 months ago

On Fri, Jul 23, 2021 at 11:56:45 +0200, Tim Wiederhake wrote:
> "virHashNew" cannot return NULL, yet we check for NULL in various places.
> 
> See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html.
> 
> * Patch #1 is a fixed version of
> https://listman.redhat.com/archives/libvir-list/2021-July/msg00720.html.
> 
> * Patch #2 is a fixed version of
> https://listman.redhat.com/archives/libvir-list/2021-July/msg00721.html.

These have R-b from previous posting since the requested changes are
minor. Also note that patch 2 now has broken summary (WIP).