From nobody Sat May 4 09:36:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627034227; cv=none; d=zohomail.com; s=zohoarc; b=lf5MqqMm99i6Nol3ZTjEioGTV6xJmR3xlwIOdwikaz8CgBfvrmxpLPDa9i04oAy++ztzS3le1K5EvUyl2b/zFr+XtmTqBjixi2IKC+uPamvViHbYiXzddhdlgywHG4b1Su3NrZPCEQLh3uw3BJOze10BBc9ikmAjtJc25zYt8Fw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627034227; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=M8AiHUoxu2mcuq1H+4HnGANGl6QMVaa5GmvnV+nadcE=; b=oDHgc6qD2pwR03zkwiarEh9dy7r1AuobwBQARsHTA2vwxzr2tnYpA3nGD53nEM2hpzTgXdw3zTBVHgUdE4xukfNghUBYKg6fCDz1k53wAl5Ud/ssyBbrg2mRnUDKolGEfkNpjYqGsNy3JmmCJlZYbM+/mwo1KsdGzkSfDI2x/tA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1627034227288880.6799562357157; Fri, 23 Jul 2021 02:57:07 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-575-vP9DJBg-O5q9FM8ocCBX7A-1; Fri, 23 Jul 2021 05:57:05 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 92D5B190B2A2; Fri, 23 Jul 2021 09:56:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4250A10016FB; Fri, 23 Jul 2021 09:56:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1016E4A7C9; Fri, 23 Jul 2021 09:56:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16N9us1u025268 for ; Fri, 23 Jul 2021 05:56:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id D360B60C81; Fri, 23 Jul 2021 09:56:54 +0000 (UTC) Received: from work.speedport.ip (unknown [10.39.192.177]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2BC0561095; Fri, 23 Jul 2021 09:56:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627034226; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=M8AiHUoxu2mcuq1H+4HnGANGl6QMVaa5GmvnV+nadcE=; b=WJgffz9ojhH1xa6xRbhnyXbTgOJGk5WMX9GaMC+ewAHlQ13fLUzYjeYUDExle5Vu+/SnnX vDSkDpzdQCkThCYGtICR8IG58rhw5xTz6gKml+qau1V4w5f4QTNdw0ovXN3KXMarTis70i MNx1BT6h+/Bas8e4zbHcawBWGF651J8= X-MC-Unique: vP9DJBg-O5q9FM8ocCBX7A-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 1/3] virLockSpaceNewPostExecRestart: `virHashNew` cannot return NULL Date: Fri, 23 Jul 2021 11:56:46 +0200 Message-Id: <20210723095648.80113-2-twiederh@redhat.com> In-Reply-To: <20210723095648.80113-1-twiederh@redhat.com> References: <20210723095648.80113-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627035130610100003 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/util/virlockspace.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virlockspace.c b/src/util/virlockspace.c index edf2ec907f..46bd922f35 100644 --- a/src/util/virlockspace.c +++ b/src/util/virlockspace.c @@ -293,8 +293,7 @@ virLockSpace *virLockSpaceNewPostExecRestart(virJSONVal= ue *object) return NULL; } =20 - if (!(lockspace->resources =3D virHashNew(virLockSpaceResourceDataFree= ))) - goto error; + lockspace->resources =3D virHashNew(virLockSpaceResourceDataFree); =20 if (virJSONValueObjectHasKey(object, "directory")) { const char *dir =3D virJSONValueObjectGetString(object, "directory= "); --=20 2.31.1 From nobody Sat May 4 09:36:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627034232; cv=none; d=zohomail.com; s=zohoarc; b=Br5vOlencmKmZMMPkunXquZAGLfeB/H0BV8NeK8CEoexWZjXGDKW0vg04x/xsPqFd/LuWVUxqFmt9PeqQWZ4zTlTyRSaTI1NdOgaN4lXUD0FNyp+BCk/h7T4jGIWZoso0yvJERCAPzZQt5aZHE5u7YIp4AZVbHu1g8o2uzK/5uM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627034232; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=67fo2DccjZ1NZ4dVuVFSSh1oJ2T/wZA8kCAkpw1p/a4=; b=OE2f6cvFyMCZay/YWxtLIWwXv9r8/cnX1HdnmiV9Os5RfSPEkinIbMM6ELP8jAXozqllQoyTH6eLiMbQ9uWluszfuSHxJ4xSHAAUh7jcPPkf2FnRLceRKkhsXm+gaRIjFqJZIH1fKP5F9+jHoqf9fQtQZ+L0qrm1qe2xcRUwA+8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1627034232751251.29434150058978; Fri, 23 Jul 2021 02:57:12 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-396-1D8QfqJsNXqzb3brLZD1tg-1; Fri, 23 Jul 2021 05:57:10 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 24DC634830; Fri, 23 Jul 2021 09:57:04 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 059665C230; Fri, 23 Jul 2021 09:57:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C6FF34A700; Fri, 23 Jul 2021 09:57:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16N9utOF025280 for ; Fri, 23 Jul 2021 05:56:55 -0400 Received: by smtp.corp.redhat.com (Postfix) id D8C74137F1; Fri, 23 Jul 2021 09:56:55 +0000 (UTC) Received: from work.speedport.ip (unknown [10.39.192.177]) by smtp.corp.redhat.com (Postfix) with ESMTP id 30B3E60C81; Fri, 23 Jul 2021 09:56:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627034231; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=67fo2DccjZ1NZ4dVuVFSSh1oJ2T/wZA8kCAkpw1p/a4=; b=adVA98bL4KhvkMaPXd2onN132bA/j8Ef02FIxM/Crru2wLlTkRNPY7ju1iS9hQzRLoAc+6 BtFoHkZBjBTNSreBI7EpfA7Ws/fyUU1VRha6GjswulqLpIc7sMYgTLN9Yk6H8e+yqouv5U fg5fo5M5pvEHf+nFKBZqmG5Aw9MHH1k= X-MC-Unique: 1D8QfqJsNXqzb3brLZD1tg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 2/3] WIP virStoragePoolObjListNew: `virHashNew` cannot return NULL Date: Fri, 23 Jul 2021 11:56:47 +0200 Message-Id: <20210723095648.80113-3-twiederh@redhat.com> In-Reply-To: <20210723095648.80113-1-twiederh@redhat.com> References: <20210723095648.80113-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627034234818100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/virstorageobj.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 32ed55ff8b..18a7718de9 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -398,11 +398,8 @@ virStoragePoolObjListNew(void) if (!(pools =3D virObjectRWLockableNew(virStoragePoolObjListClass))) return NULL; =20 - if (!(pools->objs =3D virHashNew(virObjectFreeHashData)) || - !(pools->objsName =3D virHashNew(virObjectFreeHashData))) { - virObjectUnref(pools); - return NULL; - } + pools->objs =3D virHashNew(virObjectFreeHashData); + pools->objsName =3D virHashNew(virObjectFreeHashData); =20 return pools; } --=20 2.31.1 From nobody Sat May 4 09:36:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627034227; cv=none; d=zohomail.com; s=zohoarc; b=crwyP6BpCRQjs5q1Pr//zC9CTMvX8BL+GLUI4tdLz0U7SSYQ2mdb8cA11RGny1tCOtYnoxam6yg6zAgzoRRrqLEYsuHTjq1bJoLF6ivFYT614PbvpRWYs2Dy0D5EjM2DYMvGyBOUntXWPpCq445yo+lHmODxZn8MK+p+y9VcupA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627034227; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XQH6zXCRpK/kSpqyqoLLAkDpc4+1nIR42POIMAKq+zY=; b=ktvdD1S1ZiHMQQ9eq19cnp7rJ/I+tCIbhdkzixQku9WepedDQKK+uSMttZA21lSfzzmeJyxoD53jdamF+LnKtMub93LtlEy96jrIo5Qmj6r/6W9L/q4lbcEv53cJEgc9RM8Bg9yyW7iY6iMTJgMXqp6qCrW7LH0rM6J1kYz1lhk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1627034227722124.88341495118709; Fri, 23 Jul 2021 02:57:07 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-563-uOdBuClsM6SK6hdz9_ZSlg-1; Fri, 23 Jul 2021 05:57:05 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 503023482F; Fri, 23 Jul 2021 09:56:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DC60460C5F; Fri, 23 Jul 2021 09:56:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A4ADB4BB7C; Fri, 23 Jul 2021 09:56:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16N9uvbD025285 for ; Fri, 23 Jul 2021 05:56:57 -0400 Received: by smtp.corp.redhat.com (Postfix) id 033D660C81; Fri, 23 Jul 2021 09:56:57 +0000 (UTC) Received: from work.speedport.ip (unknown [10.39.192.177]) by smtp.corp.redhat.com (Postfix) with ESMTP id 35A8F60C5F; Fri, 23 Jul 2021 09:56:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627034226; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=XQH6zXCRpK/kSpqyqoLLAkDpc4+1nIR42POIMAKq+zY=; b=XIStIyPkmP3/LDk2am07ztfVjJrtDnrPgZ5QU0AUR4275FZhGeZ+6JBZMfR73I3jbL82Qo nBshsOatuwjYh44dCstRAe1UJCS0au3a6/eXeYPbhn2Gclj2roNmMntIjm6VIrku0ALuxS Sh+aMnDFSEXXpgd3tfjH80WDzxzha9c= X-MC-Unique: uOdBuClsM6SK6hdz9_ZSlg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 3/3] virNWFilterParseParamAttributes: Simplify loop Date: Fri, 23 Jul 2021 11:56:48 +0200 Message-Id: <20210723095648.80113-4-twiederh@redhat.com> In-Reply-To: <20210723095648.80113-1-twiederh@redhat.com> References: <20210723095648.80113-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627034228564100002 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake Reviewed-by: J=C3=A1n Tomko --- src/conf/nwfilter_params.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c index 35ea0256c3..ca7b62874c 100644 --- a/src/conf/nwfilter_params.c +++ b/src/conf/nwfilter_params.c @@ -700,9 +700,8 @@ virNWFilterParseParamAttributes(xmlNodePtr cur) { g_autoptr(GHashTable) table =3D virHashNew(virNWFilterVarValueHashFree= ); =20 - cur =3D xmlFirstElementChild(cur); - - while (cur !=3D NULL) { + for (cur =3D xmlFirstElementChild(cur); cur !=3D NULL; + cur =3D xmlNextElementSibling(cur)) { if (virXMLNodeNameEqual(cur, "parameter")) { g_autofree char *nam =3D virXMLPropString(cur, "name"); g_autofree char *val =3D virXMLPropString(cur, "value"); @@ -710,7 +709,6 @@ virNWFilterParseParamAttributes(xmlNodePtr cur) =20 if (nam =3D=3D NULL || !isValidVarName(nam) || val =3D=3D NULL || !isValidVarValue(val)) { - cur =3D xmlNextElementSibling(cur); continue; } =20 @@ -725,7 +723,6 @@ virNWFilterParseParamAttributes(xmlNodePtr cur) } value =3D NULL; } - cur =3D xmlNextElementSibling(cur); } =20 return g_steal_pointer(&table); --=20 2.31.1