[PATCH 0/3] softmmu/vl: Deprecate old and crufty display options

Thomas Huth posted 3 patches 2 years, 9 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
docs/system/deprecated.rst | 20 ++++++++++++++++++++
qemu-options.hx            | 18 +++++++++++++-----
softmmu/vl.c               | 24 +++++++++++++++++++++---
3 files changed, 54 insertions(+), 8 deletions(-)
[PATCH 0/3] softmmu/vl: Deprecate old and crufty display options
Posted by Thomas Huth 2 years, 9 months ago
-display sdl uses a hand-crafted parser in vl.c, which is quite ugly
since the other parts of -display have been QAPIfied already. A straight
conversion to QAPI is not advisable since the "alt_grab" and "ctrl_grab"
parameters are not the best solution anyway. So this patch series
introduces a new "grab-mod" parameter as replacement instead and then
deprecates the old and crufty options.

While we're at it, the third patch also suggests to deprecated the
old -sdl and -curses top-level options.

Thomas Huth (3):
  softmmu/vl: Add a "grab-mod" parameter to the -display sdl option
  softmmu/vl: Deprecate the old grab options
  softmmu/vl: Deprecate the -sdl and -curses option

 docs/system/deprecated.rst | 20 ++++++++++++++++++++
 qemu-options.hx            | 18 +++++++++++++-----
 softmmu/vl.c               | 24 +++++++++++++++++++++---
 3 files changed, 54 insertions(+), 8 deletions(-)

-- 
2.27.0

Re: [PATCH 0/3] softmmu/vl: Deprecate old and crufty display options
Posted by Peter Krempa 2 years, 9 months ago
On Tue, Jul 06, 2021 at 16:54:10 +0200, Thomas Huth wrote:
> -display sdl uses a hand-crafted parser in vl.c, which is quite ugly
> since the other parts of -display have been QAPIfied already. A straight
> conversion to QAPI is not advisable since the "alt_grab" and "ctrl_grab"
> parameters are not the best solution anyway. So this patch series
> introduces a new "grab-mod" parameter as replacement instead and then
> deprecates the old and crufty options.
> 
> While we're at it, the third patch also suggests to deprecated the
> old -sdl and -curses top-level options.
> 
> Thomas Huth (3):
>   softmmu/vl: Add a "grab-mod" parameter to the -display sdl option
>   softmmu/vl: Deprecate the old grab options
>   softmmu/vl: Deprecate the -sdl and -curses option

libvirt doesn't use any of those old options any more so:

on behalf of libvirt:

ACKed-by: Peter Krempa <pkrempa@redhat.com>