[v2] Implement virDomainGetMessages for test driver

[PATCH v2 3/3] tests: Add messages for virshtest

Posted by Luke Yue 4 years, 7 months ago

As we introduced testDomainObjCheckTaint for test driver, the `dominfo`
command in virshtest will now print tainting messages, so add them for
test.

Signed-off-by: Luke Yue <lukedyue@gmail.com>
---
 tests/virshtest.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/virshtest.c b/tests/virshtest.c
index c1974c46cb..937448cefc 100644
--- a/tests/virshtest.c
+++ b/tests/virshtest.c
@@ -22,6 +22,7 @@ main(void)
 
 # define DOM_UUID "ef861801-45b9-11cb-88e3-afbfe5370493"
 # define SECURITY_LABEL "libvirt-test (enforcing)"
+# define MESSAGES "tainted: network configuration using opaque shell scripts"
 
 static const char *dominfo_fc4 = "\
 Id:             2\n\
@@ -38,6 +39,7 @@ Managed save:   no\n\
 Security model: testSecurity\n\
 Security DOI:   \n\
 Security label: " SECURITY_LABEL "\n\
+Messages:       " MESSAGES "\n\
 \n";
 static const char *domuuid_fc4 = DOM_UUID "\n\n";
 static const char *domid_fc4 = "2\n\n";
-- 
2.32.0

Re: [PATCH v2 3/3] tests: Add messages for virshtest

Posted by Martin Kletzander 4 years, 7 months ago

On Thu, Jun 24, 2021 at 07:00:01PM +0800, Luke Yue wrote:
>As we introduced testDomainObjCheckTaint for test driver, the `dominfo`
>command in virshtest will now print tainting messages, so add them for
>test.
>

We are trying to keep the code pass the test after each commit (easier for
bisection etc.) so this change should be squashed into the commit that
introduced the change which caused the output to change.

>Signed-off-by: Luke Yue <lukedyue@gmail.com>
>---
> tests/virshtest.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/tests/virshtest.c b/tests/virshtest.c
>index c1974c46cb..937448cefc 100644
>--- a/tests/virshtest.c
>+++ b/tests/virshtest.c
>@@ -22,6 +22,7 @@ main(void)
>
> # define DOM_UUID "ef861801-45b9-11cb-88e3-afbfe5370493"
> # define SECURITY_LABEL "libvirt-test (enforcing)"
>+# define MESSAGES "tainted: network configuration using opaque shell scripts"
>
> static const char *dominfo_fc4 = "\
> Id:             2\n\
>@@ -38,6 +39,7 @@ Managed save:   no\n\
> Security model: testSecurity\n\
> Security DOI:   \n\
> Security label: " SECURITY_LABEL "\n\
>+Messages:       " MESSAGES "\n\
> \n";
> static const char *domuuid_fc4 = DOM_UUID "\n\n";
> static const char *domid_fc4 = "2\n\n";
>-- 
>2.32.0
>

Re: [PATCH v2 3/3] tests: Add messages for virshtest

Posted by Luke Yue 4 years, 7 months ago

On Thu, 2021-06-24 at 17:14 +0200, Martin Kletzander wrote:
> On Thu, Jun 24, 2021 at 07:00:01PM +0800, Luke Yue wrote:
> > As we introduced testDomainObjCheckTaint for test driver, the
> > `dominfo`
> > command in virshtest will now print tainting messages, so add them
> > for
> > test.
> > 
> 
> We are trying to keep the code pass the test after each commit
> (easier for
> bisection etc.) so this change should be squashed into the commit
> that
> introduced the change which caused the output to change.
> 
OK, I will squash this commit in v3, thanks!

> > Signed-off-by: Luke Yue <lukedyue@gmail.com>
> > ---
> > tests/virshtest.c | 2 ++
> > 1 file changed, 2 insertions(+)
> > 
> > diff --git a/tests/virshtest.c b/tests/virshtest.c
> > index c1974c46cb..937448cefc 100644
> > --- a/tests/virshtest.c
> > +++ b/tests/virshtest.c
> > @@ -22,6 +22,7 @@ main(void)
> > 
> > # define DOM_UUID "ef861801-45b9-11cb-88e3-afbfe5370493"
> > # define SECURITY_LABEL "libvirt-test (enforcing)"
> > +# define MESSAGES "tainted: network configuration using opaque
> > shell scripts"
> > 
> > static const char *dominfo_fc4 = "\
> > Id:             2\n\
> > @@ -38,6 +39,7 @@ Managed save:   no\n\
> > Security model: testSecurity\n\
> > Security DOI:   \n\
> > Security label: " SECURITY_LABEL "\n\
> > +Messages:       " MESSAGES "\n\
> > \n";
> > static const char *domuuid_fc4 = DOM_UUID "\n\n";
> > static const char *domid_fc4 = "2\n\n";
> > -- 
> > 2.32.0
> >