[PATCH v4 0/4] Implement virDomainGetMessages for test driver

Luke Yue posted 4 patches 2 years, 9 months ago
Failed in applying to current master (apply log)
examples/xml/test/testdomfc5.xml     | 51 +++++++++++++++
examples/xml/test/testnode.xml       |  1 +
examples/xml/test/testnodeinline.xml | 51 +++++++++++++++
src/conf/domain_conf.c               | 53 +++++++++++++++
src/conf/domain_conf.h               |  5 ++
src/libvirt_private.syms             |  1 +
src/qemu/qemu_driver.c               | 34 +---------
src/test/test_driver.c               | 98 ++++++++++++++++++++++++++++
tests/virshtest.c                    | 52 +++++++++++++--
9 files changed, 306 insertions(+), 40 deletions(-)
create mode 100644 examples/xml/test/testdomfc5.xml
[PATCH v4 0/4] Implement virDomainGetMessages for test driver
Posted by Luke Yue 2 years, 9 months ago
v4:
- Move testDomainObjCheckTaint to testParseDomains()
- Add CPU tainted and deprecation check
- Add a new xml with more tainted configs

Luke Yue (4):
  conf: domain: Introduce and use virDomainObjGetMessages()
  test_driver: Implement virDomainGetMessages
  test_driver: Introduce testDomainObjCheckTaint
  examples: test: Add a new test xml with more tainted configs for
    testing

 examples/xml/test/testdomfc5.xml     | 51 +++++++++++++++
 examples/xml/test/testnode.xml       |  1 +
 examples/xml/test/testnodeinline.xml | 51 +++++++++++++++
 src/conf/domain_conf.c               | 53 +++++++++++++++
 src/conf/domain_conf.h               |  5 ++
 src/libvirt_private.syms             |  1 +
 src/qemu/qemu_driver.c               | 34 +---------
 src/test/test_driver.c               | 98 ++++++++++++++++++++++++++++
 tests/virshtest.c                    | 52 +++++++++++++--
 9 files changed, 306 insertions(+), 40 deletions(-)
 create mode 100644 examples/xml/test/testdomfc5.xml

-- 
2.32.0

Re: [PATCH v4 0/4] Implement virDomainGetMessages for test driver
Posted by Martin Kletzander 2 years, 8 months ago
On Mon, Jul 12, 2021 at 07:32:13PM +0800, Luke Yue wrote:
>v4:
>- Move testDomainObjCheckTaint to testParseDomains()
>- Add CPU tainted and deprecation check
>- Add a new xml with more tainted configs
>

With the modification suggested in 1/4:0

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

>Luke Yue (4):
>  conf: domain: Introduce and use virDomainObjGetMessages()
>  test_driver: Implement virDomainGetMessages
>  test_driver: Introduce testDomainObjCheckTaint
>  examples: test: Add a new test xml with more tainted configs for
>    testing
>
> examples/xml/test/testdomfc5.xml     | 51 +++++++++++++++
> examples/xml/test/testnode.xml       |  1 +
> examples/xml/test/testnodeinline.xml | 51 +++++++++++++++
> src/conf/domain_conf.c               | 53 +++++++++++++++
> src/conf/domain_conf.h               |  5 ++
> src/libvirt_private.syms             |  1 +
> src/qemu/qemu_driver.c               | 34 +---------
> src/test/test_driver.c               | 98 ++++++++++++++++++++++++++++
> tests/virshtest.c                    | 52 +++++++++++++--
> 9 files changed, 306 insertions(+), 40 deletions(-)
> create mode 100644 examples/xml/test/testdomfc5.xml
>
>-- 
>2.32.0
>