vahDeinit: Fix memory leak

[libvirt PATCH] vahDeinit: Fix memory leak

Tim Wiederhake posted 1 patch 3 years ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210422130733.136317-1-twiederh@redhat.com

src/security/virt-aa-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt PATCH] vahDeinit: Fix memory leak

Posted by Tim Wiederhake 3 years ago

Calling VIR_FREE on a virDomainDef* does not free its various contained
pointers.

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
---
 src/security/virt-aa-helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
index 68ac817f47..2331cc6648 100644
--- a/src/security/virt-aa-helper.c
+++ b/src/security/virt-aa-helper.c
@@ -79,7 +79,7 @@ vahDeinit(vahControl * ctl)
     if (ctl == NULL)
         return -1;
 
-    VIR_FREE(ctl->def);
+    virDomainDefFree(ctl->def);
     virObjectUnref(ctl->caps);
     virObjectUnref(ctl->xmlopt);
     VIR_FREE(ctl->files);
-- 
2.26.3

Re: [libvirt PATCH] vahDeinit: Fix memory leak

Posted by Ján Tomko 3 years ago

On a Thursday in 2021, Tim Wiederhake wrote:
>Calling VIR_FREE on a virDomainDef* does not free its various contained
>pointers.
>
>Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
>---
> src/security/virt-aa-helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano