From nobody Thu Apr 25 16:20:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1619096878; cv=none; d=zohomail.com; s=zohoarc; b=StU4tlOYzM7a19AwCvYmaeBi1+eGvqh9WkF03SRRCw0CFHWp9lsvfRp834aleBSIoeQ5g5mPRFQdjeTCq5cpcONvW4my2IBeMAS0uZMqbXGgTLbKrnWOyrdipm5qedxOqCsm2jEUV0uXYvXiXv1iuIyNp/CD+14O33A7njQKmjI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619096878; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=hpJtI3GwUdyd0vXYQx/gJ98kU6aVk9yaN2yFWA0mih0=; b=hqoYFAVTDNcTpKnY0QwgtuMFWQslcCr8wRtnRTZVmqkDYE/j0H2QPT/Ci92lS1QruhNjNdmwaR5YyDn8MWVYzG7foX6sSokOi5VhyrHH0jJjdcay4zzcBql7WqYtE9LP9zZaZlzP1CB1dteGSzzbsc7lPeAtpf6WFuHiDh/UvvA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1619096878451917.4579455728892; Thu, 22 Apr 2021 06:07:58 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-251-KoOyQCcLMO-R4QL5nL0x5A-1; Thu, 22 Apr 2021 09:07:51 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 087C984E20A; Thu, 22 Apr 2021 13:07:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB47560613; Thu, 22 Apr 2021 13:07:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AD9971809C82; Thu, 22 Apr 2021 13:07:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13MD7cD4023905 for ; Thu, 22 Apr 2021 09:07:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4B66960613; Thu, 22 Apr 2021 13:07:38 +0000 (UTC) Received: from work.redhat.com (ovpn-114-56.ams2.redhat.com [10.36.114.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8FE4960939; Thu, 22 Apr 2021 13:07:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619096874; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=hpJtI3GwUdyd0vXYQx/gJ98kU6aVk9yaN2yFWA0mih0=; b=VoCfgQzkovGzXN4qf+Zdw2EcADzwVKnn7AYJTfYpTRtaayExUVsdaG4AsY3pJEZQovo9p/ 21VFC1EYvc4adwU6qSn/YuObRwjyB2qiNYZMOUVtc1Rr8uujsldxoNMB+w13NBMGfUQRtY laPs4BttNdfRbENIuTTcjP6ElKUGlz8= X-MC-Unique: KoOyQCcLMO-R4QL5nL0x5A-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH] vahDeinit: Fix memory leak Date: Thu, 22 Apr 2021 15:07:33 +0200 Message-Id: <20210422130733.136317-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Calling VIR_FREE on a virDomainDef* does not free its various contained pointers. Signed-off-by: Tim Wiederhake Reviewed-by: J=C3=A1n Tomko --- src/security/virt-aa-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 68ac817f47..2331cc6648 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -79,7 +79,7 @@ vahDeinit(vahControl * ctl) if (ctl =3D=3D NULL) return -1; =20 - VIR_FREE(ctl->def); + virDomainDefFree(ctl->def); virObjectUnref(ctl->caps); virObjectUnref(ctl->xmlopt); VIR_FREE(ctl->files); --=20 2.26.3