[libvirt PATCH 2/3] virDomainFeaturesDefParse: Fix memory leak

Tim Wiederhake posted 3 patches 4 years, 10 months ago
There is a newer version of this series
[libvirt PATCH 2/3] virDomainFeaturesDefParse: Fix memory leak
Posted by Tim Wiederhake 4 years, 10 months ago
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
---
 src/conf/domain_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 029f2d8d9c..5591681283 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -18994,12 +18994,12 @@ virDomainFeaturesDefParse(virDomainDef *def,
         int feature;
         int value;
         g_autofree char *ptval = NULL;
-        g_autofree char *tmp = NULL;
 
         if ((n = virXPathNodeSet("./features/xen/*", ctxt, &nodes)) < 0)
             return -1;
 
         for (i = 0; i < n; i++) {
+            g_autofree char *tmp = NULL;
             feature = virDomainXenTypeFromString((const char *)nodes[i]->name);
             if (feature < 0) {
                 virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-- 
2.26.2

Re: [libvirt PATCH 2/3] virDomainFeaturesDefParse: Fix memory leak
Posted by Peter Krempa 4 years, 9 months ago
On Thu, Apr 15, 2021 at 17:08:27 +0200, Tim Wiederhake wrote:

Fixes: 94013ee04e3

> Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
> ---
>  src/conf/domain_conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>